public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <ahb.ipfire@gmail.com>
To: development@lists.ipfire.org
Subject: Re: Core Update 147 testing
Date: Fri, 03 Jul 2020 13:20:54 +0200	[thread overview]
Message-ID: <429536f4-3023-f9c2-8a8c-7d604a29fa02@gmail.com> (raw)
In-Reply-To: <0A5D1665-014B-4D4F-A894-67BEFF625A23@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 2744 bytes --]

Hi Michael,

Thanks for the information. I had missed the need to do that when I installed an updated bacula as a local add-on. The whole backup file requirement isn't mentioned in the Wiki page on installing your own add-on. I will think about maybe updating or rewriting that page using the bacula package as an example.

I will correct my files and submit a new patch. Do I make the patch based on the existing Core 146 9.0.6 version (so a v3 version of the patch) or on the Core 147 development build?


Regards,

Adolf.

On 03/07/2020 11:36, Michael Tremer wrote:
> Hi Adolf,
>
> This looks like a simple problem.
>
> The file is simply missing in the root file:
>
> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=config/rootfiles/packages/bacula;h=4ee408fc4154c56549bb7456f6e5be03791d48a2;hb=HEAD
>
> It should be listed there. Like here for example:
>
> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=config/rootfiles/packages/postfix;h=23e1efb255ceb5636117bf2907dce637756c83e9;hb=HEAD
>
> lfs/bacula doesn’t install the file either, like Postfix does:
>
> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=lfs/postfix;h=6ca3b23e93946c92d967bbbd23ec57d96883856b;hb=HEAD
>
> You can simply copy that command from postfix (of course change it to the right name), add it to the root file and then submit a patch :)
>
> Best,
> -Michael
>
>> On 3 Jul 2020, at 00:20, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>
>> Dear All,
>>
>> I went back to a Core Update 146 system and installed the old bacula 9.0.6 and found that version also had no backup include file in place, although it did exist in the config/backup/includes directory from the git clone.
>>
>> Adolf
>>
>>
>> On 03/07/2020 00:11, Adolf Belka wrote:
>>> Dear All,
>>>
>>> I have tested Core Update 147 out on my virtual ipfire test bed network.
>>>
>>> I also tested out installing bacula with its new version. It installed okay and started successfully. To test it out fully I will need to do the test on my production system.
>>>
>>> However I found one problem. The /var/ipfire/backup/addons/includes/bacula file is not there. There is no includes directory under addons and the bacula option is not there in the backup menu in the WUI.
>>>
>>> Probably something I did wrong in how I did my patch but I don't know what the problem is. The patch included the config/backup/includes/bacula file. Could someone figure out what the problem is.
>>>
>>> Apart from the problem with the bacula addon backup option not being present everything else on my testbed with update 147 is working fine, although it is not a complicated setup. Just red, green, blue and orange but no other options yet.
>>>
>>> Adolf.
>>>

  reply	other threads:[~2020-07-03 11:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 22:11 Adolf Belka
2020-07-02 23:20 ` Adolf Belka
2020-07-03  9:36   ` Michael Tremer
2020-07-03 11:20     ` Adolf Belka [this message]
2020-07-03 12:44       ` Michael Tremer
2020-07-04 13:04         ` Adolf Belka
2020-07-06 11:34           ` Adolf Belka
2020-07-06 14:20             ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=429536f4-3023-f9c2-8a8c-7d604a29fa02@gmail.com \
    --to=ahb.ipfire@gmail.com \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox