From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Test of cleanup branch Date: Thu, 08 Aug 2024 14:03:08 +0200 Message-ID: <432a3e7e-4dc7-4e57-9f01-2c06d7cebe92@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6369012545502272714==" List-Id: --===============6369012545502272714== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, On 07/08/2024 16:50, Michael Tremer wrote: > Hello Adolf, >=20 > I just pushed a large number of changes and hopefully I have addressed ever= ything. Mostly sorted but a couple of things still there. The client connection status on the OpenVPN page now shows the colour coding = but not on the IPSec page for the client connection. The addons list on the Services page now shows the colour coding. The Intrusion Prevention System is still showing as Stopped on the Services p= age when it is actually running. All the entry boxes I have looked at are no longer overlapping with other ele= ments. The Samba status for NetBIOS Nameserver Daemon SMB Daemon Winbind doesn't show any colour coding for the status of the daemons. Firewall Rules section looks good now. Regards, Adolf >=20 > Please let me know :) >=20 > -Michael >=20 >> On 7 Aug 2024, at 13:58, Adolf Belka wrote: >> >> Hi Michael, >> >> On 07/08/2024 14:19, Michael Tremer wrote: >>> Hello, >>> Thanks for looking at this again=E2=80=A6 >> No problem. This is something that I definitely can help with. >>>> On 7 Aug 2024, at 11:56, Adolf Belka wrote: >>>> >>>> Hi Michael, >>>> >>>> Yes, some of the problems have been fixed. >>>> >>>> On 06/08/2024 17:52, Michael Tremer wrote: >>>>> Hello, >>>>> I just pushed a bunch of changes that should hopefully resolve a few of= the problems. >>>>> The only one that I can see remaining is that all sorts of form element= s (dropdowns, input boxes, etc.) are now 100% in width. They fill the entire = horizontal space. This is something I like. However, without the scaffolding = around being consistent, this creates a lot of problems. Sometimes we have a = table that is properly sized, sometimes we have I don=E2=80=99t even know wha= t. I believe cleaning that up will be weeks worth of work because it is so fi= ddly. So, maybe I will revert that change and come up with a different soluti= on for OpenVPN. >>>> For the DNS Server page you have the protocol entry box which is now the= full width of the page but only has three letter acronyms to be entered. I d= on't have a big problem with that but I suspect that there might be some push= back from some forum members. >>> I think I will revert that one change so that we don=E2=80=99t have 1000 = new things to deal with... >> Sounds a good idea. >>>>> Please give the recent changes a test and let me know how it works. >>>> I made sure that I did a browser cache clear before reviewing the change= s. >>> I bumped the version of the CSS sheet so that the browser thinks it is a = new file: >>> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3D86ca826f= f133eb00b94ae47ac4ab27ac69f037c2 >> I ran a CU186 version on my vm and then changed to the latest CU188 versio= n without doing the browser cache clear and it looks like it did previously w= ith the cache clear so the new css version looks to have worked. >>>> The core programs section of the Services page now has colour on it for = the status of running or stopped. >>> Very good. It also has a very different layout. Do you think we need to l= abel the third column in any way to make it clear that it is memory usage? >> I am not sure. It seems very obvious to me but not sure about all users. >> >> Only thing I thought of was to have the first column have the service name= s centred. It is similar to the other two columns then and also places the na= mes nearer to the status and memory entries, so is easier to see which one li= nes up with which. >>>> The colours are not there for the status of any of the addons. >>> That I didn=E2=80=99t touch and clearly break. I did not have any adding = installed on the VM I set up for this. My bad. >>>> The Processes and Processes memory graphs that are normally on that page= are now completely missing. >>> I removed those. I don=E2=80=99t think that there is any value in them. T= hey are incomplete, the graphs themselves miss units and legends and labellin= g. They either need major work or need to go. Let me know how you feel about = it. >> As you removed them deliberately then that is fine. From my point of view,= I have always wondered exactly how I should interpret what they were showing= to me. I don't think I ever really took much notice of them, so fine that th= ey are gone. >>>> Screenshot attached. >>>> >>>> The colour for the status is not showing for the IPSec and OpenVPN clien= t connections. >>> On the index page? >> On the index page it is fine. It is on the actual OpenVPN and IPSec pages.= Attached is the OpenVPN screenshot for example. >>>> Also if you go to the Firewall Rules creation page the box to select Acc= ept, Drop or Reject has no colour. >>> Meh=E2=80=A6 Thank you for finding all these things. I didn=E2=80=99t eve= n occur to me to look at that. >> That is what I am here for. Another colour thing for the top level Firewal= l Rules page. Each rule has a line for the actual rule info and a second line= for the remark. If the rule does not have a remark then there is no second l= ine. The alternating grey shading is being done on each line rather than on t= he rule and remark line combined so it ends up looking a bit weird. >> Also the colour coding for the drop, reject, accept that used to be at the= start of each rule line is now missing. See attached screenshot. >>>> In the Services screenshot you can see that the Intrusion Prevention is = shown as Stopped but on the IPS page it is showing as running but with no col= our. See second screenshot, if you look closely you can see that it shows RUN= NING for the status. I checked on the command line and Suricata is running so= it is the Services page that has somehow got confused. >>> I forgot to cherry-pick the commit that uses the new widget for the IPS. >>> I fixed that now and will push shortly. >> I will test it when it arrives here. >> >> I also noticed that for the Samba addon, the top section for the status of= the three daemons does not have any colour coding as it used to have. See at= tached screenshot. >> >> Regards, >> Adolf. >>> -Michael >>>> >>>> Regards, >>>> >>>> Adolf. >>>>> -Michael >>>>>> On 3 Aug 2024, at 11:48, Adolf Belka wrote: >>>>>> >>>>>> Hi Michael, >>>>>> >>>>>> On 02/08/2024 11:12, Michael Tremer wrote: >>>>>>> Hello Adolf, >>>>>>> Thank you for looking at this in depth :) >>>>>>>> On 1 Aug 2024, at 16:01, Adolf Belka wrot= e: >>>>>>>> >>>>>>>> Hi Michael, >>>>>>>> >>>>>>>> Additional note written after all of the feedback below the dashed l= ine was written. I did a shutdown of the vm with CU188 to check something in = the CU186 vm then went back to the CU188 version and things had changed. Most= of the longer boxes are no longer longer and don't overlap other elements. T= he missing colours are back for IPSec, OpenVPN etc. >>>>>>> That is good news! >>>>>> >>>>>> In some later emails, I indicated that I found that the browser cache = was the reason that the colours came back. When I cleared my browser cache I = went back to no colours and longer overlapping entry boxes. >>>>>>>> The graph period selection previously was in a horizontal line under= the graph. Now it was still under the graph but it is now a vertical selecti= on choice which can't have been intended as it takes far too much space. Howe= ver the key thing is that rebooting seems to be making things change, which s= houldn't be happening. I have started to take screenshots of things to have s= ome evidence. >>>>>>> I think I have an explanation for this, and no, you are not going cra= zy. Since I have changed the CSS, it might be that the web UI is now renderin= g some different HTML, but your browser has the old CSS cached and so those t= hings don=E2=80=99t fit together any more. >>>>>>> This is a good example: https://git.ipfire.org/?p=3Dipfire-2.x.git;a= =3Dcommitdiff;h=3Dfbfde0088c58c506cab80d23fc240e3cab863302 >>>>>>> If you don=E2=80=99t have the changes from the CSS file, then you sim= ply won=E2=80=99t see any colours here. >>>>>> >>>>>> Yes, I found that the browser cache was affecting things. >>>>>> However, when I clear the cache the result I get is the loss of the co= lours in the services table page as an example or the overlapping of entry bo= xes in the dhcp page as an example. I can get this effect consistently with d= oing a fresh install and a browser cache clear. Have tested this out three ti= mes and always the same result. Longer boxes overlapping other elements and l= oss of status colours. See attached dhcp and services screenshots. >>>>>>> Some of the changes I implemented a user feedback - for example that = the headlines are hard to read on some devices that have not the best font re= ndering. Other things are probably more of my own things. The graphs used to = have a grey line around them. And then we had a box with another grey line ar= ound them. And then there was the big white box. It kind of reminded me of so= me mirror cabinet. >>>>>>> Sometimes we have multiple levels of headlines that all say the same:= Memory information -> Memory Graph -> Memory Usage per Day. >>>>>>>> Attached is a screenshot showing the graph period selectors which ar= e now vertically positioned at the bottom of the graphs. >>>>>>> So it is correct that the outer box is gone. The graph only has a hea= dline when it needs one. >>>>>>> The Hour/Day/Week/=E2=80=A6 controls should however remain the same. >>>>>> That is definitely different. They are now boxes containing the words = at the bottom of the graph rather than just the words at the top of the graph= and when first viewed all are grey (graph-example1) then become red when sel= ected (graph-example2). >>>>>>>> Also attached is a screenshot of the pakfire page that is still miss= ing the pak_ver numbers. >>>>>>> This is probably a bug from my changes in the tooling. >>>>>> I have seen the patch. Looks like that will fix it. Will test it to co= nfirm, either with build and install or using nightly build once done. >>>>>> >>>>>>>> I don't know what is going on here. >>>>>>> Me pushing a lot of changes at a fast pace :) >>>>>> :-) >>>>>>>> ---------------------------------------------- >>>>>>>> >>>>>>>> Okay, here is the feedback from reviewing a vm that actually include= d the cleanup branch changes. >>>>>>>> >>>>>>>> The home and ssh items look better with the change. They now use alt= ernating shades of grey to highlight each line. >>>>>>> This is now applied automatically to every table. Before, we used to = have a lot of Perl magic to make that happen. >>>>>> That looks good. >>>>>>>> All graphs have new selection buttons for Hour, Day, Weekly etc that= show in red when selected. This looks better. The default is the Day selecti= on but when you start with a graph it does not indicate that it is using the = Day option, ie all buttons are showing grey. >>>>>>> Okay, this would be something that needs fixing then. >>>>>>>> Net-Traffic and ExtraHD have the same tables but instead of being ce= ntred on the page they are now on the Left Hand Side of the WUI page. >>>>>>>> >>>>>>>> The Zone Config page looks much busier now. Previously the dropdown = box for native or vlan selection was next to the vlan id box and the space wa= s good enough for that. Now they are placed one above the other, so wider, wh= ich is not needed but they now fill the whole space of the section before the= next nic interface starts. I think the previous version looked clearer. >>>>>>>> >>>>>>>> The IPS page and the Services page no longer show the red or green b= ackground for running or stopped. You still see the words but they are now in= white on a light grey background or white on a slightly darker grey. >>>>>>>> >>>>>>>> On the Services page the first graph which should be titled Processe= s is labelled 100%. >>>>>>>> >>>>>>>> On the System page the graphs have no name at all. On the vm I used = they should have been labelled CPU and Load Avg. >>>>>>>> >>>>>>>> On the Pakfire page the list of available or installed addons do not= show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-= 20 >>>>>>>> >>>>>>>> The IPSec and OpenVPN pages no longer show the green, red or blue co= lours for the connection status. >>>>>>>> >>>>>>>> On the Firewall Rules page the table has no colours for Accept, Reje= ct or Drop for any of the rules. The alternate grey shading has got mixed up = as it is considering that if there is a remark line for a firewall rule that = is a separate line and the grey shading has to be changed. Definitely not rig= ht. Some of the Destinations have not had the right colour code applied for t= he zone colour - left grey. The boxes giving the policy applied for each fire= wall section are not colour coded for Allow or Blocked. >>>>>>>> >>>>>>>> On the actual firewall creation page, there are longer boxes that ov= erlap labels or other elements. There is no colour in the Drop, Reject, Accep= t selection box just one shade of grey. >>>>>>>> >>>>>>>> The vulnerabilities page has the left hand section now in black back= ground with white lettering. Different but probably okay. >>>>>>> Okay, this is all very useful. I will install a machine and go throug= h all of this and see what I can fix. >>>>>>>> The following menu items showed longer entry boxes that overlap labe= ls or other elements >>>>>>>> DHCP >>>>>>>> DNS Forward >>>>>>>> Static Routes >>>>>>>> Wake on LAN >>>>>>>> Time Server >>>>>>>> Log Settings >>>>>>>> Proxy Logs >>>>>>>> >>>>>>>> >>>>>>>> The following menu items showed longer entry boxes that did not over= lap other elements but you end up with a much longer box length than is neede= d for a day number for example >>>>>>>> Firewall Groups >>>>>>>> Firewall Options >>>>>>>> Blue Access >>>>>>>> Log Summary >>>>>>>> Dynamic DNS >>>>>>>> Proxy reports >>>>>>>> Firewall logs >>>>>>>> Firewall graphs - IP, Port & Country >>>>>>>> IPS Logs >>>>>>>> IP Address blocklist logs >>>>>>>> OpenVPN RW logs >>>>>>>> URL Filter Logs >>>>>>>> System Logs >>>>>>>> Captive portal >>>>>>>> Connection Scheduler >>>>>>>> Assign MAC Address >>>>>>>> >>>>>>>> >>>>>>>> The following menu items showed no change/issues except maybe for th= e graph period selection buttons . >>>>>>>> Backup >>>>>>>> Shutdown >>>>>>>> Credits >>>>>>>> Mailservice >>>>>>>> Memory >>>>>>>> Media >>>>>>>> Network External, Internal and Other >>>>>>>> OpenVPN RW and N2N Statistics >>>>>>>> WIO >>>>>>>> Hardware graphs >>>>>>>> Connections >>>>>>>> Mdstat >>>>>>>> DNS >>>>>>>> Web Proxy >>>>>>>> URL Filter >>>>>>>> Update Accelerator >>>>>>>> Edit Hosts >>>>>>>> QOS >>>>>>>> IP Address Blocklist >>>>>>>> Location Block >>>>>>>> IPTables >>>>>>>> >>>>>>>> I am really sorry for giving false hope that the cleanup branch had = gone really well. >>>>>>> Well, it happens :) That is why next is called next. >>>>>> Yes but me providing the original first review feedback on a vm system= that did not have the cleanup changes actually in it, really shouldn't have = happened. >>>>>> >>>>>> Regards, >>>>>> Adolf. >>>>>>> -Michael >>>>>>>> >>>>>>>> Regards, >>>>>>>> >>>>>>>> Adolf. >>>>>>>> >>>>>>>> On 01/08/2024 12:50, Adolf Belka wrote: >>>>>>>>> Hi Michael, >>>>>>>>> >>>>>>>>> On 25/07/2024 12:28, Adolf Belka wrote: >>>>>>>>>> Hi Michael, >>>>>>>>>> >>>>>>>>>> On 25/07/2024 10:44, Michael Tremer wrote: >>>>>>>>>>> Hello Adolf, >>>>>>>>>>> >>>>>>>>>>> Thank you for getting back on this so quickly. >>>>>>>>>>> >>>>>>>>> Maybe I got back too quickly!! >>>>>>>>> >>>>>>>>> I have just done a build with next for a bugfix patch and installed= it into my vm and the pages look quite different with some things missing, l= ike the green and red colours for if services are running or not and some gra= ph titles are incorrect. >>>>>>>>> >>>>>>>>> I took the iso from the latest directory in the nightly build but i= t looks like it was still linked to the previous version when I downloaded it= as the b2 sum is for build 6460dbbf from the day before. >>>>>>>>> >>>>>>>>> Downloading the iso today from the latest directory gives me the bu= ild ed2c97b7. >>>>>>>>> >>>>>>>>> I am going to install that version now but I suspect it will show t= he same as I found with my build. >>>>>>>>> >>>>>>>>> So it looks like my original review was based on the version before= the cleanup branch changes were included. >>>>>>>>> >>>>>>>>> I will come back with new feedback of what I find from the latest b= ranch that I have now downloaded. >>>>>>>>> >>>>>>>>> Sorry. In future maybe I should wait till the following day, or dow= nload from the build named directory instead of the directory named latest. >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> >>>>>>>>> Adolf >>>>>>>>> >>>>>>>>>>> I suppose this also means that the ISO in the next branch boots j= ust fine, too? >>>>>>>>>> >>>>>>>>>> Yes, that is correct. I used the iso from the nightly next latest = directory. No problems with the install at all. >>>>>>>>>> This tested out raid and all 4 interfaces. >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Adolf. >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Best, >>>>>>>>>>> -Michael >>>>>>>>>>> >>>>>>>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka = wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hi Michael, >>>>>>>>>>>> >>>>>>>>>>>> I installed CU188 from the nightly onto a vm system and looked t= hough all the WUI pages and everything looked fine. >>>>>>>>>>>> >>>>>>>>>>>> I then restored a CU187 backup from my testing and then checked = the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging f= or that all worked with no problems. >>>>>>>>>>>> >>>>>>>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rul= es, DNS ... >>>>>>>>>>>> >>>>>>>>>>>> Everything I have looked at shows no impact from the cleanup bra= nch changes. It looks good to me. >>>>>>>>>>>> >>>>>>>>>>>> Of course good for others to also evaluate. >>>>>>>>>>>> >>>>>>>>>>>> Regards, >>>>>>>>>>>> >>>>>>>>>>>> Adolf. >>>>>>>>>>>> >>>>>>>> >>>>>> >>>> >> >=20 --===============6369012545502272714==--