Re: Test of cleanup branch

Re: Test of cleanup branch

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 17444 bytes --]

Hello Adolf,

I just pushed a large number of changes and hopefully I have addressed everything.

Please let me know :)

-Michael

> On 7 Aug 2024, at 13:58, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> On 07/08/2024 14:19, Michael Tremer wrote:
>> Hello,
>> Thanks for looking at this again…
> No problem. This is something that I definitely can help with.
>>> On 7 Aug 2024, at 11:56, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> Hi Michael,
>>> 
>>> Yes, some of the problems have been fixed.
>>> 
>>> On 06/08/2024 17:52, Michael Tremer wrote:
>>>> Hello,
>>>> I just pushed a bunch of changes that should hopefully resolve a few of the problems.
>>>> The only one that I can see remaining is that all sorts of form elements (dropdowns, input boxes, etc.) are now 100% in width. They fill the entire horizontal space. This is something I like. However, without the scaffolding around being consistent, this creates a lot of problems. Sometimes we have a table that is properly sized, sometimes we have I don’t even know what. I believe cleaning that up will be weeks worth of work because it is so fiddly. So, maybe I will revert that change and come up with a different solution for OpenVPN.
>>> For the DNS Server page you have the protocol entry box which is now the full width of the page but only has three letter acronyms to be entered. I don't have a big problem with that but I suspect that there might be some pushback from some forum members.
>> I think I will revert that one change so that we don’t have 1000 new things to deal with...
> Sounds a good idea.
>>>> Please give the recent changes a test and let me know how it works.
>>> I made sure that I did a browser cache clear before reviewing the changes.
>> I bumped the version of the CSS sheet so that the browser thinks it is a new file:
>>   https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=86ca826ff133eb00b94ae47ac4ab27ac69f037c2
> I ran a CU186 version on my vm and then changed to the latest CU188 version without doing the browser cache clear and it looks like it did previously with the cache clear so the new css version looks to have worked.
>>> The core programs section of the Services page now has colour on it for the status of running or stopped.
>> Very good. It also has a very different layout. Do you think we need to label the third column in any way to make it clear that it is memory usage?
> I am not sure. It seems very obvious to me but not sure about all users.
> 
> Only thing I thought of was to have the first column have the service names centred. It is similar to the other two columns then and also places the names nearer to the status and memory entries, so is easier to see which one lines up with which.
>>> The colours are not there for the status of any of the addons.
>> That I didn’t touch and clearly break. I did not have any adding installed on the VM I set up for this. My bad.
>>> The Processes and Processes memory graphs that are normally on that page are now completely missing.
>> I removed those. I don’t think that there is any value in them. They are incomplete, the graphs themselves miss units and legends and labelling. They either need major work or need to go. Let me know how you feel about it.
> As you removed them deliberately then that is fine. From my point of view, I have always wondered exactly how I should interpret what they were showing to me. I don't think I ever really took much notice of them, so fine that they are gone.
>>> Screenshot attached.
>>> 
>>> The colour for the status is not showing for the IPSec and OpenVPN client connections.
>> On the index page?
> On the index page it is fine. It is on the actual OpenVPN and IPSec pages. Attached is the OpenVPN screenshot for example.
>>> Also if you go to the Firewall Rules creation page the box to select Accept, Drop or Reject has no colour.
>> Meh… Thank you for finding all these things. I didn’t even occur to me to look at that.
> That is what I am here for. Another colour thing for the top level Firewall Rules page. Each rule has a line for the actual rule info and a second line for the remark. If the rule does not have a remark then there is no second line. The alternating grey shading is being done on each line rather than on the rule and remark line combined so it ends up looking a bit weird.
> Also the colour coding for the drop, reject, accept that used to be at the start of each rule line is now missing. See attached screenshot.
>>> In the Services screenshot you can see that the Intrusion Prevention is shown as Stopped but on the IPS page it is showing as running but with no colour. See second screenshot, if you look closely you can see that it shows RUNNING for the status. I checked on the command line and Suricata is running so it is the Services page that has somehow got confused.
>> I forgot to cherry-pick the commit that uses the new widget for the IPS.
>> I fixed that now and will push shortly.
> I will test it when it arrives here.
> 
> I also noticed that for the Samba addon, the top section for the status of the three daemons does not have any colour coding as it used to have. See attached screenshot.
> 
> Regards,
> Adolf.
>> -Michael
>>> 
>>> Regards,
>>> 
>>> Adolf.
>>>> -Michael
>>>>> On 3 Aug 2024, at 11:48, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>> 
>>>>> Hi Michael,
>>>>> 
>>>>> On 02/08/2024 11:12, Michael Tremer wrote:
>>>>>> Hello Adolf,
>>>>>> Thank you for looking at this in depth :)
>>>>>>> On 1 Aug 2024, at 16:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>> 
>>>>>>> Hi Michael,
>>>>>>> 
>>>>>>> Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
>>>>>> That is good news!
>>>>> 
>>>>> In some later emails, I indicated that I found that the browser cache was the reason that the colours came back. When I cleared my browser cache I went back to no colours and longer overlapping entry boxes.
>>>>>>> The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
>>>>>> I think I have an explanation for this, and no, you are not going crazy. Since I have changed the CSS, it might be that the web UI is now rendering some different HTML, but your browser has the old CSS cached and so those things don’t fit together any more.
>>>>>> This is a good example: https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=fbfde0088c58c506cab80d23fc240e3cab863302
>>>>>> If you don’t have the changes from the CSS file, then you simply won’t see any colours here.
>>>>> 
>>>>> Yes, I found that the browser cache was affecting things.
>>>>> However, when I clear the cache the result I get is the loss of the colours in the services table page as an example or the overlapping of entry boxes in the dhcp page as an example. I can get this effect consistently with doing a fresh install and a browser cache clear. Have tested this out three times and always the same result. Longer boxes overlapping other elements and loss of status colours. See attached dhcp and services screenshots.
>>>>>> Some of the changes I implemented a user feedback - for example that the headlines are hard to read on some devices that have not the best font rendering. Other things are probably more of my own things. The graphs used to have a grey line around them. And then we had a box with another grey line around them. And then there was the big white box. It kind of reminded me of some mirror cabinet.
>>>>>> Sometimes we have multiple levels of headlines that all say the same: Memory information -> Memory Graph -> Memory Usage per Day.
>>>>>>> Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
>>>>>> So it is correct that the outer box is gone. The graph only has a headline when it needs one.
>>>>>> The Hour/Day/Week/… controls should however remain the same.
>>>>> That is definitely different. They are now boxes containing the words at the bottom of the graph rather than just the words at the top of the graph and when first viewed all are grey (graph-example1) then become red when selected (graph-example2).
>>>>>>> Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
>>>>>> This is probably a bug from my changes in the tooling.
>>>>> I have seen the patch. Looks like that will fix it. Will test it to confirm, either with build and install or using nightly build once done.
>>>>> 
>>>>>>> I don't know what is going on here.
>>>>>> Me pushing a lot of changes at a fast pace :)
>>>>> :-)
>>>>>>> ----------------------------------------------
>>>>>>> 
>>>>>>> Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
>>>>>>> 
>>>>>>> The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
>>>>>> This is now applied automatically to every table. Before, we used to have a lot of Perl magic to make that happen.
>>>>> That looks good.
>>>>>>> All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
>>>>>> Okay, this would be something that needs fixing then.
>>>>>>> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>>>>>>> 
>>>>>>> The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
>>>>>>> 
>>>>>>> The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
>>>>>>> 
>>>>>>> On the Services page the first graph which should be titled Processes is labelled 100%.
>>>>>>> 
>>>>>>> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>>>>>>> 
>>>>>>> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>>>>>> 
>>>>>>> The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
>>>>>>> 
>>>>>>> On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
>>>>>>> 
>>>>>>> On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
>>>>>>> 
>>>>>>> The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay.
>>>>>> Okay, this is all very useful. I will install a machine and go through all of this and see what I can fix.
>>>>>>> The following menu items showed longer entry boxes that overlap labels or other elements
>>>>>>> DHCP
>>>>>>> DNS Forward
>>>>>>> Static Routes
>>>>>>> Wake on LAN
>>>>>>> Time Server
>>>>>>> Log Settings
>>>>>>> Proxy Logs
>>>>>>> 
>>>>>>> 
>>>>>>> The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example
>>>>>>> Firewall Groups
>>>>>>> Firewall Options
>>>>>>> Blue Access
>>>>>>> Log Summary
>>>>>>> Dynamic DNS
>>>>>>> Proxy reports
>>>>>>> Firewall logs
>>>>>>> Firewall graphs - IP, Port & Country
>>>>>>> IPS Logs
>>>>>>> IP Address blocklist logs
>>>>>>> OpenVPN RW logs
>>>>>>> URL Filter Logs
>>>>>>> System Logs
>>>>>>> Captive portal
>>>>>>> Connection Scheduler
>>>>>>> Assign MAC Address
>>>>>>> 
>>>>>>> 
>>>>>>> The following menu items showed no change/issues except maybe for the graph period selection buttons .
>>>>>>> Backup
>>>>>>> Shutdown
>>>>>>> Credits
>>>>>>> Mailservice
>>>>>>> Memory
>>>>>>> Media
>>>>>>> Network External, Internal and Other
>>>>>>> OpenVPN RW and N2N Statistics
>>>>>>> WIO
>>>>>>> Hardware graphs
>>>>>>> Connections
>>>>>>> Mdstat
>>>>>>> DNS
>>>>>>> Web Proxy
>>>>>>> URL Filter
>>>>>>> Update Accelerator
>>>>>>> Edit Hosts
>>>>>>> QOS
>>>>>>> IP Address Blocklist
>>>>>>> Location Block
>>>>>>> IPTables
>>>>>>> 
>>>>>>> I am really sorry for giving false hope that the cleanup branch had gone really well.
>>>>>> Well, it happens :) That is why next is called next.
>>>>> Yes but me providing the original first review feedback on a vm system that did not have the cleanup changes actually in it, really shouldn't have happened.
>>>>> 
>>>>> Regards,
>>>>> Adolf.
>>>>>> -Michael
>>>>>>> 
>>>>>>> Regards,
>>>>>>> 
>>>>>>> Adolf.
>>>>>>> 
>>>>>>> On 01/08/2024 12:50, Adolf Belka wrote:
>>>>>>>> Hi Michael,
>>>>>>>> 
>>>>>>>> On 25/07/2024 12:28, Adolf Belka wrote:
>>>>>>>>> Hi Michael,
>>>>>>>>> 
>>>>>>>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>>>>>>>> Hello Adolf,
>>>>>>>>>> 
>>>>>>>>>> Thank you for getting back on this so quickly.
>>>>>>>>>> 
>>>>>>>> Maybe I got back too quickly!!
>>>>>>>> 
>>>>>>>> I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
>>>>>>>> 
>>>>>>>> I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
>>>>>>>> 
>>>>>>>> Downloading the iso today from the latest directory gives me the build ed2c97b7.
>>>>>>>> 
>>>>>>>> I am going to install that version now but I suspect it will show the same as I found with my build.
>>>>>>>> 
>>>>>>>> So it looks like my original review was based on the version before the cleanup branch changes were included.
>>>>>>>> 
>>>>>>>> I will come back with new feedback of what I find from the latest branch that I have now downloaded.
>>>>>>>> 
>>>>>>>> Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
>>>>>>>> 
>>>>>>>> Regards,
>>>>>>>> 
>>>>>>>> Adolf
>>>>>>>> 
>>>>>>>>>> I suppose this also means that the ISO in the next branch boots just fine, too?
>>>>>>>>> 
>>>>>>>>> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
>>>>>>>>> This tested out raid and all 4 interfaces.
>>>>>>>>> 
>>>>>>>>> Regards,
>>>>>>>>> Adolf.
>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> Best,
>>>>>>>>>> -Michael
>>>>>>>>>> 
>>>>>>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>>>>>> 
>>>>>>>>>>> Hi Michael,
>>>>>>>>>>> 
>>>>>>>>>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>>>>>>>>> 
>>>>>>>>>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>>>>>>>>> 
>>>>>>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>>>>>>>>> 
>>>>>>>>>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>>>>>>>>> 
>>>>>>>>>>> Of course good for others to also evaluate.
>>>>>>>>>>> 
>>>>>>>>>>> Regards,
>>>>>>>>>>> 
>>>>>>>>>>> Adolf.
>>>>>>>>>>> 
>>>>>>> <Screenshot_2024-08-01_16-45-00.png><Screenshot_2024-08-01_16-47-11.png>
>>>>> <dhcp.png><services.png><graph-example1.png><graph-example2.png>
>>> <Services_page_2024-08-07_12-44-08.png><IPS_page_2024-08-07_12-49-33.png>
> <OpenVPN_page_2024-08-07_14-39-58.png><Firewall_rules_2024-08-07_14-51-48.png><Samba_page_2024-08-07_14-40-58.png>

Re: Test of cleanup branch

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 18360 bytes --]

Hi Michael,

On 07/08/2024 16:50, Michael Tremer wrote:
> Hello Adolf,
> 
> I just pushed a large number of changes and hopefully I have addressed everything.
Mostly sorted but a couple of things still there.

The client connection status on the OpenVPN page now shows the colour coding but not on the IPSec page for the client connection.

The addons list on the Services page now shows the colour coding.

The Intrusion Prevention System is still showing as Stopped on the Services page when it is actually running.

All the entry boxes I have looked at are no longer overlapping with other elements.

The Samba status for
NetBIOS Nameserver Daemon
SMB Daemon
Winbind
doesn't show any colour coding for the status of the daemons.

Firewall Rules section looks good now.

Regards,
Adolf

> 
> Please let me know :)
> 
> -Michael
> 
>> On 7 Aug 2024, at 13:58, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> Hi Michael,
>>
>> On 07/08/2024 14:19, Michael Tremer wrote:
>>> Hello,
>>> Thanks for looking at this again…
>> No problem. This is something that I definitely can help with.
>>>> On 7 Aug 2024, at 11:56, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>
>>>> Hi Michael,
>>>>
>>>> Yes, some of the problems have been fixed.
>>>>
>>>> On 06/08/2024 17:52, Michael Tremer wrote:
>>>>> Hello,
>>>>> I just pushed a bunch of changes that should hopefully resolve a few of the problems.
>>>>> The only one that I can see remaining is that all sorts of form elements (dropdowns, input boxes, etc.) are now 100% in width. They fill the entire horizontal space. This is something I like. However, without the scaffolding around being consistent, this creates a lot of problems. Sometimes we have a table that is properly sized, sometimes we have I don’t even know what. I believe cleaning that up will be weeks worth of work because it is so fiddly. So, maybe I will revert that change and come up with a different solution for OpenVPN.
>>>> For the DNS Server page you have the protocol entry box which is now the full width of the page but only has three letter acronyms to be entered. I don't have a big problem with that but I suspect that there might be some pushback from some forum members.
>>> I think I will revert that one change so that we don’t have 1000 new things to deal with...
>> Sounds a good idea.
>>>>> Please give the recent changes a test and let me know how it works.
>>>> I made sure that I did a browser cache clear before reviewing the changes.
>>> I bumped the version of the CSS sheet so that the browser thinks it is a new file:
>>>    https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=86ca826ff133eb00b94ae47ac4ab27ac69f037c2
>> I ran a CU186 version on my vm and then changed to the latest CU188 version without doing the browser cache clear and it looks like it did previously with the cache clear so the new css version looks to have worked.
>>>> The core programs section of the Services page now has colour on it for the status of running or stopped.
>>> Very good. It also has a very different layout. Do you think we need to label the third column in any way to make it clear that it is memory usage?
>> I am not sure. It seems very obvious to me but not sure about all users.
>>
>> Only thing I thought of was to have the first column have the service names centred. It is similar to the other two columns then and also places the names nearer to the status and memory entries, so is easier to see which one lines up with which.
>>>> The colours are not there for the status of any of the addons.
>>> That I didn’t touch and clearly break. I did not have any adding installed on the VM I set up for this. My bad.
>>>> The Processes and Processes memory graphs that are normally on that page are now completely missing.
>>> I removed those. I don’t think that there is any value in them. They are incomplete, the graphs themselves miss units and legends and labelling. They either need major work or need to go. Let me know how you feel about it.
>> As you removed them deliberately then that is fine. From my point of view, I have always wondered exactly how I should interpret what they were showing to me. I don't think I ever really took much notice of them, so fine that they are gone.
>>>> Screenshot attached.
>>>>
>>>> The colour for the status is not showing for the IPSec and OpenVPN client connections.
>>> On the index page?
>> On the index page it is fine. It is on the actual OpenVPN and IPSec pages. Attached is the OpenVPN screenshot for example.
>>>> Also if you go to the Firewall Rules creation page the box to select Accept, Drop or Reject has no colour.
>>> Meh… Thank you for finding all these things. I didn’t even occur to me to look at that.
>> That is what I am here for. Another colour thing for the top level Firewall Rules page. Each rule has a line for the actual rule info and a second line for the remark. If the rule does not have a remark then there is no second line. The alternating grey shading is being done on each line rather than on the rule and remark line combined so it ends up looking a bit weird.
>> Also the colour coding for the drop, reject, accept that used to be at the start of each rule line is now missing. See attached screenshot.
>>>> In the Services screenshot you can see that the Intrusion Prevention is shown as Stopped but on the IPS page it is showing as running but with no colour. See second screenshot, if you look closely you can see that it shows RUNNING for the status. I checked on the command line and Suricata is running so it is the Services page that has somehow got confused.
>>> I forgot to cherry-pick the commit that uses the new widget for the IPS.
>>> I fixed that now and will push shortly.
>> I will test it when it arrives here.
>>
>> I also noticed that for the Samba addon, the top section for the status of the three daemons does not have any colour coding as it used to have. See attached screenshot.
>>
>> Regards,
>> Adolf.
>>> -Michael
>>>>
>>>> Regards,
>>>>
>>>> Adolf.
>>>>> -Michael
>>>>>> On 3 Aug 2024, at 11:48, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>
>>>>>> Hi Michael,
>>>>>>
>>>>>> On 02/08/2024 11:12, Michael Tremer wrote:
>>>>>>> Hello Adolf,
>>>>>>> Thank you for looking at this in depth :)
>>>>>>>> On 1 Aug 2024, at 16:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>>>
>>>>>>>> Hi Michael,
>>>>>>>>
>>>>>>>> Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
>>>>>>> That is good news!
>>>>>>
>>>>>> In some later emails, I indicated that I found that the browser cache was the reason that the colours came back. When I cleared my browser cache I went back to no colours and longer overlapping entry boxes.
>>>>>>>> The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
>>>>>>> I think I have an explanation for this, and no, you are not going crazy. Since I have changed the CSS, it might be that the web UI is now rendering some different HTML, but your browser has the old CSS cached and so those things don’t fit together any more.
>>>>>>> This is a good example: https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=fbfde0088c58c506cab80d23fc240e3cab863302
>>>>>>> If you don’t have the changes from the CSS file, then you simply won’t see any colours here.
>>>>>>
>>>>>> Yes, I found that the browser cache was affecting things.
>>>>>> However, when I clear the cache the result I get is the loss of the colours in the services table page as an example or the overlapping of entry boxes in the dhcp page as an example. I can get this effect consistently with doing a fresh install and a browser cache clear. Have tested this out three times and always the same result. Longer boxes overlapping other elements and loss of status colours. See attached dhcp and services screenshots.
>>>>>>> Some of the changes I implemented a user feedback - for example that the headlines are hard to read on some devices that have not the best font rendering. Other things are probably more of my own things. The graphs used to have a grey line around them. And then we had a box with another grey line around them. And then there was the big white box. It kind of reminded me of some mirror cabinet.
>>>>>>> Sometimes we have multiple levels of headlines that all say the same: Memory information -> Memory Graph -> Memory Usage per Day.
>>>>>>>> Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
>>>>>>> So it is correct that the outer box is gone. The graph only has a headline when it needs one.
>>>>>>> The Hour/Day/Week/… controls should however remain the same.
>>>>>> That is definitely different. They are now boxes containing the words at the bottom of the graph rather than just the words at the top of the graph and when first viewed all are grey (graph-example1) then become red when selected (graph-example2).
>>>>>>>> Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
>>>>>>> This is probably a bug from my changes in the tooling.
>>>>>> I have seen the patch. Looks like that will fix it. Will test it to confirm, either with build and install or using nightly build once done.
>>>>>>
>>>>>>>> I don't know what is going on here.
>>>>>>> Me pushing a lot of changes at a fast pace :)
>>>>>> :-)
>>>>>>>> ----------------------------------------------
>>>>>>>>
>>>>>>>> Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
>>>>>>>>
>>>>>>>> The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
>>>>>>> This is now applied automatically to every table. Before, we used to have a lot of Perl magic to make that happen.
>>>>>> That looks good.
>>>>>>>> All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
>>>>>>> Okay, this would be something that needs fixing then.
>>>>>>>> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>>>>>>>>
>>>>>>>> The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
>>>>>>>>
>>>>>>>> The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
>>>>>>>>
>>>>>>>> On the Services page the first graph which should be titled Processes is labelled 100%.
>>>>>>>>
>>>>>>>> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>>>>>>>>
>>>>>>>> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>>>>>>>
>>>>>>>> The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
>>>>>>>>
>>>>>>>> On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
>>>>>>>>
>>>>>>>> On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
>>>>>>>>
>>>>>>>> The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay.
>>>>>>> Okay, this is all very useful. I will install a machine and go through all of this and see what I can fix.
>>>>>>>> The following menu items showed longer entry boxes that overlap labels or other elements
>>>>>>>> DHCP
>>>>>>>> DNS Forward
>>>>>>>> Static Routes
>>>>>>>> Wake on LAN
>>>>>>>> Time Server
>>>>>>>> Log Settings
>>>>>>>> Proxy Logs
>>>>>>>>
>>>>>>>>
>>>>>>>> The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example
>>>>>>>> Firewall Groups
>>>>>>>> Firewall Options
>>>>>>>> Blue Access
>>>>>>>> Log Summary
>>>>>>>> Dynamic DNS
>>>>>>>> Proxy reports
>>>>>>>> Firewall logs
>>>>>>>> Firewall graphs - IP, Port & Country
>>>>>>>> IPS Logs
>>>>>>>> IP Address blocklist logs
>>>>>>>> OpenVPN RW logs
>>>>>>>> URL Filter Logs
>>>>>>>> System Logs
>>>>>>>> Captive portal
>>>>>>>> Connection Scheduler
>>>>>>>> Assign MAC Address
>>>>>>>>
>>>>>>>>
>>>>>>>> The following menu items showed no change/issues except maybe for the graph period selection buttons .
>>>>>>>> Backup
>>>>>>>> Shutdown
>>>>>>>> Credits
>>>>>>>> Mailservice
>>>>>>>> Memory
>>>>>>>> Media
>>>>>>>> Network External, Internal and Other
>>>>>>>> OpenVPN RW and N2N Statistics
>>>>>>>> WIO
>>>>>>>> Hardware graphs
>>>>>>>> Connections
>>>>>>>> Mdstat
>>>>>>>> DNS
>>>>>>>> Web Proxy
>>>>>>>> URL Filter
>>>>>>>> Update Accelerator
>>>>>>>> Edit Hosts
>>>>>>>> QOS
>>>>>>>> IP Address Blocklist
>>>>>>>> Location Block
>>>>>>>> IPTables
>>>>>>>>
>>>>>>>> I am really sorry for giving false hope that the cleanup branch had gone really well.
>>>>>>> Well, it happens :) That is why next is called next.
>>>>>> Yes but me providing the original first review feedback on a vm system that did not have the cleanup changes actually in it, really shouldn't have happened.
>>>>>>
>>>>>> Regards,
>>>>>> Adolf.
>>>>>>> -Michael
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>>
>>>>>>>> Adolf.
>>>>>>>>
>>>>>>>> On 01/08/2024 12:50, Adolf Belka wrote:
>>>>>>>>> Hi Michael,
>>>>>>>>>
>>>>>>>>> On 25/07/2024 12:28, Adolf Belka wrote:
>>>>>>>>>> Hi Michael,
>>>>>>>>>>
>>>>>>>>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>>>>>>>>> Hello Adolf,
>>>>>>>>>>>
>>>>>>>>>>> Thank you for getting back on this so quickly.
>>>>>>>>>>>
>>>>>>>>> Maybe I got back too quickly!!
>>>>>>>>>
>>>>>>>>> I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
>>>>>>>>>
>>>>>>>>> I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
>>>>>>>>>
>>>>>>>>> Downloading the iso today from the latest directory gives me the build ed2c97b7.
>>>>>>>>>
>>>>>>>>> I am going to install that version now but I suspect it will show the same as I found with my build.
>>>>>>>>>
>>>>>>>>> So it looks like my original review was based on the version before the cleanup branch changes were included.
>>>>>>>>>
>>>>>>>>> I will come back with new feedback of what I find from the latest branch that I have now downloaded.
>>>>>>>>>
>>>>>>>>> Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>>
>>>>>>>>> Adolf
>>>>>>>>>
>>>>>>>>>>> I suppose this also means that the ISO in the next branch boots just fine, too?
>>>>>>>>>>
>>>>>>>>>> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
>>>>>>>>>> This tested out raid and all 4 interfaces.
>>>>>>>>>>
>>>>>>>>>> Regards,
>>>>>>>>>> Adolf.
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Best,
>>>>>>>>>>> -Michael
>>>>>>>>>>>
>>>>>>>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> Hi Michael,
>>>>>>>>>>>>
>>>>>>>>>>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>>>>>>>>>>
>>>>>>>>>>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>>>>>>>>>>
>>>>>>>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>>>>>>>>>>
>>>>>>>>>>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>>>>>>>>>>
>>>>>>>>>>>> Of course good for others to also evaluate.
>>>>>>>>>>>>
>>>>>>>>>>>> Regards,
>>>>>>>>>>>>
>>>>>>>>>>>> Adolf.
>>>>>>>>>>>>
>>>>>>>> <Screenshot_2024-08-01_16-45-00.png><Screenshot_2024-08-01_16-47-11.png>
>>>>>> <dhcp.png><services.png><graph-example1.png><graph-example2.png>
>>>> <Services_page_2024-08-07_12-44-08.png><IPS_page_2024-08-07_12-49-33.png>
>> <OpenVPN_page_2024-08-07_14-39-58.png><Firewall_rules_2024-08-07_14-51-48.png><Samba_page_2024-08-07_14-40-58.png>
> 

Re: Test of cleanup branch

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 14043 bytes --]

Hi Michael,

Something I only just noticed. If I do a fresh install of the CU188 version then I no longer see the GPL page where I am supposed to check the checkbox that I accept the terms. That page is just completely missed.

Looking in /var/ipfire/main/ then the firstsetup_ok file is present but there is no gpl_accepted file but the installation completes okay and I am able to access the WUI.

Regards,

Adolf.


On 07/08/2024 12:56, Adolf Belka wrote:
> Hi Michael,
>
> Yes, some of the problems have been fixed.
>
> On 06/08/2024 17:52, Michael Tremer wrote:
>> Hello,
>>
>> I just pushed a bunch of changes that should hopefully resolve a few of the problems.
>>
>> The only one that I can see remaining is that all sorts of form elements (dropdowns, input boxes, etc.) are now 100% in width. They fill the entire horizontal space. This is something I like. However, without the scaffolding around being consistent, this creates a lot of problems. Sometimes we have a table that is properly sized, sometimes we have I don’t even know what. I believe cleaning that up will be weeks worth of work because it is so fiddly. So, maybe I will revert that change and come up with a different solution for OpenVPN.
> For the DNS Server page you have the protocol entry box which is now the full width of the page but only has three letter acronyms to be entered. I don't have a big problem with that but I suspect that there might be some pushback from some forum members.
>>
>> Please give the recent changes a test and let me know how it works.
> I made sure that I did a browser cache clear before reviewing the changes.
>
> The core programs section of the Services page now has colour on it for the status of running or stopped.
>
> The colours are not there for the status of any of the addons.
>
> The Processes and Processes memory graphs that are normally on that page are now completely missing.
>
> Screenshot attached.
>
> The colour for the status is not showing for the IPSec and OpenVPN client connections.
>
> Also if you go to the Firewall Rules creation page the box to select Accept, Drop or Reject has no colour.
>
> In the Services screenshot you can see that the Intrusion Prevention is shown as Stopped but on the IPS page it is showing as running but with no colour. See second screenshot, if you look closely you can see that it shows RUNNING for the status. I checked on the command line and Suricata is running so it is the Services page that has somehow got confused.
>
> Regards,
>
> Adolf.
>>
>> -Michael
>>
>>> On 3 Aug 2024, at 11:48, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>
>>> Hi Michael,
>>>
>>> On 02/08/2024 11:12, Michael Tremer wrote:
>>>> Hello Adolf,
>>>> Thank you for looking at this in depth :)
>>>>> On 1 Aug 2024, at 16:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>
>>>>> Hi Michael,
>>>>>
>>>>> Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
>>>> That is good news!
>>>
>>> In some later emails, I indicated that I found that the browser cache was the reason that the colours came back. When I cleared my browser cache I went back to no colours and longer overlapping entry boxes.
>>>>> The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
>>>> I think I have an explanation for this, and no, you are not going crazy. Since I have changed the CSS, it might be that the web UI is now rendering some different HTML, but your browser has the old CSS cached and so those things don’t fit together any more.
>>>> This is a good example: https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=fbfde0088c58c506cab80d23fc240e3cab863302
>>>> If you don’t have the changes from the CSS file, then you simply won’t see any colours here.
>>>
>>> Yes, I found that the browser cache was affecting things.
>>> However, when I clear the cache the result I get is the loss of the colours in the services table page as an example or the overlapping of entry boxes in the dhcp page as an example. I can get this effect consistently with doing a fresh install and a browser cache clear. Have tested this out three times and always the same result. Longer boxes overlapping other elements and loss of status colours. See attached dhcp and services screenshots.
>>>> Some of the changes I implemented a user feedback - for example that the headlines are hard to read on some devices that have not the best font rendering. Other things are probably more of my own things. The graphs used to have a grey line around them. And then we had a box with another grey line around them. And then there was the big white box. It kind of reminded me of some mirror cabinet.
>>>> Sometimes we have multiple levels of headlines that all say the same: Memory information -> Memory Graph -> Memory Usage per Day.
>>>>> Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
>>>> So it is correct that the outer box is gone. The graph only has a headline when it needs one.
>>>> The Hour/Day/Week/… controls should however remain the same.
>>> That is definitely different. They are now boxes containing the words at the bottom of the graph rather than just the words at the top of the graph and when first viewed all are grey (graph-example1) then become red when selected (graph-example2).
>>>>> Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
>>>> This is probably a bug from my changes in the tooling.
>>> I have seen the patch. Looks like that will fix it. Will test it to confirm, either with build and install or using nightly build once done.
>>>
>>>>> I don't know what is going on here.
>>>> Me pushing a lot of changes at a fast pace :)
>>> :-)
>>>>> ----------------------------------------------
>>>>>
>>>>> Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
>>>>>
>>>>> The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
>>>> This is now applied automatically to every table. Before, we used to have a lot of Perl magic to make that happen.
>>> That looks good.
>>>>> All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
>>>> Okay, this would be something that needs fixing then.
>>>>> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>>>>>
>>>>> The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
>>>>>
>>>>> The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
>>>>>
>>>>> On the Services page the first graph which should be titled Processes is labelled 100%.
>>>>>
>>>>> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>>>>>
>>>>> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>>>>
>>>>> The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
>>>>>
>>>>> On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
>>>>>
>>>>> On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
>>>>>
>>>>> The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay.
>>>> Okay, this is all very useful. I will install a machine and go through all of this and see what I can fix.
>>>>> The following menu items showed longer entry boxes that overlap labels or other elements
>>>>> DHCP
>>>>> DNS Forward
>>>>> Static Routes
>>>>> Wake on LAN
>>>>> Time Server
>>>>> Log Settings
>>>>> Proxy Logs
>>>>>
>>>>>
>>>>> The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example
>>>>> Firewall Groups
>>>>> Firewall Options
>>>>> Blue Access
>>>>> Log Summary
>>>>> Dynamic DNS
>>>>> Proxy reports
>>>>> Firewall logs
>>>>> Firewall graphs - IP, Port & Country
>>>>> IPS Logs
>>>>> IP Address blocklist logs
>>>>> OpenVPN RW logs
>>>>> URL Filter Logs
>>>>> System Logs
>>>>> Captive portal
>>>>> Connection Scheduler
>>>>> Assign MAC Address
>>>>>
>>>>>
>>>>> The following menu items showed no change/issues except maybe for the graph period selection buttons .
>>>>> Backup
>>>>> Shutdown
>>>>> Credits
>>>>> Mailservice
>>>>> Memory
>>>>> Media
>>>>> Network External, Internal and Other
>>>>> OpenVPN RW and N2N Statistics
>>>>> WIO
>>>>> Hardware graphs
>>>>> Connections
>>>>> Mdstat
>>>>> DNS
>>>>> Web Proxy
>>>>> URL Filter
>>>>> Update Accelerator
>>>>> Edit Hosts
>>>>> QOS
>>>>> IP Address Blocklist
>>>>> Location Block
>>>>> IPTables
>>>>>
>>>>> I am really sorry for giving false hope that the cleanup branch had gone really well.
>>>> Well, it happens :) That is why next is called next.
>>> Yes but me providing the original first review feedback on a vm system that did not have the cleanup changes actually in it, really shouldn't have happened.
>>>
>>> Regards,
>>> Adolf.
>>>> -Michael
>>>>>
>>>>> Regards,
>>>>>
>>>>> Adolf.
>>>>>
>>>>> On 01/08/2024 12:50, Adolf Belka wrote:
>>>>>> Hi Michael,
>>>>>>
>>>>>> On 25/07/2024 12:28, Adolf Belka wrote:
>>>>>>> Hi Michael,
>>>>>>>
>>>>>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>>>>>> Hello Adolf,
>>>>>>>>
>>>>>>>> Thank you for getting back on this so quickly.
>>>>>>>>
>>>>>> Maybe I got back too quickly!!
>>>>>>
>>>>>> I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
>>>>>>
>>>>>> I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
>>>>>>
>>>>>> Downloading the iso today from the latest directory gives me the build ed2c97b7.
>>>>>>
>>>>>> I am going to install that version now but I suspect it will show the same as I found with my build.
>>>>>>
>>>>>> So it looks like my original review was based on the version before the cleanup branch changes were included.
>>>>>>
>>>>>> I will come back with new feedback of what I find from the latest branch that I have now downloaded.
>>>>>>
>>>>>> Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Adolf
>>>>>>
>>>>>>>> I suppose this also means that the ISO in the next branch boots just fine, too?
>>>>>>>
>>>>>>> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
>>>>>>> This tested out raid and all 4 interfaces.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Adolf.
>>>>>>>
>>>>>>>>
>>>>>>>> Best,
>>>>>>>> -Michael
>>>>>>>>
>>>>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>>>>
>>>>>>>>> Hi Michael,
>>>>>>>>>
>>>>>>>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>>>>>>>
>>>>>>>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>>>>>>>
>>>>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>>>>>>>
>>>>>>>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>>>>>>>
>>>>>>>>> Of course good for others to also evaluate.
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>>
>>>>>>>>> Adolf.
>>>>>>>>>
>>>>> <Screenshot_2024-08-01_16-45-00.png><Screenshot_2024-08-01_16-47-11.png>
>>> <dhcp.png><services.png><graph-example1.png><graph-example2.png>
>>

Re: Test of cleanup branch

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 14455 bytes --]

Hi Michael,

On 07/08/2024 14:04, Adolf Belka wrote:
> Hi Michael,
>
> Something I only just noticed. If I do a fresh install of the CU188 version then I no longer see the GPL page where I am supposed to check the checkbox that I accept the terms. That page is just completely missed.
>
> Looking in /var/ipfire/main/ then the firstsetup_ok file is present but there is no gpl_accepted file but the installation completes okay and I am able to access the WUI.
>
After doing a restore and reboot, the gpl_accepted file was present in the directory.

Regards,

Adolf.

> Regards,
>
> Adolf.
>
>
> On 07/08/2024 12:56, Adolf Belka wrote:
>> Hi Michael,
>>
>> Yes, some of the problems have been fixed.
>>
>> On 06/08/2024 17:52, Michael Tremer wrote:
>>> Hello,
>>>
>>> I just pushed a bunch of changes that should hopefully resolve a few of the problems.
>>>
>>> The only one that I can see remaining is that all sorts of form elements (dropdowns, input boxes, etc.) are now 100% in width. They fill the entire horizontal space. This is something I like. However, without the scaffolding around being consistent, this creates a lot of problems. Sometimes we have a table that is properly sized, sometimes we have I don’t even know what. I believe cleaning that up will be weeks worth of work because it is so fiddly. So, maybe I will revert that change and come up with a different solution for OpenVPN.
>> For the DNS Server page you have the protocol entry box which is now the full width of the page but only has three letter acronyms to be entered. I don't have a big problem with that but I suspect that there might be some pushback from some forum members.
>>>
>>> Please give the recent changes a test and let me know how it works.
>> I made sure that I did a browser cache clear before reviewing the changes.
>>
>> The core programs section of the Services page now has colour on it for the status of running or stopped.
>>
>> The colours are not there for the status of any of the addons.
>>
>> The Processes and Processes memory graphs that are normally on that page are now completely missing.
>>
>> Screenshot attached.
>>
>> The colour for the status is not showing for the IPSec and OpenVPN client connections.
>>
>> Also if you go to the Firewall Rules creation page the box to select Accept, Drop or Reject has no colour.
>>
>> In the Services screenshot you can see that the Intrusion Prevention is shown as Stopped but on the IPS page it is showing as running but with no colour. See second screenshot, if you look closely you can see that it shows RUNNING for the status. I checked on the command line and Suricata is running so it is the Services page that has somehow got confused.
>>
>> Regards,
>>
>> Adolf.
>>>
>>> -Michael
>>>
>>>> On 3 Aug 2024, at 11:48, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>
>>>> Hi Michael,
>>>>
>>>> On 02/08/2024 11:12, Michael Tremer wrote:
>>>>> Hello Adolf,
>>>>> Thank you for looking at this in depth :)
>>>>>> On 1 Aug 2024, at 16:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>
>>>>>> Hi Michael,
>>>>>>
>>>>>> Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
>>>>> That is good news!
>>>>
>>>> In some later emails, I indicated that I found that the browser cache was the reason that the colours came back. When I cleared my browser cache I went back to no colours and longer overlapping entry boxes.
>>>>>> The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
>>>>> I think I have an explanation for this, and no, you are not going crazy. Since I have changed the CSS, it might be that the web UI is now rendering some different HTML, but your browser has the old CSS cached and so those things don’t fit together any more.
>>>>> This is a good example: https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=fbfde0088c58c506cab80d23fc240e3cab863302
>>>>> If you don’t have the changes from the CSS file, then you simply won’t see any colours here.
>>>>
>>>> Yes, I found that the browser cache was affecting things.
>>>> However, when I clear the cache the result I get is the loss of the colours in the services table page as an example or the overlapping of entry boxes in the dhcp page as an example. I can get this effect consistently with doing a fresh install and a browser cache clear. Have tested this out three times and always the same result. Longer boxes overlapping other elements and loss of status colours. See attached dhcp and services screenshots.
>>>>> Some of the changes I implemented a user feedback - for example that the headlines are hard to read on some devices that have not the best font rendering. Other things are probably more of my own things. The graphs used to have a grey line around them. And then we had a box with another grey line around them. And then there was the big white box. It kind of reminded me of some mirror cabinet.
>>>>> Sometimes we have multiple levels of headlines that all say the same: Memory information -> Memory Graph -> Memory Usage per Day.
>>>>>> Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
>>>>> So it is correct that the outer box is gone. The graph only has a headline when it needs one.
>>>>> The Hour/Day/Week/… controls should however remain the same.
>>>> That is definitely different. They are now boxes containing the words at the bottom of the graph rather than just the words at the top of the graph and when first viewed all are grey (graph-example1) then become red when selected (graph-example2).
>>>>>> Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
>>>>> This is probably a bug from my changes in the tooling.
>>>> I have seen the patch. Looks like that will fix it. Will test it to confirm, either with build and install or using nightly build once done.
>>>>
>>>>>> I don't know what is going on here.
>>>>> Me pushing a lot of changes at a fast pace :)
>>>> :-)
>>>>>> ----------------------------------------------
>>>>>>
>>>>>> Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
>>>>>>
>>>>>> The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
>>>>> This is now applied automatically to every table. Before, we used to have a lot of Perl magic to make that happen.
>>>> That looks good.
>>>>>> All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
>>>>> Okay, this would be something that needs fixing then.
>>>>>> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>>>>>>
>>>>>> The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
>>>>>>
>>>>>> The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
>>>>>>
>>>>>> On the Services page the first graph which should be titled Processes is labelled 100%.
>>>>>>
>>>>>> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>>>>>>
>>>>>> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>>>>>
>>>>>> The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
>>>>>>
>>>>>> On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
>>>>>>
>>>>>> On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
>>>>>>
>>>>>> The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay.
>>>>> Okay, this is all very useful. I will install a machine and go through all of this and see what I can fix.
>>>>>> The following menu items showed longer entry boxes that overlap labels or other elements
>>>>>> DHCP
>>>>>> DNS Forward
>>>>>> Static Routes
>>>>>> Wake on LAN
>>>>>> Time Server
>>>>>> Log Settings
>>>>>> Proxy Logs
>>>>>>
>>>>>>
>>>>>> The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example
>>>>>> Firewall Groups
>>>>>> Firewall Options
>>>>>> Blue Access
>>>>>> Log Summary
>>>>>> Dynamic DNS
>>>>>> Proxy reports
>>>>>> Firewall logs
>>>>>> Firewall graphs - IP, Port & Country
>>>>>> IPS Logs
>>>>>> IP Address blocklist logs
>>>>>> OpenVPN RW logs
>>>>>> URL Filter Logs
>>>>>> System Logs
>>>>>> Captive portal
>>>>>> Connection Scheduler
>>>>>> Assign MAC Address
>>>>>>
>>>>>>
>>>>>> The following menu items showed no change/issues except maybe for the graph period selection buttons .
>>>>>> Backup
>>>>>> Shutdown
>>>>>> Credits
>>>>>> Mailservice
>>>>>> Memory
>>>>>> Media
>>>>>> Network External, Internal and Other
>>>>>> OpenVPN RW and N2N Statistics
>>>>>> WIO
>>>>>> Hardware graphs
>>>>>> Connections
>>>>>> Mdstat
>>>>>> DNS
>>>>>> Web Proxy
>>>>>> URL Filter
>>>>>> Update Accelerator
>>>>>> Edit Hosts
>>>>>> QOS
>>>>>> IP Address Blocklist
>>>>>> Location Block
>>>>>> IPTables
>>>>>>
>>>>>> I am really sorry for giving false hope that the cleanup branch had gone really well.
>>>>> Well, it happens :) That is why next is called next.
>>>> Yes but me providing the original first review feedback on a vm system that did not have the cleanup changes actually in it, really shouldn't have happened.
>>>>
>>>> Regards,
>>>> Adolf.
>>>>> -Michael
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Adolf.
>>>>>>
>>>>>> On 01/08/2024 12:50, Adolf Belka wrote:
>>>>>>> Hi Michael,
>>>>>>>
>>>>>>> On 25/07/2024 12:28, Adolf Belka wrote:
>>>>>>>> Hi Michael,
>>>>>>>>
>>>>>>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>>>>>>> Hello Adolf,
>>>>>>>>>
>>>>>>>>> Thank you for getting back on this so quickly.
>>>>>>>>>
>>>>>>> Maybe I got back too quickly!!
>>>>>>>
>>>>>>> I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
>>>>>>>
>>>>>>> I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
>>>>>>>
>>>>>>> Downloading the iso today from the latest directory gives me the build ed2c97b7.
>>>>>>>
>>>>>>> I am going to install that version now but I suspect it will show the same as I found with my build.
>>>>>>>
>>>>>>> So it looks like my original review was based on the version before the cleanup branch changes were included.
>>>>>>>
>>>>>>> I will come back with new feedback of what I find from the latest branch that I have now downloaded.
>>>>>>>
>>>>>>> Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
>>>>>>>
>>>>>>> Regards,
>>>>>>>
>>>>>>> Adolf
>>>>>>>
>>>>>>>>> I suppose this also means that the ISO in the next branch boots just fine, too?
>>>>>>>>
>>>>>>>> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
>>>>>>>> This tested out raid and all 4 interfaces.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Adolf.
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Best,
>>>>>>>>> -Michael
>>>>>>>>>
>>>>>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi Michael,
>>>>>>>>>>
>>>>>>>>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>>>>>>>>
>>>>>>>>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>>>>>>>>
>>>>>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>>>>>>>>
>>>>>>>>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>>>>>>>>
>>>>>>>>>> Of course good for others to also evaluate.
>>>>>>>>>>
>>>>>>>>>> Regards,
>>>>>>>>>>
>>>>>>>>>> Adolf.
>>>>>>>>>>
>>>>>> <Screenshot_2024-08-01_16-45-00.png><Screenshot_2024-08-01_16-47-11.png>
>>>> <dhcp.png><services.png><graph-example1.png><graph-example2.png>
>>>

Re: Test of cleanup branch

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 14680 bytes --]

Hello,

Yes, I removed this too. It was getting on my nerves.

It servers no purpose because the GPL is not an EULA and so there is no value in asking users to accept it. And it won’t stop the bad guys anyways…

-Michael

> On 7 Aug 2024, at 13:04, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> Something I only just noticed. If I do a fresh install of the CU188 version then I no longer see the GPL page where I am supposed to check the checkbox that I accept the terms. That page is just completely missed.
> 
> Looking in /var/ipfire/main/ then the firstsetup_ok file is present but there is no gpl_accepted file but the installation completes okay and I am able to access the WUI.
> 
> Regards,
> 
> Adolf.
> 
> 
> On 07/08/2024 12:56, Adolf Belka wrote:
>> Hi Michael,
>> 
>> Yes, some of the problems have been fixed.
>> 
>> On 06/08/2024 17:52, Michael Tremer wrote:
>>> Hello,
>>> 
>>> I just pushed a bunch of changes that should hopefully resolve a few of the problems.
>>> 
>>> The only one that I can see remaining is that all sorts of form elements (dropdowns, input boxes, etc.) are now 100% in width. They fill the entire horizontal space. This is something I like. However, without the scaffolding around being consistent, this creates a lot of problems. Sometimes we have a table that is properly sized, sometimes we have I don’t even know what. I believe cleaning that up will be weeks worth of work because it is so fiddly. So, maybe I will revert that change and come up with a different solution for OpenVPN.
>> For the DNS Server page you have the protocol entry box which is now the full width of the page but only has three letter acronyms to be entered. I don't have a big problem with that but I suspect that there might be some pushback from some forum members.
>>> 
>>> Please give the recent changes a test and let me know how it works.
>> I made sure that I did a browser cache clear before reviewing the changes.
>> 
>> The core programs section of the Services page now has colour on it for the status of running or stopped.
>> 
>> The colours are not there for the status of any of the addons.
>> 
>> The Processes and Processes memory graphs that are normally on that page are now completely missing.
>> 
>> Screenshot attached.
>> 
>> The colour for the status is not showing for the IPSec and OpenVPN client connections.
>> 
>> Also if you go to the Firewall Rules creation page the box to select Accept, Drop or Reject has no colour.
>> 
>> In the Services screenshot you can see that the Intrusion Prevention is shown as Stopped but on the IPS page it is showing as running but with no colour. See second screenshot, if you look closely you can see that it shows RUNNING for the status. I checked on the command line and Suricata is running so it is the Services page that has somehow got confused.
>> 
>> Regards,
>> 
>> Adolf.
>>> 
>>> -Michael
>>> 
>>>> On 3 Aug 2024, at 11:48, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>> 
>>>> Hi Michael,
>>>> 
>>>> On 02/08/2024 11:12, Michael Tremer wrote:
>>>>> Hello Adolf,
>>>>> Thank you for looking at this in depth :)
>>>>>> On 1 Aug 2024, at 16:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>> 
>>>>>> Hi Michael,
>>>>>> 
>>>>>> Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
>>>>> That is good news!
>>>> 
>>>> In some later emails, I indicated that I found that the browser cache was the reason that the colours came back. When I cleared my browser cache I went back to no colours and longer overlapping entry boxes.
>>>>>> The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
>>>>> I think I have an explanation for this, and no, you are not going crazy. Since I have changed the CSS, it might be that the web UI is now rendering some different HTML, but your browser has the old CSS cached and so those things don’t fit together any more.
>>>>> This is a good example: https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=fbfde0088c58c506cab80d23fc240e3cab863302
>>>>> If you don’t have the changes from the CSS file, then you simply won’t see any colours here.
>>>> 
>>>> Yes, I found that the browser cache was affecting things.
>>>> However, when I clear the cache the result I get is the loss of the colours in the services table page as an example or the overlapping of entry boxes in the dhcp page as an example. I can get this effect consistently with doing a fresh install and a browser cache clear. Have tested this out three times and always the same result. Longer boxes overlapping other elements and loss of status colours. See attached dhcp and services screenshots.
>>>>> Some of the changes I implemented a user feedback - for example that the headlines are hard to read on some devices that have not the best font rendering. Other things are probably more of my own things. The graphs used to have a grey line around them. And then we had a box with another grey line around them. And then there was the big white box. It kind of reminded me of some mirror cabinet.
>>>>> Sometimes we have multiple levels of headlines that all say the same: Memory information -> Memory Graph -> Memory Usage per Day.
>>>>>> Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
>>>>> So it is correct that the outer box is gone. The graph only has a headline when it needs one.
>>>>> The Hour/Day/Week/… controls should however remain the same.
>>>> That is definitely different. They are now boxes containing the words at the bottom of the graph rather than just the words at the top of the graph and when first viewed all are grey (graph-example1) then become red when selected (graph-example2).
>>>>>> Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
>>>>> This is probably a bug from my changes in the tooling.
>>>> I have seen the patch. Looks like that will fix it. Will test it to confirm, either with build and install or using nightly build once done.
>>>> 
>>>>>> I don't know what is going on here.
>>>>> Me pushing a lot of changes at a fast pace :)
>>>> :-)
>>>>>> ----------------------------------------------
>>>>>> 
>>>>>> Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
>>>>>> 
>>>>>> The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
>>>>> This is now applied automatically to every table. Before, we used to have a lot of Perl magic to make that happen.
>>>> That looks good.
>>>>>> All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
>>>>> Okay, this would be something that needs fixing then.
>>>>>> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>>>>>> 
>>>>>> The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
>>>>>> 
>>>>>> The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
>>>>>> 
>>>>>> On the Services page the first graph which should be titled Processes is labelled 100%.
>>>>>> 
>>>>>> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>>>>>> 
>>>>>> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>>>>> 
>>>>>> The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
>>>>>> 
>>>>>> On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
>>>>>> 
>>>>>> On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
>>>>>> 
>>>>>> The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay.
>>>>> Okay, this is all very useful. I will install a machine and go through all of this and see what I can fix.
>>>>>> The following menu items showed longer entry boxes that overlap labels or other elements
>>>>>> DHCP
>>>>>> DNS Forward
>>>>>> Static Routes
>>>>>> Wake on LAN
>>>>>> Time Server
>>>>>> Log Settings
>>>>>> Proxy Logs
>>>>>> 
>>>>>> 
>>>>>> The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example
>>>>>> Firewall Groups
>>>>>> Firewall Options
>>>>>> Blue Access
>>>>>> Log Summary
>>>>>> Dynamic DNS
>>>>>> Proxy reports
>>>>>> Firewall logs
>>>>>> Firewall graphs - IP, Port & Country
>>>>>> IPS Logs
>>>>>> IP Address blocklist logs
>>>>>> OpenVPN RW logs
>>>>>> URL Filter Logs
>>>>>> System Logs
>>>>>> Captive portal
>>>>>> Connection Scheduler
>>>>>> Assign MAC Address
>>>>>> 
>>>>>> 
>>>>>> The following menu items showed no change/issues except maybe for the graph period selection buttons .
>>>>>> Backup
>>>>>> Shutdown
>>>>>> Credits
>>>>>> Mailservice
>>>>>> Memory
>>>>>> Media
>>>>>> Network External, Internal and Other
>>>>>> OpenVPN RW and N2N Statistics
>>>>>> WIO
>>>>>> Hardware graphs
>>>>>> Connections
>>>>>> Mdstat
>>>>>> DNS
>>>>>> Web Proxy
>>>>>> URL Filter
>>>>>> Update Accelerator
>>>>>> Edit Hosts
>>>>>> QOS
>>>>>> IP Address Blocklist
>>>>>> Location Block
>>>>>> IPTables
>>>>>> 
>>>>>> I am really sorry for giving false hope that the cleanup branch had gone really well.
>>>>> Well, it happens :) That is why next is called next.
>>>> Yes but me providing the original first review feedback on a vm system that did not have the cleanup changes actually in it, really shouldn't have happened.
>>>> 
>>>> Regards,
>>>> Adolf.
>>>>> -Michael
>>>>>> 
>>>>>> Regards,
>>>>>> 
>>>>>> Adolf.
>>>>>> 
>>>>>> On 01/08/2024 12:50, Adolf Belka wrote:
>>>>>>> Hi Michael,
>>>>>>> 
>>>>>>> On 25/07/2024 12:28, Adolf Belka wrote:
>>>>>>>> Hi Michael,
>>>>>>>> 
>>>>>>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>>>>>>> Hello Adolf,
>>>>>>>>> 
>>>>>>>>> Thank you for getting back on this so quickly.
>>>>>>>>> 
>>>>>>> Maybe I got back too quickly!!
>>>>>>> 
>>>>>>> I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
>>>>>>> 
>>>>>>> I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
>>>>>>> 
>>>>>>> Downloading the iso today from the latest directory gives me the build ed2c97b7.
>>>>>>> 
>>>>>>> I am going to install that version now but I suspect it will show the same as I found with my build.
>>>>>>> 
>>>>>>> So it looks like my original review was based on the version before the cleanup branch changes were included.
>>>>>>> 
>>>>>>> I will come back with new feedback of what I find from the latest branch that I have now downloaded.
>>>>>>> 
>>>>>>> Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
>>>>>>> 
>>>>>>> Regards,
>>>>>>> 
>>>>>>> Adolf
>>>>>>> 
>>>>>>>>> I suppose this also means that the ISO in the next branch boots just fine, too?
>>>>>>>> 
>>>>>>>> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
>>>>>>>> This tested out raid and all 4 interfaces.
>>>>>>>> 
>>>>>>>> Regards,
>>>>>>>> Adolf.
>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> Best,
>>>>>>>>> -Michael
>>>>>>>>> 
>>>>>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>>>>> 
>>>>>>>>>> Hi Michael,
>>>>>>>>>> 
>>>>>>>>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>>>>>>>> 
>>>>>>>>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>>>>>>>> 
>>>>>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>>>>>>>> 
>>>>>>>>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>>>>>>>> 
>>>>>>>>>> Of course good for others to also evaluate.
>>>>>>>>>> 
>>>>>>>>>> Regards,
>>>>>>>>>> 
>>>>>>>>>> Adolf.
>>>>>>>>>> 
>>>>>> <Screenshot_2024-08-01_16-45-00.png><Screenshot_2024-08-01_16-47-11.png>
>>>> <dhcp.png><services.png><graph-example1.png><graph-example2.png>
>>> 

Re: Test of cleanup branch

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 14841 bytes --]

Hello,

Thanks for looking at this again…

> On 7 Aug 2024, at 11:56, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> Yes, some of the problems have been fixed.
> 
> On 06/08/2024 17:52, Michael Tremer wrote:
>> Hello,
>> I just pushed a bunch of changes that should hopefully resolve a few of the problems.
>> The only one that I can see remaining is that all sorts of form elements (dropdowns, input boxes, etc.) are now 100% in width. They fill the entire horizontal space. This is something I like. However, without the scaffolding around being consistent, this creates a lot of problems. Sometimes we have a table that is properly sized, sometimes we have I don’t even know what. I believe cleaning that up will be weeks worth of work because it is so fiddly. So, maybe I will revert that change and come up with a different solution for OpenVPN.
> For the DNS Server page you have the protocol entry box which is now the full width of the page but only has three letter acronyms to be entered. I don't have a big problem with that but I suspect that there might be some pushback from some forum members.

I think I will revert that one change so that we don’t have 1000 new things to deal with...

>> Please give the recent changes a test and let me know how it works.
> I made sure that I did a browser cache clear before reviewing the changes.

I bumped the version of the CSS sheet so that the browser thinks it is a new file:

  https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=86ca826ff133eb00b94ae47ac4ab27ac69f037c2

> The core programs section of the Services page now has colour on it for the status of running or stopped.

Very good. It also has a very different layout. Do you think we need to label the third column in any way to make it clear that it is memory usage?

> The colours are not there for the status of any of the addons.

That I didn’t touch and clearly break. I did not have any adding installed on the VM I set up for this. My bad.

> The Processes and Processes memory graphs that are normally on that page are now completely missing.

I removed those. I don’t think that there is any value in them. They are incomplete, the graphs themselves miss units and legends and labelling. They either need major work or need to go. Let me know how you feel about it.

> Screenshot attached.
> 
> The colour for the status is not showing for the IPSec and OpenVPN client connections.

On the index page?

> Also if you go to the Firewall Rules creation page the box to select Accept, Drop or Reject has no colour.

Meh… Thank you for finding all these things. I didn’t even occur to me to look at that.

> In the Services screenshot you can see that the Intrusion Prevention is shown as Stopped but on the IPS page it is showing as running but with no colour. See second screenshot, if you look closely you can see that it shows RUNNING for the status. I checked on the command line and Suricata is running so it is the Services page that has somehow got confused.

I forgot to cherry-pick the commit that uses the new widget for the IPS.

I fixed that now and will push shortly.

-Michael

> 
> Regards,
> 
> Adolf.
>> -Michael
>>> On 3 Aug 2024, at 11:48, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> Hi Michael,
>>> 
>>> On 02/08/2024 11:12, Michael Tremer wrote:
>>>> Hello Adolf,
>>>> Thank you for looking at this in depth :)
>>>>> On 1 Aug 2024, at 16:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>> 
>>>>> Hi Michael,
>>>>> 
>>>>> Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
>>>> That is good news!
>>> 
>>> In some later emails, I indicated that I found that the browser cache was the reason that the colours came back. When I cleared my browser cache I went back to no colours and longer overlapping entry boxes.
>>>>> The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
>>>> I think I have an explanation for this, and no, you are not going crazy. Since I have changed the CSS, it might be that the web UI is now rendering some different HTML, but your browser has the old CSS cached and so those things don’t fit together any more.
>>>> This is a good example: https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=fbfde0088c58c506cab80d23fc240e3cab863302
>>>> If you don’t have the changes from the CSS file, then you simply won’t see any colours here.
>>> 
>>> Yes, I found that the browser cache was affecting things.
>>> However, when I clear the cache the result I get is the loss of the colours in the services table page as an example or the overlapping of entry boxes in the dhcp page as an example. I can get this effect consistently with doing a fresh install and a browser cache clear. Have tested this out three times and always the same result. Longer boxes overlapping other elements and loss of status colours. See attached dhcp and services screenshots.
>>>> Some of the changes I implemented a user feedback - for example that the headlines are hard to read on some devices that have not the best font rendering. Other things are probably more of my own things. The graphs used to have a grey line around them. And then we had a box with another grey line around them. And then there was the big white box. It kind of reminded me of some mirror cabinet.
>>>> Sometimes we have multiple levels of headlines that all say the same: Memory information -> Memory Graph -> Memory Usage per Day.
>>>>> Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
>>>> So it is correct that the outer box is gone. The graph only has a headline when it needs one.
>>>> The Hour/Day/Week/… controls should however remain the same.
>>> That is definitely different. They are now boxes containing the words at the bottom of the graph rather than just the words at the top of the graph and when first viewed all are grey (graph-example1) then become red when selected (graph-example2).
>>>>> Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
>>>> This is probably a bug from my changes in the tooling.
>>> I have seen the patch. Looks like that will fix it. Will test it to confirm, either with build and install or using nightly build once done.
>>> 
>>>>> I don't know what is going on here.
>>>> Me pushing a lot of changes at a fast pace :)
>>> :-)
>>>>> ----------------------------------------------
>>>>> 
>>>>> Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
>>>>> 
>>>>> The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
>>>> This is now applied automatically to every table. Before, we used to have a lot of Perl magic to make that happen.
>>> That looks good.
>>>>> All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
>>>> Okay, this would be something that needs fixing then.
>>>>> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>>>>> 
>>>>> The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
>>>>> 
>>>>> The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
>>>>> 
>>>>> On the Services page the first graph which should be titled Processes is labelled 100%.
>>>>> 
>>>>> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>>>>> 
>>>>> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>>>> 
>>>>> The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
>>>>> 
>>>>> On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
>>>>> 
>>>>> On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
>>>>> 
>>>>> The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay.
>>>> Okay, this is all very useful. I will install a machine and go through all of this and see what I can fix.
>>>>> The following menu items showed longer entry boxes that overlap labels or other elements
>>>>> DHCP
>>>>> DNS Forward
>>>>> Static Routes
>>>>> Wake on LAN
>>>>> Time Server
>>>>> Log Settings
>>>>> Proxy Logs
>>>>> 
>>>>> 
>>>>> The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example
>>>>> Firewall Groups
>>>>> Firewall Options
>>>>> Blue Access
>>>>> Log Summary
>>>>> Dynamic DNS
>>>>> Proxy reports
>>>>> Firewall logs
>>>>> Firewall graphs - IP, Port & Country
>>>>> IPS Logs
>>>>> IP Address blocklist logs
>>>>> OpenVPN RW logs
>>>>> URL Filter Logs
>>>>> System Logs
>>>>> Captive portal
>>>>> Connection Scheduler
>>>>> Assign MAC Address
>>>>> 
>>>>> 
>>>>> The following menu items showed no change/issues except maybe for the graph period selection buttons .
>>>>> Backup
>>>>> Shutdown
>>>>> Credits
>>>>> Mailservice
>>>>> Memory
>>>>> Media
>>>>> Network External, Internal and Other
>>>>> OpenVPN RW and N2N Statistics
>>>>> WIO
>>>>> Hardware graphs
>>>>> Connections
>>>>> Mdstat
>>>>> DNS
>>>>> Web Proxy
>>>>> URL Filter
>>>>> Update Accelerator
>>>>> Edit Hosts
>>>>> QOS
>>>>> IP Address Blocklist
>>>>> Location Block
>>>>> IPTables
>>>>> 
>>>>> I am really sorry for giving false hope that the cleanup branch had gone really well.
>>>> Well, it happens :) That is why next is called next.
>>> Yes but me providing the original first review feedback on a vm system that did not have the cleanup changes actually in it, really shouldn't have happened.
>>> 
>>> Regards,
>>> Adolf.
>>>> -Michael
>>>>> 
>>>>> Regards,
>>>>> 
>>>>> Adolf.
>>>>> 
>>>>> On 01/08/2024 12:50, Adolf Belka wrote:
>>>>>> Hi Michael,
>>>>>> 
>>>>>> On 25/07/2024 12:28, Adolf Belka wrote:
>>>>>>> Hi Michael,
>>>>>>> 
>>>>>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>>>>>> Hello Adolf,
>>>>>>>> 
>>>>>>>> Thank you for getting back on this so quickly.
>>>>>>>> 
>>>>>> Maybe I got back too quickly!!
>>>>>> 
>>>>>> I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
>>>>>> 
>>>>>> I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
>>>>>> 
>>>>>> Downloading the iso today from the latest directory gives me the build ed2c97b7.
>>>>>> 
>>>>>> I am going to install that version now but I suspect it will show the same as I found with my build.
>>>>>> 
>>>>>> So it looks like my original review was based on the version before the cleanup branch changes were included.
>>>>>> 
>>>>>> I will come back with new feedback of what I find from the latest branch that I have now downloaded.
>>>>>> 
>>>>>> Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
>>>>>> 
>>>>>> Regards,
>>>>>> 
>>>>>> Adolf
>>>>>> 
>>>>>>>> I suppose this also means that the ISO in the next branch boots just fine, too?
>>>>>>> 
>>>>>>> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
>>>>>>> This tested out raid and all 4 interfaces.
>>>>>>> 
>>>>>>> Regards,
>>>>>>> Adolf.
>>>>>>> 
>>>>>>>> 
>>>>>>>> Best,
>>>>>>>> -Michael
>>>>>>>> 
>>>>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>>>> 
>>>>>>>>> Hi Michael,
>>>>>>>>> 
>>>>>>>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>>>>>>> 
>>>>>>>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>>>>>>> 
>>>>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>>>>>>> 
>>>>>>>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>>>>>>> 
>>>>>>>>> Of course good for others to also evaluate.
>>>>>>>>> 
>>>>>>>>> Regards,
>>>>>>>>> 
>>>>>>>>> Adolf.
>>>>>>>>> 
>>>>> <Screenshot_2024-08-01_16-45-00.png><Screenshot_2024-08-01_16-47-11.png>
>>> <dhcp.png><services.png><graph-example1.png><graph-example2.png>
> <Services_page_2024-08-07_12-44-08.png><IPS_page_2024-08-07_12-49-33.png>

Re: Test of cleanup branch

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 11854 bytes --]

Hello,

I just pushed a bunch of changes that should hopefully resolve a few of the problems.

The only one that I can see remaining is that all sorts of form elements (dropdowns, input boxes, etc.) are now 100% in width. They fill the entire horizontal space. This is something I like. However, without the scaffolding around being consistent, this creates a lot of problems. Sometimes we have a table that is properly sized, sometimes we have I don’t even know what. I believe cleaning that up will be weeks worth of work because it is so fiddly. So, maybe I will revert that change and come up with a different solution for OpenVPN.

Please give the recent changes a test and let me know how it works.

-Michael

> On 3 Aug 2024, at 11:48, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> On 02/08/2024 11:12, Michael Tremer wrote:
>> Hello Adolf,
>> Thank you for looking at this in depth :)
>>> On 1 Aug 2024, at 16:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>> 
>>> Hi Michael,
>>> 
>>> Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
>> That is good news!
> 
> In some later emails, I indicated that I found that the browser cache was the reason that the colours came back. When I cleared my browser cache I went back to no colours and longer overlapping entry boxes.
>>> The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
>> I think I have an explanation for this, and no, you are not going crazy. Since I have changed the CSS, it might be that the web UI is now rendering some different HTML, but your browser has the old CSS cached and so those things don’t fit together any more.
>> This is a good example: https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=fbfde0088c58c506cab80d23fc240e3cab863302
>> If you don’t have the changes from the CSS file, then you simply won’t see any colours here.
> 
> Yes, I found that the browser cache was affecting things.
> However, when I clear the cache the result I get is the loss of the colours in the services table page as an example or the overlapping of entry boxes in the dhcp page as an example. I can get this effect consistently with doing a fresh install and a browser cache clear. Have tested this out three times and always the same result. Longer boxes overlapping other elements and loss of status colours. See attached dhcp and services screenshots.
>> Some of the changes I implemented a user feedback - for example that the headlines are hard to read on some devices that have not the best font rendering. Other things are probably more of my own things. The graphs used to have a grey line around them. And then we had a box with another grey line around them. And then there was the big white box. It kind of reminded me of some mirror cabinet.
>> Sometimes we have multiple levels of headlines that all say the same: Memory information -> Memory Graph -> Memory Usage per Day.
>>> Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
>> So it is correct that the outer box is gone. The graph only has a headline when it needs one.
>> The Hour/Day/Week/… controls should however remain the same.
> That is definitely different. They are now boxes containing the words at the bottom of the graph rather than just the words at the top of the graph and when first viewed all are grey (graph-example1) then become red when selected (graph-example2).
>>> Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
>> This is probably a bug from my changes in the tooling.
> I have seen the patch. Looks like that will fix it. Will test it to confirm, either with build and install or using nightly build once done.
> 
>>> I don't know what is going on here.
>> Me pushing a lot of changes at a fast pace :)
> :-)
>>> ----------------------------------------------
>>> 
>>> Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
>>> 
>>> The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
>> This is now applied automatically to every table. Before, we used to have a lot of Perl magic to make that happen.
> That looks good.
>>> All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
>> Okay, this would be something that needs fixing then.
>>> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>>> 
>>> The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
>>> 
>>> The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
>>> 
>>> On the Services page the first graph which should be titled Processes is labelled 100%.
>>> 
>>> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>>> 
>>> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>> 
>>> The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
>>> 
>>> On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
>>> 
>>> On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
>>> 
>>> The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay.
>> Okay, this is all very useful. I will install a machine and go through all of this and see what I can fix.
>>> The following menu items showed longer entry boxes that overlap labels or other elements
>>> DHCP
>>> DNS Forward
>>> Static Routes
>>> Wake on LAN
>>> Time Server
>>> Log Settings
>>> Proxy Logs
>>> 
>>> 
>>> The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example
>>> Firewall Groups
>>> Firewall Options
>>> Blue Access
>>> Log Summary
>>> Dynamic DNS
>>> Proxy reports
>>> Firewall logs
>>> Firewall graphs - IP, Port & Country
>>> IPS Logs
>>> IP Address blocklist logs
>>> OpenVPN RW logs
>>> URL Filter Logs
>>> System Logs
>>> Captive portal
>>> Connection Scheduler
>>> Assign MAC Address
>>> 
>>> 
>>> The following menu items showed no change/issues except maybe for the graph period selection buttons .
>>> Backup
>>> Shutdown
>>> Credits
>>> Mailservice
>>> Memory
>>> Media
>>> Network External, Internal and Other
>>> OpenVPN RW and N2N Statistics
>>> WIO
>>> Hardware graphs
>>> Connections
>>> Mdstat
>>> DNS
>>> Web Proxy
>>> URL Filter
>>> Update Accelerator
>>> Edit Hosts
>>> QOS
>>> IP Address Blocklist
>>> Location Block
>>> IPTables
>>> 
>>> I am really sorry for giving false hope that the cleanup branch had gone really well.
>> Well, it happens :) That is why next is called next.
> Yes but me providing the original first review feedback on a vm system that did not have the cleanup changes actually in it, really shouldn't have happened.
> 
> Regards,
> Adolf.
>> -Michael
>>> 
>>> Regards,
>>> 
>>> Adolf.
>>> 
>>> On 01/08/2024 12:50, Adolf Belka wrote:
>>>> Hi Michael,
>>>> 
>>>> On 25/07/2024 12:28, Adolf Belka wrote:
>>>>> Hi Michael,
>>>>> 
>>>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>>>> Hello Adolf,
>>>>>> 
>>>>>> Thank you for getting back on this so quickly.
>>>>>> 
>>>> Maybe I got back too quickly!!
>>>> 
>>>> I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
>>>> 
>>>> I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
>>>> 
>>>> Downloading the iso today from the latest directory gives me the build ed2c97b7.
>>>> 
>>>> I am going to install that version now but I suspect it will show the same as I found with my build.
>>>> 
>>>> So it looks like my original review was based on the version before the cleanup branch changes were included.
>>>> 
>>>> I will come back with new feedback of what I find from the latest branch that I have now downloaded.
>>>> 
>>>> Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
>>>> 
>>>> Regards,
>>>> 
>>>> Adolf
>>>> 
>>>>>> I suppose this also means that the ISO in the next branch boots just fine, too?
>>>>> 
>>>>> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
>>>>> This tested out raid and all 4 interfaces.
>>>>> 
>>>>> Regards,
>>>>> Adolf.
>>>>> 
>>>>>> 
>>>>>> Best,
>>>>>> -Michael
>>>>>> 
>>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>> 
>>>>>>> Hi Michael,
>>>>>>> 
>>>>>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>>>>> 
>>>>>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>>>>> 
>>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>>>>> 
>>>>>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>>>>> 
>>>>>>> Of course good for others to also evaluate.
>>>>>>> 
>>>>>>> Regards,
>>>>>>> 
>>>>>>> Adolf.
>>>>>>> 
>>> <Screenshot_2024-08-01_16-45-00.png><Screenshot_2024-08-01_16-47-11.png>
> <dhcp.png><services.png><graph-example1.png><graph-example2.png>

Re: Test of cleanup branch

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 7752 bytes --]

The package numbers should be back now. I simply used a wrong variable name:

  https://git.ipfire.org/?p=ipfire-2.x.git;a=commitdiff;h=df84336ef8f7c20f7337a0d078f198a135815db1

-Michael

> On 1 Aug 2024, at 16:01, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
> 
> The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
> 
> Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
> 
> Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
> 
> I don't know what is going on here.
> 
> ----------------------------------------------
> 
> Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
> 
> The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
> 
> All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
> 
> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
> 
> The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
> 
> The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
> 
> On the Services page the first graph which should be titled Processes is labelled 100%.
> 
> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
> 
> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
> 
> The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
> 
> On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
> 
> On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
> 
> The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay.
> 
> The following menu items showed longer entry boxes that overlap labels or other elements
> DHCP
> DNS Forward
> Static Routes
> Wake on LAN
> Time Server
> Log Settings
> Proxy Logs
> 
> 
> The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example
> Firewall Groups
> Firewall Options
> Blue Access
> Log Summary
> Dynamic DNS
> Proxy reports
> Firewall logs
> Firewall graphs - IP, Port & Country
> IPS Logs
> IP Address blocklist logs
> OpenVPN RW logs
> URL Filter Logs
> System Logs
> Captive portal
> Connection Scheduler
> Assign MAC Address
> 
> 
> The following menu items showed no change/issues except maybe for the graph period selection buttons .
> Backup
> Shutdown
> Credits
> Mailservice
> Memory
> Media
> Network External, Internal and Other
> OpenVPN RW and N2N Statistics
> WIO
> Hardware graphs
> Connections
> Mdstat
> DNS
> Web Proxy
> URL Filter
> Update Accelerator
> Edit Hosts
> QOS
> IP Address Blocklist
> Location Block
> IPTables
> 
> I am really sorry for giving false hope that the cleanup branch had gone really well.
> 
> Regards,
> 
> Adolf.
> 
> On 01/08/2024 12:50, Adolf Belka wrote:
>> Hi Michael,
>> 
>> On 25/07/2024 12:28, Adolf Belka wrote:
>>> Hi Michael,
>>> 
>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>> Hello Adolf,
>>>> 
>>>> Thank you for getting back on this so quickly.
>>>> 
>> Maybe I got back too quickly!!
>> 
>> I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
>> 
>> I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
>> 
>> Downloading the iso today from the latest directory gives me the build ed2c97b7.
>> 
>> I am going to install that version now but I suspect it will show the same as I found with my build.
>> 
>> So it looks like my original review was based on the version before the cleanup branch changes were included.
>> 
>> I will come back with new feedback of what I find from the latest branch that I have now downloaded.
>> 
>> Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
>> 
>> Regards,
>> 
>> Adolf
>> 
>>>> I suppose this also means that the ISO in the next branch boots just fine, too?
>>> 
>>> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
>>> This tested out raid and all 4 interfaces.
>>> 
>>> Regards,
>>> Adolf.
>>> 
>>>> 
>>>> Best,
>>>> -Michael
>>>> 
>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>> 
>>>>> Hi Michael,
>>>>> 
>>>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>>> 
>>>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>>> 
>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>>> 
>>>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>>> 
>>>>> Of course good for others to also evaluate.
>>>>> 
>>>>> Regards,
>>>>> 
>>>>> Adolf.
>>>>> 
> <Screenshot_2024-08-01_16-45-00.png><Screenshot_2024-08-01_16-47-11.png>

Re: Test of cleanup branch

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 10115 bytes --]

Hi Michael,

So the strikethrough of the existing text did not get applied in my previous reply so the following is the feedback that applies now.

All graphs have new selection buttons for Hour, Day, Weekly etc that are in a vertical position below the graph. Pressing any of the buttons changes the graph period being shown but the button does not change colour or anything to indicate it has been pressed. You have to look at the graph axis to figure out which time period has been selected.

Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.

On the Services page the first graph which should be titled Processes is labelled 100%.

On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.

On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20

The vulnerabilities page has the left hand section now in black background with white lettering and the right hand section of the table now has no colour coding. Everything is black lettering on a white background.

The following menu items showed no change/issues except maybe for the graph period selection buttons .
Backup
Shutdown
Credits
Mailservice
Memory
Media
Network External, Internal and Other
OpenVPN RW and N2N Statistics
WIO
Hardware graphs
Connections
Mdstat
DNS
Web Proxy
URL Filter
Update Accelerator
Edit Hosts
QOS
IP Address Blocklist
Location Block
IPTables
Firewall Groups
Firewall Options
Blue Access
Log Summary
Dynamic DNS
Proxy reports
Firewall logs
Firewall graphs - IP, Port & Country
IPS Logs
IP Address blocklist logs
OpenVPN RW logs
URL Filter Logs
System Logs
Captive portal
Connection Scheduler
Assign MAC Address
DHCP
DNS Forward
Static Routes
Wake on LAN
Time Server
Log Settings
Proxy Logs

Regards,

Adolf


On 01/08/2024 17:24, Adolf Belka wrote:
> Hi Michael,
>
> So I repeated a CU188 IPFire shutdown, start CU186 IPFire vm, shutdown it down and restart the CU188 vm a few times. Nothing changed further so I am editing my feedback below by striking through all my comments that no longer apply. I have no idea what happened to cause what I experienced.
>
> Regards,
>
> Adolf
>
>
> On 01/08/2024 17:01, Adolf Belka wrote:
>> Hi Michael,
>>
>> Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
>>
>> The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
>>
>> Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
>>
>> Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
>>
>> I don't know what is going on here.
>>
>> ----------------------------------------------
>>
>> Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
>>
>> The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
>>
>> All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
>>
>> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>>
>> The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
>>
>> The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
>>
>> On the Services page the first graph which should be titled Processes is labelled 100%.
>>
>> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>>
>> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>
>> The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
>>
>> On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
>>
>> On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
>>
>> The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay. After the reboot the Right Hand Side of the table now has no colour coding. Everything is black lettering on a white background. Screenshot of how this is now is attached.
>>
>> The following menu items showed longer entry boxes that overlap labels or other elements
>> DHCP
>> DNS Forward
>> Static Routes
>> Wake on LAN
>> Time Server
>> Log Settings
>> Proxy Logs
>>
>>
>> The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example
>> Firewall Groups
>> Firewall Options
>> Blue Access
>> Log Summary
>> Dynamic DNS
>> Proxy reports
>> Firewall logs
>> Firewall graphs - IP, Port & Country
>> IPS Logs
>> IP Address blocklist logs
>> OpenVPN RW logs
>> URL Filter Logs
>> System Logs
>> Captive portal
>> Connection Scheduler
>> Assign MAC Address
>>
>>
>> The following menu items showed no change/issues except maybe for the graph period selection buttons .
>> Backup
>> Shutdown
>> Credits
>> Mailservice
>> Memory
>> Media
>> Network External, Internal and Other
>> OpenVPN RW and N2N Statistics
>> WIO
>> Hardware graphs
>> Connections
>> Mdstat
>> DNS
>> Web Proxy
>> URL Filter
>> Update Accelerator
>> Edit Hosts
>> QOS
>> IP Address Blocklist
>> Location Block
>> IPTables
>>
>> I am really sorry for giving false hope that the cleanup branch had gone really well.
>>
>> Regards,
>>
>> Adolf.
>>
>> On 01/08/2024 12:50, Adolf Belka wrote:
>>> Hi Michael,
>>>
>>> On 25/07/2024 12:28, Adolf Belka wrote:
>>>> Hi Michael,
>>>>
>>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>>> Hello Adolf,
>>>>>
>>>>> Thank you for getting back on this so quickly.
>>>>>
>>> Maybe I got back too quickly!!
>>>
>>> I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
>>>
>>> I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
>>>
>>> Downloading the iso today from the latest directory gives me the build ed2c97b7.
>>>
>>> I am going to install that version now but I suspect it will show the same as I found with my build.
>>>
>>> So it looks like my original review was based on the version before the cleanup branch changes were included.
>>>
>>> I will come back with new feedback of what I find from the latest branch that I have now downloaded.
>>>
>>> Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
>>>
>>> Regards,
>>>
>>> Adolf
>>>
>>>>> I suppose this also means that the ISO in the next branch boots just fine, too?
>>>>
>>>> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
>>>> This tested out raid and all 4 interfaces.
>>>>
>>>> Regards,
>>>> Adolf.
>>>>
>>>>>
>>>>> Best,
>>>>> -Michael
>>>>>
>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>
>>>>>> Hi Michael,
>>>>>>
>>>>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>>>>
>>>>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>>>>
>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>>>>
>>>>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>>>>
>>>>>> Of course good for others to also evaluate.
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Adolf.
>>>>>>
>>>>>

Re: Test of cleanup branch

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 12248 bytes --]

Hi Michael,

More weird news.

I created a fresh install of CU188 build ed2c97b7-dirty into a new vm.

After installing it had the same issues as I had originally reported. I have taken lots of screenshots of all the issues I previously just wrote about.

I then shutdown that CU188 IPFire and started back up the CU186 IPFire vm. That version then showed some of the issues I had seen in CU188. I cleared the cache in my Firefox browser and CU186 went back to its normal look.

I then stopped the CU186 and restarted CU188. It came up with all the issues I originally reported. No matter what I tried I have not been able to get back to the version I had where the colour coding came back and the long entry boxes were normal again. I tried clearing the browser cache several times but nothing changed.

I am wondering if when I went to the CU188 version where the colour coding came back and the longer entry boxes disappeared that I was getting some cache effects from when I had the CU186 version running.

Anyway, either way I have been able to reproduce all my original reported issues by re-installing the CU188 iso and this time despite several reboots and clearing browser caches the results has stayed the same.

I have lots of screenshots of all the issues in case it does go away again.

Maybe I will try doing a third fresh install of CU188 build ed2c97b7-dirty  and see if I get the same thing a third time. If yes, then my original issues feedback today is the correct status and the intermediate result where some of the issues went away must be the anomaly, caused by some unknown sequence of steps that I have not been able to reproduce yet.

I will place the screenshots I have in my IPFire People home directory (public section).

Regards,

Adolf.


On 01/08/2024 17:45, Adolf Belka wrote:
> Hi Michael,
>
> So the strikethrough of the existing text did not get applied in my previous reply so the following is the feedback that applies now.
>
> All graphs have new selection buttons for Hour, Day, Weekly etc that are in a vertical position below the graph. Pressing any of the buttons changes the graph period being shown but the button does not change colour or anything to indicate it has been pressed. You have to look at the graph axis to figure out which time period has been selected.
>
> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>
> On the Services page the first graph which should be titled Processes is labelled 100%.
>
> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>
> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>
> The vulnerabilities page has the left hand section now in black background with white lettering and the right hand section of the table now has no colour coding. Everything is black lettering on a white background.
>
> The following menu items showed no change/issues except maybe for the graph period selection buttons .
> Backup
> Shutdown
> Credits
> Mailservice
> Memory
> Media
> Network External, Internal and Other
> OpenVPN RW and N2N Statistics
> WIO
> Hardware graphs
> Connections
> Mdstat
> DNS
> Web Proxy
> URL Filter
> Update Accelerator
> Edit Hosts
> QOS
> IP Address Blocklist
> Location Block
> IPTables
> Firewall Groups
> Firewall Options
> Blue Access
> Log Summary
> Dynamic DNS
> Proxy reports
> Firewall logs
> Firewall graphs - IP, Port & Country
> IPS Logs
> IP Address blocklist logs
> OpenVPN RW logs
> URL Filter Logs
> System Logs
> Captive portal
> Connection Scheduler
> Assign MAC Address
> DHCP
> DNS Forward
> Static Routes
> Wake on LAN
> Time Server
> Log Settings
> Proxy Logs
>
> Regards,
>
> Adolf
>
>
> On 01/08/2024 17:24, Adolf Belka wrote:
>> Hi Michael,
>>
>> So I repeated a CU188 IPFire shutdown, start CU186 IPFire vm, shutdown it down and restart the CU188 vm a few times. Nothing changed further so I am editing my feedback below by striking through all my comments that no longer apply. I have no idea what happened to cause what I experienced.
>>
>> Regards,
>>
>> Adolf
>>
>>
>> On 01/08/2024 17:01, Adolf Belka wrote:
>>> Hi Michael,
>>>
>>> Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
>>>
>>> The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
>>>
>>> Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
>>>
>>> Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
>>>
>>> I don't know what is going on here.
>>>
>>> ----------------------------------------------
>>>
>>> Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
>>>
>>> The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
>>>
>>> All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
>>>
>>> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>>>
>>> The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
>>>
>>> The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
>>>
>>> On the Services page the first graph which should be titled Processes is labelled 100%.
>>>
>>> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>>>
>>> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>>
>>> The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
>>>
>>> On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
>>>
>>> On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
>>>
>>> The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay. After the reboot the Right Hand Side of the table now has no colour coding. Everything is black lettering on a white background. Screenshot of how this is now is attached.
>>>
>>> The following menu items showed longer entry boxes that overlap labels or other elements
>>> DHCP
>>> DNS Forward
>>> Static Routes
>>> Wake on LAN
>>> Time Server
>>> Log Settings
>>> Proxy Logs
>>>
>>>
>>> The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example
>>> Firewall Groups
>>> Firewall Options
>>> Blue Access
>>> Log Summary
>>> Dynamic DNS
>>> Proxy reports
>>> Firewall logs
>>> Firewall graphs - IP, Port & Country
>>> IPS Logs
>>> IP Address blocklist logs
>>> OpenVPN RW logs
>>> URL Filter Logs
>>> System Logs
>>> Captive portal
>>> Connection Scheduler
>>> Assign MAC Address
>>>
>>>
>>> The following menu items showed no change/issues except maybe for the graph period selection buttons .
>>> Backup
>>> Shutdown
>>> Credits
>>> Mailservice
>>> Memory
>>> Media
>>> Network External, Internal and Other
>>> OpenVPN RW and N2N Statistics
>>> WIO
>>> Hardware graphs
>>> Connections
>>> Mdstat
>>> DNS
>>> Web Proxy
>>> URL Filter
>>> Update Accelerator
>>> Edit Hosts
>>> QOS
>>> IP Address Blocklist
>>> Location Block
>>> IPTables
>>>
>>> I am really sorry for giving false hope that the cleanup branch had gone really well.
>>>
>>> Regards,
>>>
>>> Adolf.
>>>
>>> On 01/08/2024 12:50, Adolf Belka wrote:
>>>> Hi Michael,
>>>>
>>>> On 25/07/2024 12:28, Adolf Belka wrote:
>>>>> Hi Michael,
>>>>>
>>>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>>>> Hello Adolf,
>>>>>>
>>>>>> Thank you for getting back on this so quickly.
>>>>>>
>>>> Maybe I got back too quickly!!
>>>>
>>>> I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
>>>>
>>>> I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
>>>>
>>>> Downloading the iso today from the latest directory gives me the build ed2c97b7.
>>>>
>>>> I am going to install that version now but I suspect it will show the same as I found with my build.
>>>>
>>>> So it looks like my original review was based on the version before the cleanup branch changes were included.
>>>>
>>>> I will come back with new feedback of what I find from the latest branch that I have now downloaded.
>>>>
>>>> Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
>>>>
>>>> Regards,
>>>>
>>>> Adolf
>>>>
>>>>>> I suppose this also means that the ISO in the next branch boots just fine, too?
>>>>>
>>>>> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
>>>>> This tested out raid and all 4 interfaces.
>>>>>
>>>>> Regards,
>>>>> Adolf.
>>>>>
>>>>>>
>>>>>> Best,
>>>>>> -Michael
>>>>>>
>>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>>
>>>>>>> Hi Michael,
>>>>>>>
>>>>>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>>>>>
>>>>>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>>>>>
>>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>>>>>
>>>>>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>>>>>
>>>>>>> Of course good for others to also evaluate.
>>>>>>>
>>>>>>> Regards,
>>>>>>>
>>>>>>> Adolf.
>>>>>>>
>>>>>>

Re: Test of cleanup branch

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 13530 bytes --]

Hi Michael,

I did some more testing.

On 01/08/2024 19:09, Adolf Belka wrote:
> Hi Michael,
>
> More weird news.
>
> I created a fresh install of CU188 build ed2c97b7-dirty into a new vm.
>
> After installing it had the same issues as I had originally reported. I have taken lots of screenshots of all the issues I previously just wrote about.
>
> I then shutdown that CU188 IPFire and started back up the CU186 IPFire vm. That version then showed some of the issues I had seen in CU188. I cleared the cache in my Firefox browser and CU186 went back to its normal look.
>
> I then stopped the CU186 and restarted CU188. It came up with all the issues I originally reported. No matter what I tried I have not been able to get back to the version I had where the colour coding came back and the long entry boxes were normal again. I tried clearing the browser cache several times but nothing changed.
>
> I am wondering if when I went to the CU188 version where the colour coding came back and the longer entry boxes disappeared that I was getting some cache effects from when I had the CU186 version running.
>
> Anyway, either way I have been able to reproduce all my original reported issues by re-installing the CU188 iso and this time despite several reboots and clearing browser caches the results has stayed the same.
>
> I have lots of screenshots of all the issues in case it does go away again.
>
> Maybe I will try doing a third fresh install of CU188 build ed2c97b7-dirty  and see if I get the same thing a third time. If yes, then my original issues feedback today is the correct status and the intermediate result where some of the issues went away must be the anomaly, caused by some unknown sequence of steps that I have not been able to reproduce yet.
>
After running some other evaluation work with my CU186 vm system I then did a fresh install of the CU188 iso. The mixture of colour coding of status on services, IPSec & OpenVPN was present and the graph time period buttons were in a vertical format at the bottom of the graph. I then cleared the browser cache and the status colour coding disappeared and the time period buttons became a horizontal row. This was then in line with the final versions for the last two installs of CU188 that I did.

It seems clear to me that the changes in the cleanup branch can be affected by what is in the browser cache resulting in a mixture of the formats used from the cache and from the new coding. This could make the update a bit awkward as it would depend on the browser cache being cleared, at least of all IPFIre WUI pages.

> I will place the screenshots I have in my IPFire People home directory (public section).
>
All screenshots placed in my public directory in my home directory.

Regards,

Adolf.

> Regards,
>
> Adolf.
>
>
> On 01/08/2024 17:45, Adolf Belka wrote:
>> Hi Michael,
>>
>> So the strikethrough of the existing text did not get applied in my previous reply so the following is the feedback that applies now.
>>
>> All graphs have new selection buttons for Hour, Day, Weekly etc that are in a vertical position below the graph. Pressing any of the buttons changes the graph period being shown but the button does not change colour or anything to indicate it has been pressed. You have to look at the graph axis to figure out which time period has been selected.
>>
>> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>>
>> On the Services page the first graph which should be titled Processes is labelled 100%.
>>
>> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>>
>> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>
>> The vulnerabilities page has the left hand section now in black background with white lettering and the right hand section of the table now has no colour coding. Everything is black lettering on a white background.
>>
>> The following menu items showed no change/issues except maybe for the graph period selection buttons .
>> Backup
>> Shutdown
>> Credits
>> Mailservice
>> Memory
>> Media
>> Network External, Internal and Other
>> OpenVPN RW and N2N Statistics
>> WIO
>> Hardware graphs
>> Connections
>> Mdstat
>> DNS
>> Web Proxy
>> URL Filter
>> Update Accelerator
>> Edit Hosts
>> QOS
>> IP Address Blocklist
>> Location Block
>> IPTables
>> Firewall Groups
>> Firewall Options
>> Blue Access
>> Log Summary
>> Dynamic DNS
>> Proxy reports
>> Firewall logs
>> Firewall graphs - IP, Port & Country
>> IPS Logs
>> IP Address blocklist logs
>> OpenVPN RW logs
>> URL Filter Logs
>> System Logs
>> Captive portal
>> Connection Scheduler
>> Assign MAC Address
>> DHCP
>> DNS Forward
>> Static Routes
>> Wake on LAN
>> Time Server
>> Log Settings
>> Proxy Logs
>>
>> Regards,
>>
>> Adolf
>>
>>
>> On 01/08/2024 17:24, Adolf Belka wrote:
>>> Hi Michael,
>>>
>>> So I repeated a CU188 IPFire shutdown, start CU186 IPFire vm, shutdown it down and restart the CU188 vm a few times. Nothing changed further so I am editing my feedback below by striking through all my comments that no longer apply. I have no idea what happened to cause what I experienced.
>>>
>>> Regards,
>>>
>>> Adolf
>>>
>>>
>>> On 01/08/2024 17:01, Adolf Belka wrote:
>>>> Hi Michael,
>>>>
>>>> Additional note written after all of the feedback below the dashed line was written. I did a shutdown of the vm with CU188 to check something in the CU186 vm then went back to the CU188 version and things had changed. Most of the longer boxes are no longer longer and don't overlap other elements. The missing colours are back for IPSec, OpenVPN etc.
>>>>
>>>> The graph period selection previously was in a horizontal line under the graph. Now it was still under the graph but it is now a vertical selection choice which can't have been intended as it takes far too much space. However the key thing is that rebooting seems to be making things change, which shouldn't be happening. I have started to take screenshots of things to have some evidence.
>>>>
>>>> Attached is a screenshot showing the graph period selectors which are now vertically positioned at the bottom of the graphs.
>>>>
>>>> Also attached is a screenshot of the pakfire page that is still missing the pak_ver numbers.
>>>>
>>>> I don't know what is going on here.
>>>>
>>>> ----------------------------------------------
>>>>
>>>> Okay, here is the feedback from reviewing a vm that actually included the cleanup branch changes.
>>>>
>>>> The home and ssh items look better with the change. They now use alternating shades of grey to highlight each line.
>>>>
>>>> All graphs have new selection buttons for Hour, Day, Weekly etc that show in red when selected. This looks better. The default is the Day selection but when you start with a graph it does not indicate that it is using the Day option, ie all buttons are showing grey.
>>>>
>>>> Net-Traffic and ExtraHD have the same tables but instead of being centred on the page they are now on the Left Hand Side of the WUI page.
>>>>
>>>> The Zone Config page looks much busier now. Previously the dropdown box for native or vlan selection was next to the vlan id box and the space was good enough for that. Now they are placed one above the other, so wider, which is not needed but they now fill the whole space of the section before the next nic interface starts. I think the previous version looked clearer.
>>>>
>>>> The IPS page and the Services page no longer show the red or green background for running or stopped. You still see the words but they are now in white on a light grey background or white on a slightly darker grey.
>>>>
>>>> On the Services page the first graph which should be titled Processes is labelled 100%.
>>>>
>>>> On the System page the graphs have no name at all. On the vm I used they should have been labelled CPU and Load Avg.
>>>>
>>>> On the Pakfire page the list of available or installed addons do not show the pak_ver number so that you get alsa-1.2.10- instead of alsa-1.2.10-20
>>>>
>>>> The IPSec and OpenVPN pages no longer show the green, red or blue colours for the connection status.
>>>>
>>>> On the Firewall Rules page the table has no colours for Accept, Reject or Drop for any of the rules. The alternate grey shading has got mixed up as it is considering that if there is a remark line for a firewall rule that is a separate line and the grey shading has to be changed. Definitely not right. Some of the Destinations have not had the right colour code applied for the zone colour - left grey. The boxes giving the policy applied for each firewall section are not colour coded for Allow or Blocked.
>>>>
>>>> On the actual firewall creation page, there are longer boxes that overlap labels or other elements. There is no colour in the Drop, Reject, Accept selection box just one shade of grey.
>>>>
>>>> The vulnerabilities page has the left hand section now in black background with white lettering. Different but probably okay. After the reboot the Right Hand Side of the table now has no colour coding. Everything is black lettering on a white background. Screenshot of how this is now is attached.
>>>>
>>>> The following menu items showed longer entry boxes that overlap labels or other elements
>>>> DHCP
>>>> DNS Forward
>>>> Static Routes
>>>> Wake on LAN
>>>> Time Server
>>>> Log Settings
>>>> Proxy Logs
>>>>
>>>>
>>>> The following menu items showed longer entry boxes that did not overlap other elements but you end up with a much longer box length than is needed for a day number for example
>>>> Firewall Groups
>>>> Firewall Options
>>>> Blue Access
>>>> Log Summary
>>>> Dynamic DNS
>>>> Proxy reports
>>>> Firewall logs
>>>> Firewall graphs - IP, Port & Country
>>>> IPS Logs
>>>> IP Address blocklist logs
>>>> OpenVPN RW logs
>>>> URL Filter Logs
>>>> System Logs
>>>> Captive portal
>>>> Connection Scheduler
>>>> Assign MAC Address
>>>>
>>>>
>>>> The following menu items showed no change/issues except maybe for the graph period selection buttons .
>>>> Backup
>>>> Shutdown
>>>> Credits
>>>> Mailservice
>>>> Memory
>>>> Media
>>>> Network External, Internal and Other
>>>> OpenVPN RW and N2N Statistics
>>>> WIO
>>>> Hardware graphs
>>>> Connections
>>>> Mdstat
>>>> DNS
>>>> Web Proxy
>>>> URL Filter
>>>> Update Accelerator
>>>> Edit Hosts
>>>> QOS
>>>> IP Address Blocklist
>>>> Location Block
>>>> IPTables
>>>>
>>>> I am really sorry for giving false hope that the cleanup branch had gone really well.
>>>>
>>>> Regards,
>>>>
>>>> Adolf.
>>>>
>>>> On 01/08/2024 12:50, Adolf Belka wrote:
>>>>> Hi Michael,
>>>>>
>>>>> On 25/07/2024 12:28, Adolf Belka wrote:
>>>>>> Hi Michael,
>>>>>>
>>>>>> On 25/07/2024 10:44, Michael Tremer wrote:
>>>>>>> Hello Adolf,
>>>>>>>
>>>>>>> Thank you for getting back on this so quickly.
>>>>>>>
>>>>> Maybe I got back too quickly!!
>>>>>
>>>>> I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.
>>>>>
>>>>> I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.
>>>>>
>>>>> Downloading the iso today from the latest directory gives me the build ed2c97b7.
>>>>>
>>>>> I am going to install that version now but I suspect it will show the same as I found with my build.
>>>>>
>>>>> So it looks like my original review was based on the version before the cleanup branch changes were included.
>>>>>
>>>>> I will come back with new feedback of what I find from the latest branch that I have now downloaded.
>>>>>
>>>>> Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.
>>>>>
>>>>> Regards,
>>>>>
>>>>> Adolf
>>>>>
>>>>>>> I suppose this also means that the ISO in the next branch boots just fine, too?
>>>>>>
>>>>>> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
>>>>>> This tested out raid and all 4 interfaces.
>>>>>>
>>>>>> Regards,
>>>>>> Adolf.
>>>>>>
>>>>>>>
>>>>>>> Best,
>>>>>>> -Michael
>>>>>>>
>>>>>>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>>>>>>
>>>>>>>> Hi Michael,
>>>>>>>>
>>>>>>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>>>>>>
>>>>>>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>>>>>>
>>>>>>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>>>>>>
>>>>>>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>>>>>>
>>>>>>>> Of course good for others to also evaluate.
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>>
>>>>>>>> Adolf.
>>>>>>>>
>>>>>>>

Test of cleanup branch

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hi Michael,

I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.

I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.

Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...

Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.

Of course good for others to also evaluate.

Regards,

Adolf.

Re: Test of cleanup branch

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

Hello Adolf,

Thank you for getting back on this so quickly.

I suppose this also means that the ISO in the next branch boots just fine, too?

Best,
-Michael

> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
> 
> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
> 
> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
> 
> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
> 
> Of course good for others to also evaluate.
> 
> Regards,
> 
> Adolf.
> 

Re: Test of cleanup branch

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

Hi Michael,

On 25/07/2024 10:44, Michael Tremer wrote:
> Hello Adolf,
> 
> Thank you for getting back on this so quickly.
> 
> I suppose this also means that the ISO in the next branch boots just fine, too?

Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
This tested out raid and all 4 interfaces.

Regards,
Adolf.

> 
> Best,
> -Michael
> 
>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> Hi Michael,
>>
>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>
>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>
>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>
>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>
>> Of course good for others to also evaluate.
>>
>> Regards,
>>
>> Adolf.
>>
> 

Re: Test of cleanup branch

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 2271 bytes --]

Hi Michael,

On 25/07/2024 12:28, Adolf Belka wrote:
> Hi Michael,
>
> On 25/07/2024 10:44, Michael Tremer wrote:
>> Hello Adolf,
>>
>> Thank you for getting back on this so quickly.
>>
Maybe I got back too quickly!!

I have just done a build with next for a bugfix patch and installed it into my vm and the pages look quite different with some things missing, like the green and red colours for if services are running or not and some graph titles are incorrect.

I took the iso from the latest directory in the nightly build but it looks like it was still linked to the previous version when I downloaded it as the b2 sum is for build 6460dbbf from the day before.

Downloading the iso today from the latest directory gives me the build ed2c97b7.

I am going to install that version now but I suspect it will show the same as I found with my build.

So it looks like my original review was based on the version before the cleanup branch changes were included.

I will come back with new feedback of what I find from the latest branch that I have now downloaded.

Sorry. In future maybe I should wait till the following day, or download from the build named directory instead of the directory named latest.

Regards,

Adolf

>> I suppose this also means that the ISO in the next branch boots just fine, too?
>
> Yes, that is correct. I used the iso from the nightly next latest directory. No problems with the install at all.
> This tested out raid and all 4 interfaces.
>
> Regards,
> Adolf.
>
>>
>> Best,
>> -Michael
>>
>>> On 25 Jul 2024, at 09:07, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>
>>> Hi Michael,
>>>
>>> I installed CU188 from the nightly onto a vm system and looked though all the WUI pages and everything looked fine.
>>>
>>> I then restored a CU187 backup from my testing and then checked the OpenVPN RW and N2N. Both worked fine with no problems. Also the logging for that all worked with no problems.
>>>
>>> Also checked out the IPS, IP Blocklists, Firewall groups and rules, DNS ...
>>>
>>> Everything I have looked at shows no impact from the cleanup branch changes. It looks good to me.
>>>
>>> Of course good for others to also evaluate.
>>>
>>> Regards,
>>>
>>> Adolf.
>>>
>>