From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] miniupnpd: Delete files that would have become orphaned after deletion of miniupnpd add-on as well Date: Thu, 20 May 2021 23:27:46 +0200 Message-ID: <440992d6-1bfd-c2fe-dfd0-f636d3919160@ipfire.org> In-Reply-To: <2BC01D5C-A62D-4F61-AEB4-56A00F732BE1@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7530609592654502377==" List-Id: --===============7530609592654502377== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, thanks for your reply. Yes, I missed those indeed. They say intelligent life before the days' first = coffee is possible in theory, however completely illusionary in the real world. :-/ Thanks, and best regards, Peter M=C3=BCller > This patch is lacking the changes to the root files. >=20 > I will take care of this. >=20 > -Michael >=20 >> On 18 May 2021, at 20:58, Peter M=C3=BCller w= rote: >> >> This patch requires >> https://patchwork.ipfire.org/project/ipfire/list/?series=3D2059 to be >> applied in the first place. >> >> Signed-off-by: Peter M=C3=BCller >> --- >> config/miniupnpd/miniupnpd.conf | 50 ------------------- >> .../networking/red.down/10-miniupnpd | 6 --- >> .../networking/red.up/10-miniupnpd | 6 --- >> 3 files changed, 62 deletions(-) >> delete mode 100644 config/miniupnpd/miniupnpd.conf >> delete mode 100644 src/initscripts/networking/red.down/10-miniupnpd >> delete mode 100644 src/initscripts/networking/red.up/10-miniupnpd >> >> diff --git a/config/miniupnpd/miniupnpd.conf b/config/miniupnpd/miniupnpd.= conf >> deleted file mode 100644 >> index 582758192..000000000 >> --- a/config/miniupnpd/miniupnpd.conf >> +++ /dev/null >> @@ -1,50 +0,0 @@ >> - >> -# LAN network interfaces IPs / networks >> -# there can be multiple listening ips for SSDP traffic. >> -# should be under the form nnn.nnn.nnn.nnn/nn >> -listening_ip=3Dgreen0 >> -#listening_ip=3Dgreen1 >> - >> -# HTTP is available on all interfaces >> -# port for HTTP (descriptions and SOAP) traffic. set 0 for autoselect. >> -port=3D0 >> - >> -# chain names for netfilter (not used for pf or ipf). >> -upnp_forward_chain=3DUPNPFW >> -upnp_nat_chain=3DUPNPFW >> - >> -# bitrates reported by daemon in bits per second >> -bitrate_up=3D1000000 >> -bitrate_down=3D10000000 >> - >> -# "secure" mode : when enabled, UPnP client are allowed to add mappings o= nly >> -# to their IP. >> -secure_mode=3Dyes >> - >> -# report system uptime instead of daemon uptime >> -system_uptime=3Dyes >> - >> -# notify interval in seconds. default is 30 seconds. >> -notify_interval=3D60 >> - >> -# unused rules cleaning. >> -# never remove any rule before this threshold for the number >> -# of redirections is exceeded. default to 20 >> -#clean_ruleset_threshold=3D10 >> -# clean process work interval in seconds. default to 0 (disabled). >> -# a 600 seconds (10 minutes) interval makes sense >> -clean_ruleset_interval=3D600 >> - >> -# serial and model number the daemon will report to clients >> -# in its XML description >> -serial=3D12345678 >> -model_number=3D1 >> - >> -# UPnP permission rules >> -# (allow|deny) (external port range) ip/mask (internal port range) >> -# A port range is - or if there is only >> -# one port in the range. >> -# ip/mask format must be nn.nn.nn.nn/nn >> -# it is advised to only allow redirection of port above 1024 >> -# and to finish the rule set with "deny 0-65535 0.0.0.0/0 0-65535" >> -allow 0-65535 0.0.0.0/0 0-65535 >> diff --git a/src/initscripts/networking/red.down/10-miniupnpd b/src/initsc= ripts/networking/red.down/10-miniupnpd >> deleted file mode 100644 >> index eaf2239e9..000000000 >> --- a/src/initscripts/networking/red.down/10-miniupnpd >> +++ /dev/null >> @@ -1,6 +0,0 @@ >> -#!/bin/bash >> - >> -[ -x /etc/init.d/miniupnpd ] && \ >> - /etc/init.d/miniupnpd stop &>/dev/null >> - >> -exit 0 >> diff --git a/src/initscripts/networking/red.up/10-miniupnpd b/src/initscri= pts/networking/red.up/10-miniupnpd >> deleted file mode 100644 >> index 54431331b..000000000 >> --- a/src/initscripts/networking/red.up/10-miniupnpd >> +++ /dev/null >> @@ -1,6 +0,0 @@ >> -#!/bin/bash >> - >> -[ -x /etc/init.d/miniupnpd ] && \ >> - /etc/init.d/miniupnpd start &>/dev/null >> - >> -exit 0 >> --=20 >> 2.26.2 >=20 --===============7530609592654502377==--