Re: [PATCH] Inform users about the eol of i?86

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 3253 bytes --]

Hello,

Indeed. Good catch.

I think this would be fine without the link. We will send an announcement which people hopefully won’t miss.

@Jonatan: Are you going to resubmit this patch?

Best,
-Michael

> On 28 Nov 2021, at 20:09, Leo Hofmann <hofmann(a)leo-andres.de> wrote:
> 
> Hi Jonatan,
> 
> Am 28.11.2021 um 16:43 schrieb Jonatan Schlag:
>> The warning point to a wiki page which is currently in construction.
>> This should give us the opportunity to add further information for
>> these users even if we do not provide updates anymore.
>> 
>> Signed-off-by: Jonatan Schlag <jonatan.schlag(a)ipfire.org>
>> ---
>>  html/cgi-bin/index.cgi | 4 ++--
>>  langs/de/cgi-bin/de.pl | 1 +
>>  langs/en/cgi-bin/en.pl | 1 +
>>  3 files changed, 4 insertions(+), 2 deletions(-)
>> 
>> diff --git a/html/cgi-bin/index.cgi b/html/cgi-bin/index.cgi
>> index 948fdde55..90e2daff0 100644
>> --- a/html/cgi-bin/index.cgi
>> +++ b/html/cgi-bin/index.cgi
>> @@ -541,10 +541,10 @@ if ( ! -e "/var/ipfire/main/send_profile") {
>>  	$warnmessage .= "<li><a style='color: white;' href='fireinfo.cgi'>$Lang::tr{'fireinfo please enable'}</a></li>";
>>  }
>>  -# Legacy architecture
>> +# EOL architecture
>>  my ($sysname, $nodename, $release, $version, $machine) = &POSIX::uname();
>>  if ($machine =~ m/^i.86$/) {
>> -	$warnmessage .= "<li>$Lang::tr{'legacy architecture warning'}</li>";
>> +	$warnmessage .= "<li href='https://wiki.ipfire.org/hardware/eol-architectures'>$Lang::tr{'eol architecture warning'}</li>";
> The "href" attribute isn't officially allowed in <li> elements, this link may not work with picky browsers.
> Here you can see which elements support "href": https://www.w3schools.com/tags/att_href.asp
> 
> Best regards
> Leo
> 
>>  }
>>    # Memory usage warning
>> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
>> index e350bc651..c81b28fea 100644
>> --- a/langs/de/cgi-bin/de.pl
>> +++ b/langs/de/cgi-bin/de.pl
>> @@ -989,6 +989,7 @@
>>  'enter data' => 'Geben Sie die Daten ein <br /> und klicken Sie danach auf <i>Speichern</i>.',
>>  'entropy' => 'Entropie',
>>  'entropy graphs' => 'Entropiegraphen',
>> +'eol architecture warning' => 'Sie betreiben ein IPFire System auf einer Architektur, welche nicht mehr unterstützt wird. Sie werden keine Updates mehr erhalten. Das ist ein Sicherheitsrisiko.',
>>  'err bk 1' => 'Fehler beim Erzeugen des Archivs',
>>  'err bk 10 password' => 'Fehler beim Datensicherungs-Passwort',
>>  'err bk 2 key' => 'Fehler beim Erzeugen der Schlüsseldatei',
>> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
>> index 4c05dcf76..a92bb07f8 100644
>> --- a/langs/en/cgi-bin/en.pl
>> +++ b/langs/en/cgi-bin/en.pl
>> @@ -1015,6 +1015,7 @@
>>  'enter data' => 'Enter your settings <br /> and then press <i>Save</i>.',
>>  'entropy' => 'Entropy',
>>  'entropy graphs' => 'Entropy Graphs',
>> +'eol architecture warning' => 'You are running an architecture of IPFire which reached its end of life. You will not receive updates anymore. This is a security risk.',
>>  'err bk 1' => 'Error creating archive',
>>  'err bk 10 password' => 'Error with backup password',
>>  'err bk 2 key' => 'Error creating key file',