From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] getrrdimage.cgi: Fix supported origins list
Date: Sat, 07 Aug 2021 23:11:41 +0200 [thread overview]
Message-ID: <46349e1a-805a-ad84-12dc-f0732440869e@ipfire.org> (raw)
In-Reply-To: <20210807204207.1713-1-hofmann@leo-andres.de>
[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Am 07.08.2021 um 22:42 schrieb Leo-Andres Hofmann:
> Support for the graphs of "services.cgi" is implemented,
> but it was forgotten to add this to the list of origins.
> This patch fixes the list and prevents possibly missing graphs.
>
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
>
> Well, to be honest, I just missed it while copy-pasting the origins and never checked that list again.
>
> html/cgi-bin/getrrdimage.cgi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi
> index 92f8b585d..26bcf0905 100644
> --- a/html/cgi-bin/getrrdimage.cgi
> +++ b/html/cgi-bin/getrrdimage.cgi
> @@ -36,8 +36,8 @@ require "${General::swroot}/graphs.pl";
> # List of graph origins that getrrdimage.cgi can process directly
> # (unknown origins are forwarded to ensure compatibility)
> my @supported_origins = ("entropy.cgi", "hardwaregraphs.cgi", "media.cgi",
> - "memory.cgi","netexternal.cgi", "netinternal.cgi", "netother.cgi",
> - "netovpnrw.cgi", "netovpnsrv.cgi", "qos.cgi", "system.cgi");
> + "memory.cgi", "netexternal.cgi", "netinternal.cgi", "netother.cgi",
> + "netovpnrw.cgi", "netovpnsrv.cgi", "qos.cgi", "services.cgi", "system.cgi");
>
> ### Process GET parameters ###
> # URL format: /?origin=[graph origin cgi]&graph=[graph name]&range=[time range]
>
prev parent reply other threads:[~2021-08-07 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 20:42 Leo-Andres Hofmann
2021-08-07 21:11 ` Bernhard Bitsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46349e1a-805a-ad84-12dc-f0732440869e@ipfire.org \
--to=bbitsch@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox