From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Bitsch To: development@lists.ipfire.org Subject: Re: [PATCH] getrrdimage.cgi: Fix supported origins list Date: Sat, 07 Aug 2021 23:11:41 +0200 Message-ID: <46349e1a-805a-ad84-12dc-f0732440869e@ipfire.org> In-Reply-To: <20210807204207.1713-1-hofmann@leo-andres.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4880123845908843462==" List-Id: --===============4880123845908843462== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bernhard Bitsch Am 07.08.2021 um 22:42 schrieb Leo-Andres Hofmann: > Support for the graphs of "services.cgi" is implemented, > but it was forgotten to add this to the list of origins. > This patch fixes the list and prevents possibly missing graphs. >=20 > Signed-off-by: Leo-Andres Hofmann > --- >=20 > Well, to be honest, I just missed it while copy-pasting the origins and nev= er checked that list again. >=20 > html/cgi-bin/getrrdimage.cgi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi > index 92f8b585d..26bcf0905 100644 > --- a/html/cgi-bin/getrrdimage.cgi > +++ b/html/cgi-bin/getrrdimage.cgi > @@ -36,8 +36,8 @@ require "${General::swroot}/graphs.pl"; > # List of graph origins that getrrdimage.cgi can process directly > # (unknown origins are forwarded to ensure compatibility) > my @supported_origins =3D ("entropy.cgi", "hardwaregraphs.cgi", "media.cg= i", > - "memory.cgi","netexternal.cgi", "netinternal.cgi", "netother.cgi", > - "netovpnrw.cgi", "netovpnsrv.cgi", "qos.cgi", "system.cgi"); > + "memory.cgi", "netexternal.cgi", "netinternal.cgi", "netother.cgi", > + "netovpnrw.cgi", "netovpnsrv.cgi", "qos.cgi", "services.cgi", "system.cgi= "); > =20 > ### Process GET parameters ### > # URL format: /?origin=3D[graph origin cgi]&graph=3D[graph name]&range=3D= [time range] >=20 --===============4880123845908843462==--