Re: Core Update 147 testing

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 3293 bytes --]

Hi,

> On 3 Jul 2020, at 12:20, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
> 
> Hi Michael,
> 
> Thanks for the information. I had missed the need to do that when I installed an updated bacula as a local add-on. The whole backup file requirement isn't mentioned in the Wiki page on installing your own add-on. I will think about maybe updating or rewriting that page using the bacula package as an example.

Yes, it is a good idea to add it.

I am not sure in what way this needs a total rewrite.

> I will correct my files and submit a new patch. Do I make the patch based on the existing Core 146 9.0.6 version (so a v3 version of the patch) or on the Core 147 development build?

Yes, please make the patch against the next branch in the main repository.

Start with a clean branch based on origin/next and add your commits. Then send the whole thing to the list using git send-email.

If you have any questions, don’t hesitate to ask :)

-Michael

> 
> 
> Regards,
> 
> Adolf.
> 
> On 03/07/2020 11:36, Michael Tremer wrote:
>> Hi Adolf,
>> 
>> This looks like a simple problem.
>> 
>> The file is simply missing in the root file:
>> 
>> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=config/rootfiles/packages/bacula;h=4ee408fc4154c56549bb7456f6e5be03791d48a2;hb=HEAD
>> 
>> It should be listed there. Like here for example:
>> 
>> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=config/rootfiles/packages/postfix;h=23e1efb255ceb5636117bf2907dce637756c83e9;hb=HEAD
>> 
>> lfs/bacula doesn’t install the file either, like Postfix does:
>> 
>> https://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=lfs/postfix;h=6ca3b23e93946c92d967bbbd23ec57d96883856b;hb=HEAD
>> 
>> You can simply copy that command from postfix (of course change it to the right name), add it to the root file and then submit a patch :)
>> 
>> Best,
>> -Michael
>> 
>>> On 3 Jul 2020, at 00:20, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>> 
>>> Dear All,
>>> 
>>> I went back to a Core Update 146 system and installed the old bacula 9.0.6 and found that version also had no backup include file in place, although it did exist in the config/backup/includes directory from the git clone.
>>> 
>>> Adolf
>>> 
>>> 
>>> On 03/07/2020 00:11, Adolf Belka wrote:
>>>> Dear All,
>>>> 
>>>> I have tested Core Update 147 out on my virtual ipfire test bed network.
>>>> 
>>>> I also tested out installing bacula with its new version. It installed okay and started successfully. To test it out fully I will need to do the test on my production system.
>>>> 
>>>> However I found one problem. The /var/ipfire/backup/addons/includes/bacula file is not there. There is no includes directory under addons and the bacula option is not there in the backup menu in the WUI.
>>>> 
>>>> Probably something I did wrong in how I did my patch but I don't know what the problem is. The patch included the config/backup/includes/bacula file. Could someone figure out what the problem is.
>>>> 
>>>> Apart from the problem with the bacula addon backup option not being present everything else on my testbed with update 147 is working fine, although it is not a complicated setup. Just red, green, blue and orange but no other options yet.
>>>> 
>>>> Adolf.
>>>>