From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: Core Update 147 testing Date: Fri, 03 Jul 2020 13:44:39 +0100 Message-ID: <4693C448-FFF9-4D26-84B3-C6109AC49B5B@ipfire.org> In-Reply-To: <429536f4-3023-f9c2-8a8c-7d604a29fa02@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0694732695432123874==" List-Id: --===============0694732695432123874== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, > On 3 Jul 2020, at 12:20, Adolf Belka wrote: >=20 > Hi Michael, >=20 > Thanks for the information. I had missed the need to do that when I install= ed an updated bacula as a local add-on. The whole backup file requirement isn= 't mentioned in the Wiki page on installing your own add-on. I will think abo= ut maybe updating or rewriting that page using the bacula package as an examp= le. Yes, it is a good idea to add it. I am not sure in what way this needs a total rewrite. > I will correct my files and submit a new patch. Do I make the patch based o= n the existing Core 146 9.0.6 version (so a v3 version of the patch) or on th= e Core 147 development build? Yes, please make the patch against the next branch in the main repository. Start with a clean branch based on origin/next and add your commits. Then sen= d the whole thing to the list using git send-email. If you have any questions, don=E2=80=99t hesitate to ask :) -Michael >=20 >=20 > Regards, >=20 > Adolf. >=20 > On 03/07/2020 11:36, Michael Tremer wrote: >> Hi Adolf, >>=20 >> This looks like a simple problem. >>=20 >> The file is simply missing in the root file: >>=20 >> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dconfig/rootfiles/p= ackages/bacula;h=3D4ee408fc4154c56549bb7456f6e5be03791d48a2;hb=3DHEAD >>=20 >> It should be listed there. Like here for example: >>=20 >> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dconfig/rootfiles/p= ackages/postfix;h=3D23e1efb255ceb5636117bf2907dce637756c83e9;hb=3DHEAD >>=20 >> lfs/bacula doesn=E2=80=99t install the file either, like Postfix does: >>=20 >> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dlfs/postfix;h=3D6c= a3b23e93946c92d967bbbd23ec57d96883856b;hb=3DHEAD >>=20 >> You can simply copy that command from postfix (of course change it to the = right name), add it to the root file and then submit a patch :) >>=20 >> Best, >> -Michael >>=20 >>> On 3 Jul 2020, at 00:20, Adolf Belka wrote: >>>=20 >>> Dear All, >>>=20 >>> I went back to a Core Update 146 system and installed the old bacula 9.0.= 6 and found that version also had no backup include file in place, although i= t did exist in the config/backup/includes directory from the git clone. >>>=20 >>> Adolf >>>=20 >>>=20 >>> On 03/07/2020 00:11, Adolf Belka wrote: >>>> Dear All, >>>>=20 >>>> I have tested Core Update 147 out on my virtual ipfire test bed network. >>>>=20 >>>> I also tested out installing bacula with its new version. It installed o= kay and started successfully. To test it out fully I will need to do the test= on my production system. >>>>=20 >>>> However I found one problem. The /var/ipfire/backup/addons/includes/bacu= la file is not there. There is no includes directory under addons and the bac= ula option is not there in the backup menu in the WUI. >>>>=20 >>>> Probably something I did wrong in how I did my patch but I don't know wh= at the problem is. The patch included the config/backup/includes/bacula file.= Could someone figure out what the problem is. >>>>=20 >>>> Apart from the problem with the bacula addon backup option not being pre= sent everything else on my testbed with update 147 is working fine, although = it is not a complicated setup. Just red, green, blue and orange but no other = options yet. >>>>=20 >>>> Adolf. >>>>=20 --===============0694732695432123874==--