public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] boost: Fix rootfile entries that referred to python3.8 instead of 3.10
Date: Wed, 04 May 2022 19:43:41 +0000	[thread overview]
Message-ID: <46de86fe-296e-8fcd-515d-266dd63e6209@ipfire.org> (raw)
In-Reply-To: <20220504111429.3606496-1-adolf.belka@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 3790 bytes --]

Good catch, thank you!

Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>

> - In Jan 2022 I updated python from 3.8 to 3.10 but I missed that boost had rootfile
>     entries with python38 in it.
> - Running a build just now for another package it got flagged up that the rootfile for
>     boost had been changed and the logfile now had the entries with python310 instead of
>     python38
> - Not clear why it only flagged this up now but this patch is to correct that error
> - Running find-dependencies on both the pyton38 and python310 versions of the libraries
>    flagged nothing as being linked to either, so probably lucky with this being missed
>    first time around.
> - Boost will need to be shipped with a Core Update
> 
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   config/rootfiles/common/aarch64/boost | 8 ++++----
>   config/rootfiles/common/armv6l/boost  | 8 ++++----
>   config/rootfiles/common/x86_64/boost  | 8 ++++----
>   3 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/config/rootfiles/common/aarch64/boost b/config/rootfiles/common/aarch64/boost
> index 49ff120ab..015dc1458 100644
> --- a/config/rootfiles/common/aarch64/boost
> +++ b/config/rootfiles/common/aarch64/boost
> @@ -16250,10 +16250,10 @@ usr/lib/libboost_nowide-a64.so.1.76.0
>   usr/lib/libboost_prg_exec_monitor-mt-a64.so.1.76.0
>   #usr/lib/libboost_prg_exec_monitor-a64.so
>   usr/lib/libboost_prg_exec_monitor-a64.so.1.76.0
> -#usr/lib/libboost_python38-mt-a64.so
> -usr/lib/libboost_python38-mt-a64.so.1.76.0
> -#usr/lib/libboost_python38-a64.so
> -usr/lib/libboost_python38-a64.so.1.76.0
> +#usr/lib/libboost_python310-mt-a64.so
> +usr/lib/libboost_python310-mt-a64.so.1.76.0
> +#usr/lib/libboost_python310-a64.so
> +usr/lib/libboost_python310-a64.so.1.76.0
>   #usr/lib/libboost_random-mt-a64.so
>   usr/lib/libboost_random-mt-a64.so.1.76.0
>   #usr/lib/libboost_random-a64.so
> diff --git a/config/rootfiles/common/armv6l/boost b/config/rootfiles/common/armv6l/boost
> index 80cc4063a..79e9ed3d7 100644
> --- a/config/rootfiles/common/armv6l/boost
> +++ b/config/rootfiles/common/armv6l/boost
> @@ -16250,10 +16250,10 @@ usr/lib/libboost_nowide-mt-a32.so.1.76.0
>   usr/lib/libboost_prg_exec_monitor-a32.so.1.76.0
>   #usr/lib/libboost_prg_exec_monitor-mt-a32.so
>   usr/lib/libboost_prg_exec_monitor-mt-a32.so.1.76.0
> -#usr/lib/libboost_python38-a32.so
> -usr/lib/libboost_python38-a32.so.1.76.0
> -#usr/lib/libboost_python38-mt-a32.so
> -usr/lib/libboost_python38-mt-a32.so.1.76.0
> +#usr/lib/libboost_python310-a32.so
> +usr/lib/libboost_python310-a32.so.1.76.0
> +#usr/lib/libboost_python310-mt-a32.so
> +usr/lib/libboost_python310-mt-a32.so.1.76.0
>   #usr/lib/libboost_random-a32.so
>   usr/lib/libboost_random-a32.so.1.76.0
>   #usr/lib/libboost_random-mt-a32.so
> diff --git a/config/rootfiles/common/x86_64/boost b/config/rootfiles/common/x86_64/boost
> index 357dc2d1d..77eef1d0b 100644
> --- a/config/rootfiles/common/x86_64/boost
> +++ b/config/rootfiles/common/x86_64/boost
> @@ -16250,10 +16250,10 @@ usr/lib/libboost_nowide-x64.so.1.76.0
>   usr/lib/libboost_prg_exec_monitor-mt-x64.so.1.76.0
>   #usr/lib/libboost_prg_exec_monitor-x64.so
>   usr/lib/libboost_prg_exec_monitor-x64.so.1.76.0
> -#usr/lib/libboost_python38-mt-x64.so
> -usr/lib/libboost_python38-mt-x64.so.1.76.0
> -#usr/lib/libboost_python38-x64.so
> -usr/lib/libboost_python38-x64.so.1.76.0
> +#usr/lib/libboost_python310-mt-x64.so
> +usr/lib/libboost_python310-mt-x64.so.1.76.0
> +#usr/lib/libboost_python310-x64.so
> +usr/lib/libboost_python310-x64.so.1.76.0
>   #usr/lib/libboost_random-mt-x64.so
>   usr/lib/libboost_random-mt-x64.so.1.76.0
>   #usr/lib/libboost_random-x64.so

  reply	other threads:[~2022-05-04 19:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04 11:14 Adolf Belka
2022-05-04 19:43 ` Peter Müller [this message]
2022-05-06 13:40   ` Adolf Belka
     [not found] <9ec697a6-9a87-535a-be15-9e322b44a9aa@ipfire.org>
2022-05-08 14:10 ` [PATCH] " Adolf Belka
2022-05-08 21:05   ` Adolf Belka
2022-05-12  9:27     ` Michael Tremer
2022-05-12 11:33       ` Adolf Belka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46de86fe-296e-8fcd-515d-266dd63e6209@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox