From mboxrd@z Thu Jan  1 00:00:00 1970
From: bbitsch@ipfire.org
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/4] unbound-dhcp-leases-bridge: Fix typo
Date: Mon, 21 Oct 2024 22:02:21 +0200
Message-ID: <47ee1ae5-9bb0-4645-8a5d-0c369b0cf2b9@ipfire.org>
In-Reply-To: <6BF9FD99-2DC6-49B5-A763-BB14EB9D45A8@rymes.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8541814764480526449=="
List-Id: <development.lists.ipfire.org>

--===============8541814764480526449==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

If I understand the rules cited, is it a user or an user? Just to choose an e=
xample, which is apparent frequently.

On 21.10.24 21:38, Tom Rymes <tom(a)rymes.net> wrote:
> If this is any help, I also always use =E2=80=9Can=E2=80=9D when in combina=
tion with an acronym that is pronounced with a vowel sound. I=E2=80=99d also =
say it isn=E2=80=99t terribly important, as mentioned already by Nick, and it=
 doesn=E2=80=99t stick out to me as an error either way.
>=20
> FWIW, the same rule does apply with letter sounds: =E2=80=9Can F=E2=80=9D i=
s the same as =E2=80=9Can eff=E2=80=9D.
>=20
> =E2=80=9C=E2=80=A6an FQDN=E2=80=A6=E2=80=9D
> =E2=80=9C=E2=80=A6an SOP=E2=80=A6=E2=80=9D
>=20
> =E2=80=9C=E2=80=A6a PDF=E2=80=A6=E2=80=9D
> =E2=80=9C=E2=80=A6a BFH=E2=80=A6=E2=80=9D
>=20
> I do wonder about =E2=80=9CUFO=E2=80=9D, and I wouldn=E2=80=99t say =E2=80=
=9Can UFO=E2=80=9D, so your guess is as good as mine there.
>=20
> I don=E2=80=99t think I cleared that up at all, but it=E2=80=99s English, s=
o that=E2=80=99s probably par for the course and a sign I=E2=80=99m on the ri=
ght track.
>=20
> Tom
>=20
> > On Oct 21, 2024, at 1:14 PM, Nick Howitt <nick(a)howitts.co.uk> wrote:
> >
> > Technically, I think this update is incorrect and "an" is correct - https=
://www.reddit.com/r/grammar/comments/riql6s/a_or_an_before_acronym_that_is_pr=
onounced_with_a/ and https://www.grammar.com/a-vs-an-when-to-use. But TBH, I =
really don't think it is too important.
> >
> > Nick
> >
> >
> > On 21/10/2024 17:44, Bernhard Bitsch wrote:
> >>
> >> Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org> <mailto:bbitsch(a)ip=
fire.org>
> >>
> >> Am 21.10.2024 um 18:38 schrieb Michael Tremer:
> >>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org> <mailto:mic=
hael.tremer(a)ipfire.org>
> >>> ---
> >>>    config/unbound/unbound-dhcp-leases-bridge | 4 ++--
> >>>    1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/config/unbound/unbound-dhcp-leases-bridge b/config/unbound=
/unbound-dhcp-leases-bridge
> >>> index bc944a073..2cbdaa004 100644
> >>> --- a/config/unbound/unbound-dhcp-leases-bridge
> >>> +++ b/config/unbound/unbound-dhcp-leases-bridge
> >>> @@ -279,9 +279,9 @@ class UnboundDHCPLeasesBridge(object):
> >>>            self.unbound.update_dhcp_leases([l for l in self.leases if n=
ot l.has_expired()])
> >>>          def _add_lease(self, lease):
> >>> -        # Skip leases without an FQDN
> >>> +        # Skip leases without a FQDN
> >>>            if not lease.fqdn:
> >>> -            log.debug("Skipping lease without an FQDN: %s" % lease)
> >>> +            log.debug("Skipping lease without a FQDN: %s" % lease)
> >>>                return
> >>>              # Skip any leases that also are a static host
> >>
> >
>=20
>=20
>=20

--===============8541814764480526449==--