From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH 1/2] sshfs: Update to 3.7.1 Date: Sat, 09 Jan 2021 14:58:26 +0000 Message-ID: <4807CA10-BD6F-4375-B841-75A7257425F3@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7496981392765509996==" List-Id: --===============7496981392765509996== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, > On 9 Jan 2021, at 14:55, Adolf Belka (ipfire) wrot= e: >=20 > Hi, >=20 > On 07/01/2021 14:53, Michael Tremer wrote: >> Hello, >>=20 >>> On 7 Jan 2021, at 13:34, Adolf Belka wrote: >>>=20 >>> Hi Michael, >>>=20 >>> On 07/01/2021 12:25, Michael Tremer wrote: >>>> Hi, >>>> In the Git repository of fuse, there is an initscript that loads the ker= nel module when the system boots: >>>> https://github.com/libfuse/libfuse/blob/f54eb86e9a0b596dfeceb18277efa8f8= 40d85919/util/init_script >>>> Maybe we want to integrate this. >>> That could be an option but the downside would be that the fuse module wo= uld then be enabled for all IPFire users, even if they are not using fuse. I = think if people aren't using fuse on a firewall it is probably better to not = load it automatically. >> Yes, I would agree. I assumed fuse was a package. Maybe it should be one. >=20 > So I have had a look at this and it seems like both sshfs and fuse could be= converted to addons. Fuse is only mentioned on three other addons, samba, op= envmtools and borgbackup and not for any core programs. I do not understand precisely why those add-ons need fuse. Any ideas? > Fuse would need to be added as a dependency to those addons. By having that= dependency does it mean that any systems with one of those addons already in= stalled will automatically have the fuse addon installed as part of the core = update or will I need a separate script to check for that. >=20 > Should I look at doing this change now or wait till after the next core upd= ate has been released. I think we can start working on this now. I do not see any reason to wait. -Michael > Regards, >=20 > Adolf >=20 >>> As there have been no questions on IPFire Community about fuse not being = loaded or any problems with sshfs then either no one is using sshfs and fuse = or they have been able to figure it out. >>>=20 >>> My preference would be to leave it as it is. >>> I was going to say that I could update the wiki to mention about the need= to run modprobe fuse but I found that sshfs is not mentioned anywhere in the= wiki (at least the search came back with zero results). >>>=20 >>> Having found out about sshfs on IPFire, I will likely use it from time to= time. >> It is quite a nice tool :) >>=20 >>> Regards, >>> Adolf >>>=20 >>>> -Michael >>>>> On 6 Jan 2021, at 19:21, Adolf Belka wrote: >>>>>=20 >>>>> Hi Michael, >>>>>=20 >>>>> I suddenly thought I should also check the old version on Core 153, so = I did that and the same thing happens. The fuse module is not loaded automati= cally when sshfs command is run, but the error message is very helpful. >>>>>=20 >>>>> "fuse: device not found, try 'modprobe fuse' first" >>>>>=20 >>>>> So the new sshfs version operates the same as the old one, so I am no l= onger so worried about this. >>>>>=20 >>>>>=20 >>>>> Regards, >>>>>=20 >>>>> Adolf >>>>>=20 >>>>> On 06/01/2021 19:39, Adolf Belka wrote: >>>>>> Hi, >>>>>>=20 >>>>>>=20 >>>>>> On 06/01/2021 16:30, Michael Tremer wrote: >>>>>>> Hi, >>>>>>>=20 >>>>>>>> On 5 Jan 2021, at 14:28, Adolf Belka wrote: >>>>>>>>=20 >>>>>>>> Dear all, >>>>>>>>=20 >>>>>>>> Forgot to mention in the logs that I have also installed the built I= PFire with new fuse and sshfs into my testbed system and was able to setup an= sshfs mount from a remote computer into the IPFire system, so confirmed work= ing. >>>>>>>>=20 >>>>>>>> The only thing I had to do was run modprobe fuse as the fuse module = was not loaded. Is that normal to need to do or did I miss something when I w= as building sshfs/fuse >>>>>>> I would expect that sshfs is doing that automatically. >>>>>> Then there may be a problem. When I ran the sshfs command I got a mess= age that it could not find fuse and it suggested that I should run modprobe f= use, which I did, and then the same sshfs command worked. >>>>>>=20 >>>>>> Not sure how to find out why sshfs did not have the modprobe command r= un automatically or how to make it do so. >>>>>>=20 >>>>>>>> Regards, >>>>>>>> Adolf. >>>>>>>>=20 >>>>>>>> On 05/01/2021 15:20, Adolf Belka wrote: >>>>>>>>> - Update sshfs from 2.2 to 3.7.1 >>>>>>>>> - Changelog is available at https://github.com/libfuse/sshfs/releas= es >>>>>>>>> - Build had to be changed from autotools to meson/ninja >>>>>>>>> - Change in rootfiles >>>>>>>>> Signed-off-by: Adolf Belka >>>>>>>>> --- >>>>>>>>> config/rootfiles/common/sshfs | 2 ++ >>>>>>>>> lfs/sshfs | 14 ++++++-------- >>>>>>>>> 2 files changed, 8 insertions(+), 8 deletions(-) >>>>>>>>> diff --git a/config/rootfiles/common/sshfs b/config/rootfiles/commo= n/sshfs >>>>>>>>> index 2cafa3e24..579b938f5 100644 >>>>>>>>> --- a/config/rootfiles/common/sshfs >>>>>>>>> +++ b/config/rootfiles/common/sshfs >>>>>>>>> @@ -1,2 +1,4 @@ >>>>>>>>> usr/bin/sshfs >>>>>>>>> +#usr/sbin/mount.fuse.sshfs >>>>>>>>> +#usr/sbin/mount.sshfs >>>>>>>>> #usr/share/man/man1/sshfs.1 >>>>>>>>> diff --git a/lfs/sshfs b/lfs/sshfs >>>>>>>>> index 23fbd18ca..1e7706194 100644 >>>>>>>>> --- a/lfs/sshfs >>>>>>>>> +++ b/lfs/sshfs >>>>>>>>> @@ -24,10 +24,10 @@ >>>>>>>>> include Config >>>>>>>>> -VER =3D 2.2 >>>>>>>>> +VER =3D 3.7.1 >>>>>>>>> -THISAPP =3D sshfs-fuse-$(VER) >>>>>>>>> -DL_FILE =3D $(THISAPP).tar.gz >>>>>>>>> +THISAPP =3D sshfs-$(VER) >>>>>>>>> +DL_FILE =3D $(THISAPP).tar.xz >>>>>>>>> DL_FROM =3D $(URL_IPFIRE) >>>>>>>>> DIR_APP =3D $(DIR_SRC)/$(THISAPP) >>>>>>>>> TARGET =3D $(DIR_INFO)/$(THISAPP) >>>>>>>>> @@ -40,7 +40,7 @@ objects =3D $(DL_FILE) >>>>>>>>> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) >>>>>>>>> -$(DL_FILE)_MD5 =3D 26e9206eb5169e87e6f95f54bc005a4f >>>>>>>>> +$(DL_FILE)_MD5 =3D 22ac23d05ca7c56fb568627f086374d0 >>>>>>>>> install : $(TARGET) >>>>>>>>> @@ -72,9 +72,7 @@ $(subst %,%_MD5,$(objects)) : >>>>>>>>> $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >>>>>>>>> @$(PREBUILD) >>>>>>>>> - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_= FILE) >>>>>>>>> - cd $(DIR_APP) && ./configure --prefix=3D/usr >>>>>>>>> - cd $(DIR_APP) && make $(MAKETUNING) >>>>>>>>> - cd $(DIR_APP) && make install >>>>>>>>> + @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_= FILE) >>>>>>>>> + cd $(DIR_APP) && meson --prefix=3D/usr builddir && cd builddir= && ninja && ninja install >>>>>>>>> @rm -rf $(DIR_APP) >>>>>>>>> @$(POSTBUILD) --===============7496981392765509996==--