From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 4/4] grub-btrfsd: Drop redundant used PIDFILE mechanism
Date: Thu, 28 Mar 2024 10:32:30 +0000
Message-ID: <48254713-B470-481B-BA27-A8843C3BD508@ipfire.org>
In-Reply-To: <263de5edf5246d928423b7ca971f57c703de21d9.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8955078696575843137=="
List-Id: <development.lists.ipfire.org>

--===============8955078696575843137==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It is almost as if there is something good about having this review process :)

> On 27 Mar 2024, at 19:42, Stefan Schantl <stefan.schantl(a)ipfire.org> wrot=
e:
>=20
> Am Mittwoch, dem 27.03.2024 um 10:15 +0000 schrieb Michael Tremer:
>>=20
>>=20
>>> On 27 Mar 2024, at 05:15, Stefan Schantl
>>> <stefan.schantl(a)ipfire.org> wrote:
>>>=20
>>> This case is already covered by the PID mechanism of the used
>>> functions
>>>=20
>>> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
>>> ---
>>> src/initscripts/system/grub-btrfsd | 5 ++---
>>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>>=20
>>> diff --git a/src/initscripts/system/grub-btrfsd
>>> b/src/initscripts/system/grub-btrfsd
>>> index 26760f9be..5981c3a0a 100644
>>> --- a/src/initscripts/system/grub-btrfsd
>>> +++ b/src/initscripts/system/grub-btrfsd
>>> @@ -33,15 +33,14 @@ case "$1" in
>>> btrfs)
>>>=20
>>> boot_mesg "Starting GRUB/Btrfs Daemon..."
>>> - loadproc -b -p "$PIDFILE" /usr/bin/grub-btrfsd --syslog
>>> "$SNAPSHOTDIR"
>>> - echo "$!" > "$PIDFILE"
>>> + loadproc -b /usr/bin/grub-btrfsd --syslog "$SNAPSHOTDIR"
>>> ;;
>>> esac
>>> ;;
>>>=20
>>> stop)
>>> boot_mesg "Stopping grub-btrfsd..."
>>> - killproc -p "$PIDFILE" /usr/bin/grub-btrfsd
>>> + killproc -p /usr/bin/grub-btrfsd
>>> sleep 1;
>>=20
>> Why is there a sleep here?
> Good catch, that's a classical orphaned piece of code when removing
> some other stuff.
>=20
> I'll handle it in a v2 patchset.
>>=20
>>> ;;
>>>=20
>>> --=20
>>> 2.39.2



--===============8955078696575843137==--