From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4cXZ9g595yz2y5k for ; Thu, 25 Sep 2025 13:21:27 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [IPv6:2001:678:b28::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (Client CN "mail01.haj.ipfire.org", Issuer "R13" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4cXZ9c2HQKz2xM3 for ; Thu, 25 Sep 2025 13:21:24 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4cXZ9b1sfyzHW for ; Thu, 25 Sep 2025 13:21:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1758806483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3gj5qn0ilGAi9W0N5Tx2snBk2tIb5leDkNaMhQcC4Wg=; b=pzTg5uxDRH8IijGrEtTQVdaLa6SGFBftbO7GnHJvd8j21w7IidLvLSaVjq5FheAO9XOPae B7NH71Zku6Nr4XIIzRHDw6NdSentnnqf/9FAH8mAI+LJatdrAUvz9WfgltfQxahvwwbIGt TuWwqVIVxZsHAo0rBfiwai8DzJqE+xRC60BWC5SX4rWljFCY0trJKadzvw29DsUbSOCBWe D5V3znhujnyOtWXZ2cvjlxAQ5sMRTt6xrgLuszUgmmpAmY7eCqliQgPLFf2zXJY0qtNjj5 uJK0I8SMJF5eoBTXpVhK9C18S1KR0g7tr5MQj36p0wYCKQtrdr4uk2cA+L02RQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1758806483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3gj5qn0ilGAi9W0N5Tx2snBk2tIb5leDkNaMhQcC4Wg=; b=t5drEMjjwpYzUROztxT5qnTqTegkS6mYYTHxYN2SNncNEyno1BYbyeANwGbcegH+LiPdw7 MH3f9QhsF+vVcwCA== Message-ID: <4827d187-32d0-4894-a2b6-cd3480d7e590@ipfire.org> Date: Thu, 25 Sep 2025 15:21:22 +0200 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Subject: Re: [PATCH 04/16] header.pl: Fixes bug 13880 To: development@lists.ipfire.org References: <20250925111252.11893-1-adolf.belka@ipfire.org> <20250925111252.11893-4-adolf.belka@ipfire.org> Content-Language: en-GB From: Bernhard Bitsch In-Reply-To: <20250925111252.11893-4-adolf.belka@ipfire.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Bernhard Bitsch Verified-by: Bernhard Bitsch Am 25.09.2025 um 13:12 schrieb Adolf Belka: > Fixes: bug 13880 - cleanhtml() Unchecked Return Value Stored Cross-Site Scripting > Signed-off-by: Adolf Belka > --- > config/cfgroot/header.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/cfgroot/header.pl b/config/cfgroot/header.pl > index 9492b467d..6e65f4137 100644 > --- a/config/cfgroot/header.pl > +++ b/config/cfgroot/header.pl > @@ -647,7 +647,7 @@ sub cleanhtml { > # decode the UTF-8 text so that characters with diacritical marks such as > # umlauts are treated correctly by the escape command > $outstring = &Encode::decode("UTF-8",$outstring); > - escape($outstring); > + $outstring = escape($outstring); > # encode the text back to UTF-8 after running the escape command > $outstring = &Encode::encode("UTF-8",$outstring); > return $outstring;