From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] red: Fixes bug#13164 adjust pppoe plugin name in red initscript Date: Mon, 07 Aug 2023 16:10:26 +0200 Message-ID: <48BAB56A-0A3C-4924-A972-86712B944E5A@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0477146506213226166==" List-Id: --===============0477146506213226166== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Ah, that is not good then. Where did those patches go? I will dig them up and merge them into the next u= pdate. -Michael > On 7 Aug 2023, at 12:48, Adolf Belka wrote: >=20 > Hi Michael, >=20 > On 07/08/2023 11:30, Michael Tremer wrote: >> Hello Adolf, >> As the update has been released, I would say this counts as the testing be= ing done. > Neither this change to the red initscript nor the change of ppp version fro= m 2.4.9 to 2.5.0 have been merged into CU177 or into next. >=20 > The last video call feedback was that the change of ppp from 2.4.9 to 2.5.0= was significant enough that we had to be careful because it could cause peop= le to fail to have a connection. > So the decision was that it would be tested within the devs first before re= leasing it into a Testing release. >=20 > Regards, >=20 > Adolf. >> -Michael >>> On 2 Aug 2023, at 16:14, Adolf Belka wrote: >>>=20 >>> Hi All, >>>=20 >>> On 04/07/2023 14:52, Adolf Belka wrote: >>>> So next thing is to see if this updated version works for Peter and Arne= or if I have more work to do. :-) >>>>=20 >>> At the last video conf call Peter and Arne mentioned that they are able t= o test a pppoe connection with the ppp version update patch I submitted at th= e beginning of July. >>>=20 >>> https://lists.ipfire.org/pipermail/development/2023-July/016101.html >>>=20 >>> Any progress on the testing. Just let me know if there are any issues tha= t I need to work on. >>>=20 >>> Regards, >>> Adolf. >>>=20 >>>> Regards, >>>> Adolf. >>>>=20 >>>> On 04/07/2023 11:08, Michael Tremer wrote: >>>>> Thanks. This looks good to me. >>>>>=20 >>>>> Reviewed-by: Michael Tremer >>>>>=20 >>>>>> On 4 Jul 2023, at 10:04, Adolf Belka wrote: >>>>>>=20 >>>>>> - This patch goes together with the patch for the ppp update to 2.5.0 >>>>>> - The rp-pppoe.so option is no longer available. There is only the ppp= oe.so available now >>>>>>=20 >>>>>> Fixes: Bug#13164 >>>>>> Signed-off-by: Adolf Belka >>>>>> --- >>>>>> src/initscripts/networking/red | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>=20 >>>>>> diff --git a/src/initscripts/networking/red b/src/initscripts/networki= ng/red >>>>>> index 16d48f3ac..75a17bd5a 100644 >>>>>> --- a/src/initscripts/networking/red >>>>>> +++ b/src/initscripts/networking/red >>>>>> @@ -365,7 +365,7 @@ case "${1}" in >>>>>> # >>>>>> if [ "$TYPE" =3D=3D "pppoe" ]; then >>>>>> [ "${METHOD}" =3D=3D "PPPOE_PLUGIN" ] && \ >>>>>> - PLUGOPTS=3D"plugin rp-pppoe.so" >>>>>> + PLUGOPTS=3D"plugin pppoe.so" >>>>>> fi >>>>>>=20 >>>>>> ### Synchronous Mode >>>>>> --=20 >>>>>> 2.41.0 >>>>>>=20 >>>>>=20 >>>=20 >>> --=20 >>> Sent from my laptop >=20 > --=20 > Sent from my laptop --===============0477146506213226166==--