From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 05/13] kernel: Disable SLUB debugging
Date: Sat, 18 Sep 2021 16:27:09 +0000
Message-ID: <4938e18c-02b8-19c5-9175-aab827159d87@ipfire.org>
In-Reply-To: <20210917114229.10704-5-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0089570104837620367=="
List-Id: <development.lists.ipfire.org>

--===============0089570104837620367==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Michael,
hello *,

at the time of writing, I agree.

Cross-check hardening features of kernel 5.10.x is an item still open on my t=
odo list, and
I will hopefully have some spare time for this next month. I will reevaluate =
SLUB debugging
then as well, since kernsec mentions this to be necessary for some page poiso=
ning options
(whyever that is...).

Acked-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>

Thanks, and best regards,
Peter M=C3=BCller


> This is not necessary on our systems and according to the documentation
> will reduce code size of the allocator which will result in better
> performance.
>=20
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>   config/kernel/kernel.config.aarch64-ipfire | 3 +--
>   config/kernel/kernel.config.armv6l-ipfire  | 3 +--
>   config/kernel/kernel.config.i586-ipfire    | 3 +--
>   config/kernel/kernel.config.x86_64-ipfire  | 3 +--
>   4 files changed, 4 insertions(+), 8 deletions(-)
>=20
> diff --git a/config/kernel/kernel.config.aarch64-ipfire b/config/kernel/ker=
nel.config.aarch64-ipfire
> index d0ec69ba9..b277a17b5 100644
> --- a/config/kernel/kernel.config.aarch64-ipfire
> +++ b/config/kernel/kernel.config.aarch64-ipfire
> @@ -226,7 +226,7 @@ CONFIG_PERF_EVENTS=3Dy
>   # end of Kernel Performance Events And Counters
>  =20
>   CONFIG_VM_EVENT_COUNTERS=3Dy
> -CONFIG_SLUB_DEBUG=3Dy
> +# CONFIG_SLUB_DEBUG is not set
>   # CONFIG_SLUB_MEMCG_SYSFS_ON is not set
>   # CONFIG_COMPAT_BRK is not set
>   # CONFIG_SLAB is not set
> @@ -7751,7 +7751,6 @@ CONFIG_GENERIC_PTDUMP=3Dy
>   CONFIG_PTDUMP_CORE=3Dy
>   # CONFIG_PTDUMP_DEBUGFS is not set
>   # CONFIG_DEBUG_OBJECTS is not set
> -# CONFIG_SLUB_DEBUG_ON is not set
>   # CONFIG_SLUB_STATS is not set
>   CONFIG_HAVE_DEBUG_KMEMLEAK=3Dy
>   # CONFIG_DEBUG_KMEMLEAK is not set
> diff --git a/config/kernel/kernel.config.armv6l-ipfire b/config/kernel/kern=
el.config.armv6l-ipfire
> index a23906796..9d63b36ac 100644
> --- a/config/kernel/kernel.config.armv6l-ipfire
> +++ b/config/kernel/kernel.config.armv6l-ipfire
> @@ -227,7 +227,7 @@ CONFIG_PERF_EVENTS=3Dy
>   # end of Kernel Performance Events And Counters
>  =20
>   CONFIG_VM_EVENT_COUNTERS=3Dy
> -CONFIG_SLUB_DEBUG=3Dy
> +# CONFIG_SLUB_DEBUG is not set
>   # CONFIG_SLUB_MEMCG_SYSFS_ON is not set
>   # CONFIG_COMPAT_BRK is not set
>   # CONFIG_SLAB is not set
> @@ -7826,7 +7826,6 @@ CONFIG_DEBUG_MISC=3Dy
>   # CONFIG_DEBUG_RODATA_TEST is not set
>   # CONFIG_DEBUG_WX is not set
>   # CONFIG_DEBUG_OBJECTS is not set
> -# CONFIG_SLUB_DEBUG_ON is not set
>   # CONFIG_SLUB_STATS is not set
>   CONFIG_HAVE_DEBUG_KMEMLEAK=3Dy
>   # CONFIG_DEBUG_KMEMLEAK is not set
> diff --git a/config/kernel/kernel.config.i586-ipfire b/config/kernel/kernel=
.config.i586-ipfire
> index 9c49a90d8..56b40eac7 100644
> --- a/config/kernel/kernel.config.i586-ipfire
> +++ b/config/kernel/kernel.config.i586-ipfire
> @@ -235,7 +235,7 @@ CONFIG_PERF_EVENTS=3Dy
>   # end of Kernel Performance Events And Counters
>  =20
>   CONFIG_VM_EVENT_COUNTERS=3Dy
> -CONFIG_SLUB_DEBUG=3Dy
> +# CONFIG_SLUB_DEBUG is not set
>   # CONFIG_COMPAT_BRK is not set
>   # CONFIG_SLAB is not set
>   CONFIG_SLUB=3Dy
> @@ -7383,7 +7383,6 @@ CONFIG_GENERIC_PTDUMP=3Dy
>   CONFIG_PTDUMP_CORE=3Dy
>   # CONFIG_PTDUMP_DEBUGFS is not set
>   # CONFIG_DEBUG_OBJECTS is not set
> -# CONFIG_SLUB_DEBUG_ON is not set
>   # CONFIG_SLUB_STATS is not set
>   CONFIG_HAVE_DEBUG_KMEMLEAK=3Dy
>   # CONFIG_DEBUG_KMEMLEAK is not set
> diff --git a/config/kernel/kernel.config.x86_64-ipfire b/config/kernel/kern=
el.config.x86_64-ipfire
> index 0a1f67074..8247e9b48 100644
> --- a/config/kernel/kernel.config.x86_64-ipfire
> +++ b/config/kernel/kernel.config.x86_64-ipfire
> @@ -245,7 +245,7 @@ CONFIG_PERF_EVENTS=3Dy
>   # end of Kernel Performance Events And Counters
>  =20
>   CONFIG_VM_EVENT_COUNTERS=3Dy
> -CONFIG_SLUB_DEBUG=3Dy
> +# CONFIG_SLUB_DEBUG is not set
>   # CONFIG_COMPAT_BRK is not set
>   # CONFIG_SLAB is not set
>   CONFIG_SLUB=3Dy
> @@ -7249,7 +7249,6 @@ CONFIG_GENERIC_PTDUMP=3Dy
>   CONFIG_PTDUMP_CORE=3Dy
>   # CONFIG_PTDUMP_DEBUGFS is not set
>   # CONFIG_DEBUG_OBJECTS is not set
> -# CONFIG_SLUB_DEBUG_ON is not set
>   # CONFIG_SLUB_STATS is not set
>   CONFIG_HAVE_DEBUG_KMEMLEAK=3Dy
>   # CONFIG_DEBUG_KMEMLEAK is not set
>=20

--===============0089570104837620367==--