public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] suricata: 'Downdate' to 5.0.5
Date: Tue, 15 Dec 2020 17:12:15 +0100	[thread overview]
Message-ID: <49A794A5-F67F-4A75-87D2-260A1AFE7A78@ipfire.org> (raw)
In-Reply-To: <f52b7672-50c0-48f3-29e6-3a20ceb9f208@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 2226 bytes --]

Hi,

I am now convinced that the impact is bad enough that we will need to revert.

I would like to be able to release c153 before Christmas and I am not sure if upstream will be able to provide a hotfix.

-Michael

> On 14 Dec 2020, at 21:02, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> On 14.12.2020 10:33, Michael Tremer wrote:
>> Hi,
> 
> Hi,
> 
>> Thank you for submitting this patch.
>> 
>> I am not sure if I want to merge this, yet.
> 
> Yep.
> 
> Looking at the changelogs I would prefer 6.0.1, but I just wanted to
> have an alternative ready in case it was needed.
> 
>> I will consider this when we move closer to a release, but upstream didn’t provide a solution, yet.
>> 
>> I suppose it is okay if we burn through a little bit more of CPU as long as the system is secure. The overhead seems to be small enough for me to not cause any significant impact on throughput or latency.
>> 
>> Is this an acceptable benchmark for you?
> 
> For me: yes. No problem. ;-)
> 
> Best,
> Matthias
> 
>> Best,
>> -Michael
>> 
>>> On 12 Dec 2020, at 10:14, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>>> 
>>> Triggered by https://lists.ipfire.org/pipermail/development/2020-December/008868.html
>>> 
>>> Workaround for https://bugzilla.ipfire.org/show_bug.cgi?id=12548
>>> 
>>> Downgrading to 'suricata 5.0.5' bypasses Bug #12548 for now,
>>> but its only a temporary workaround...
>>> 
>>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>>> ---
>>> lfs/suricata | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/lfs/suricata b/lfs/suricata
>>> index 2871d8e7b..c5dc46af4 100644
>>> --- a/lfs/suricata
>>> +++ b/lfs/suricata
>>> @@ -24,7 +24,7 @@
>>> 
>>> include Config
>>> 
>>> -VER        = 6.0.0
>>> +VER        = 5.0.5
>>> 
>>> THISAPP    = suricata-$(VER)
>>> DL_FILE    = $(THISAPP).tar.gz
>>> @@ -44,7 +44,7 @@ objects = $(DL_FILE)
>>> 
>>> $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
>>> 
>>> -$(DL_FILE)_MD5 = bbddcf2f209930206ef21977d40120d2
>>> +$(DL_FILE)_MD5 = fe039cc4571eb56828874ddc0b71dc51
>>> 
>>> install : $(TARGET)
>>> 
>>> -- 
>>> 2.18.0
>>> 
>> 
> 


      reply	other threads:[~2020-12-15 16:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-12  9:14 Matthias Fischer
2020-12-14  9:33 ` Michael Tremer
2020-12-14 20:02   ` Matthias Fischer
2020-12-15 16:12     ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49A794A5-F67F-4A75-87D2-260A1AFE7A78@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox