public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Kernel: Block non-UID-0 profiling completely
Date: Thu, 10 Feb 2022 17:30:49 +0000	[thread overview]
Message-ID: <49da8bea-2eef-0dc4-bddc-3d381ab643e2@ipfire.org> (raw)
In-Reply-To: <92d62aa477bab6a92ac1b191b6a68947@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1972 bytes --]

Hello Arne,
hello Michael,

thanks for your replies.

Convinced there is no way around rebasing the kernel patch, I will do so and submit a
second version within the next few days. :-)

All the best,
Peter Müller


> Such .orig files are created by patch if a hunk not apply without fuzzing.
> rebase the patch to the current kernel source should help.
> 
> Arne
> 
> Am 2022-02-04 17:56, schrieb Michael Tremer:
>> Hello,
>>
>>> On 4 Feb 2022, at 13:45, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>>
>>> Hello Michael,
>>>
>>> [...]
>>>
>>>>>> #lib/modules/KVER-ipfire/build/include/linux/perf_event.h
>>>>>> +#lib/modules/KVER-ipfire/build/include/linux/perf_event.h.orig
>>>>>
>>>>> We should not install any files like this.
>>>>
>>>> Hm. I wonder where it came from. Perhaps I forgot a "./make.sh clean" after the first attempt.
>>>>
>>>> Will check and report back.
>>>
>>> after running a clean build, this file stays present. It's attached to this mail.
>>>
>>> It is odd to see this happening, as the additional "patch" command introduced by this
>>> patch does not differ from those already present in the kernel's LFS file, except for
>>> the patch file itself.
>>
>> If the patch doesn’t match exactly, patch will create backup files so
>> that you can fix anything manually if things broke.
>>
>> What you can do is either to rediff the patch that it applies cleanly,
>> or you can use this option:
>>
>>        --no-backup-if-mismatch
>>
>>           Do not back up a file if the patch does not match the file
>>           exactly and if backups are not otherwise requested.  This is
>>           the default if patch  is conforming to POSIX.
>>
>> This should however be the default.
>>
>> -Michael
>>
>>>
>>> Can you give me any hint on where to look next?
>>>
>>> Thanks, and best regards,
>>> Peter Müller<perf_event.h.orig>
> 
> 
> 
> 
> 

  reply	other threads:[~2022-02-10 17:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ecedf2d8-f7b3-788f-40bc-5dd18de3597f@ipfire.org>
2022-02-04 13:45 ` Peter Müller
2022-02-04 16:56   ` Michael Tremer
2022-02-09 21:08     ` Arne Fitzenreiter
2022-02-10 17:30       ` Peter Müller [this message]
2022-01-30 16:59 Peter Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49da8bea-2eef-0dc4-bddc-3d381ab643e2@ipfire.org \
    --to=peter.mueller@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox