From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] First Patch from me. Hope this Ok so. Socat, filan and procan. Date: Tue, 04 Aug 2020 10:34:21 +0100 Message-ID: <4C311473-95D1-42DC-B1FE-0DA27F49D47D@ipfire.org> In-Reply-To: <005801d6699f$2330b700$69922500$@v16.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4418441146429331969==" List-Id: --===============4418441146429331969== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Marcel, > On 3 Aug 2020, at 15:05, smooky(a)v16.de wrote: >=20 > Hi Michael, >=20 > I need this package for e.g. the script here > > https://www.roessner-network-solutions.com/kvm-manage <. Furthermore, I saw > in the IPFire forum that there was someone who would like to see it here > > https://community.ipfire.org/t/missing-socat-command-in-ipfire/2584 <. I > also made it available in the forum, which was then removed. Yes, the problem that that brings is that you most likely only built it for o= ne architecture when IPFire supports four. And people who download that packa= ge will never see any updates. Even if you upload them, they won=E2=80=99t = =E2=80=9Ctouch a running system=E2=80=9D. > It was > explained to me that it is not welcome when unsigned packages are made > available and that I should rather create a patch so that everyone gets > something out of it and send it to the mailing list. Correct! > After Peter M=C3=BCller > kindly explained to me with a lot of patience how it worked, I simply tried > my luck. And tada, there is the patch. Cool. This looks fine for me: Reviewed-by: Michael Tremer Well done. I would ask you to pledge to post updates for this package whenever upstream = releases something new. -Michael >=20 > best regards >=20 > Marcel Follert >=20 >=20 > -----Urspr=C3=BCngliche Nachricht----- > Von: Michael Tremer =20 > Gesendet: Montag, 3. August 2020 13:58 > An: smooky(a)v16.de > Cc: development(a)lists.ipfire.org > Betreff: Re: [PATCH] First Patch from me. Hope this Ok so. Socat, filan and > procan. >=20 > Hello Marcel, >=20 > Thank you for your patch. >=20 > What is the use-case for this? Why do you need this packaged in IPFire? >=20 > Best, > -Michael >=20 >> On 30 Jul 2020, at 23:22, smooky(a)v16.de wrote: >>=20 >> Signed-off-by: Marcel Follert (Smooky) >> --- >> config/rootfiles/packages/socat | 4 ++ >> lfs/socat | 85 > +++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 89 insertions(+) >> create mode 100644 config/rootfiles/packages/socat >> create mode 100644 lfs/socat >>=20 >> diff --git a/config/rootfiles/packages/socat > b/config/rootfiles/packages/socat >> new file mode 100644 >> index 000000000..6a984e892 >> --- /dev/null >> +++ b/config/rootfiles/packages/socat >> @@ -0,0 +1,4 @@ >> +usr/bin/filan >> +usr/bin/procan >> +usr/bin/socat >> +#usr/share/man/man1/socat.1 >> diff --git a/lfs/socat b/lfs/socat >> new file mode 100644 >> index 000000000..6c3ffd5c1 >> --- /dev/null >> +++ b/lfs/socat >> @@ -0,0 +1,85 @@ >>=20 > +########################################################################### > #### >> +# > # >> +# IPFire.org - A linux based firewall > # >> +# Copyright (C) 2007-2020 IPFire Team > # >> +# > # >> +# This program is free software: you can redistribute it and/or modify > # >> +# it under the terms of the GNU General Public License as published by > # >> +# the Free Software Foundation, either version 3 of the License, or > # >> +# (at your option) any later version. > # >> +# > # >> +# This program is distributed in the hope that it will be useful, > # >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of > # >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > # >> +# GNU General Public License for more details. > # >> +# > # >> +# You should have received a copy of the GNU General Public License > # >> +# along with this program. If not, see . > # >> +# > # >>=20 > +########################################################################### > #### >> + >> + >>=20 > +########################################################################### > #### >> +# Definitions >>=20 > +########################################################################### > #### >> + >> +include Config >> + >> +VER =3D 1.7.3.4 >> + >> +THISAPP =3D socat-$(VER) >> +DL_FILE =3D $(THISAPP).tar.gz >> +DL_FROM =3D $(URL_IPFIRE) >> +DIR_APP =3D $(DIR_SRC)/$(THISAPP) >> +TARGET =3D $(DIR_INFO)/$(THISAPP) >> +PROG =3D socat >> +PAK_VER =3D 1 >> + >> +DEPS =3D=20 >> + >>=20 > +########################################################################### > #### >> +# Top-level Rules >>=20 > +########################################################################### > #### >> + >> +objects =3D $(DL_FILE) >> + >> +$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) >> + >> +$(DL_FILE)_MD5 =3D c9e71d0136c88a01d6fd30a13a3936ed >> + >> +install : $(TARGET) >> + >> +check : $(patsubst %,$(DIR_CHK)/%,$(objects)) >> + >> +download :$(patsubst %,$(DIR_DL)/%,$(objects)) >> + >> +md5 : $(subst %,%_MD5,$(objects)) >> + >> +dist:=20 >> + @$(PAK) >> + >>=20 > +########################################################################### > #### >> +# Downloading, checking, md5sum >>=20 > +########################################################################### > #### >> + >> +$(patsubst %,$(DIR_CHK)/%,$(objects)) : >> + @$(CHECK) >> + >> +$(patsubst %,$(DIR_DL)/%,$(objects)) : >> + @$(LOAD) >> + >> +$(subst %,%_MD5,$(objects)) : >> + @$(MD5) >> + >>=20 > +########################################################################### > #### >> +# Installation Details >>=20 > +########################################################################### > #### >> + >> +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >> + @$(PREBUILD) >> + @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar xzf $(DIR_DL)/$(DL_FILE) >> + cd $(DIR_APP) && ./configure --prefix=3D/usr >> + cd $(DIR_APP) && make $(MAKETUNING) $(EXTRA_MAKE) >> + cd $(DIR_APP) && make install >> + @rm -rf $(DIR_APP) >> + @$(POSTBUILD) >> --=20 >> 2.12.2 >>=20 >=20 >=20 >=20 --===============4418441146429331969==--