From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: OpenVPN cipher negotiation patch set Date: Mon, 18 Mar 2024 16:33:43 +0000 Message-ID: <4CAF992D-0C4D-4B75-97E2-CE24572D271B@ipfire.org> In-Reply-To: <0341a854-9743-4372-85d5-50de3cc84f2a@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3961664911544702733==" List-Id: --===============3961664911544702733== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Thank you very much for sending this over. I will have a look at it shortly. > On 17 Mar 2024, at 11:35, Adolf Belka wrote: >=20 > Hi Michael, >=20 > I am afraid I don't have a patch set. It is just a single diff change. >=20 > I took Erik's original patch set and applied it to the latest ovpnmain.cgi = version at that time and then removed some of the items that I decided could = wait till later or were not needed. >=20 > This created a single diff file, which I was able to apply and test out to = confirm it did what I expected it to do, which it seemed to do. >=20 > The next step I then had intended to do was to break that single diff into = multiple patches but I found this very difficult to do as I could not easily = figure out which bits needed to go together in different patches. Trying to u= nderstand all the changes and what each were related to I struggled to make s= ense of. >=20 > My next step was therefore going to be to go back to an unmodified ovpnmain= .cgi file and make the changes a step at a time, to match what I had previous= ly done and therefore end up with a patch set of small self consistent change= s. >=20 > However to do this I had to go back to the start and figure out which of Er= ik's changes to apply and what parts of those changes and every time I did so= mething else in IPFire for a week or so I was having to go back to square one= in trying to remember what I had been going to do next. >=20 > The diff patch file I created is at >=20 > https://git.ipfire.org/?p=3Dpeople/bonnietwin/ipfire-2.x.git;a=3Dcommit;h= =3D4fbf17f4a10fbf2a0ddeae1aa436cf26f6b3a035 >=20 > Hopefully you can use this as a basis to extract just the bits needed for t= he cipher negotiation. >=20 > I will also go back and start again to work on it but focus on it without d= iverting to anything else, after I have dealt with the wsdd patch modificatio= n. >=20 > Regards, >=20 > Adolf. >=20 --===============3961664911544702733==--