From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH v3 5/5] services.cgi: add link to addon config if ui exists for it
Date: Wed, 26 Oct 2022 15:37:10 +0100
Message-ID: <4D6B1C83-01E8-4AE6-813B-5D3B456C1F4F@ipfire.org>
In-Reply-To: <20221011220157.17385-6-robin.roevens@disroot.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2622028309289332872=="
List-Id: <development.lists.ipfire.org>

--===============2622028309289332872==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 11 Oct 2022, at 23:01, Robin Roevens <robin.roevens(a)disroot.org> wrote:
>=20
> * If a cgi file exists with the same name as an addon, the
>  displayed service will be a link to that cgi file.
>=20
> Signed-off-by: Robin Roevens <robin.roevens(a)disroot.org>
> ---
> html/cgi-bin/services.cgi | 4 ++++
> 1 file changed, 4 insertions(+)
>=20
> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi
> index 4b379251e..14ed01c50 100644
> --- a/html/cgi-bin/services.cgi
> +++ b/html/cgi-bin/services.cgi
> @@ -192,6 +192,10 @@ END
>=20
> 				# Add addon name to displayname of service if servicename differs from =
addon
> 				my $displayname =3D ($pak ne $service) ? "$service ($pak)" : $service;
> +				if ( -e "/srv/web/ipfire/cgi-bin/$pak.cgi" ) {
> +					$displayname =3D ($pak ne $service) ? "$service (<a href=3D\'$pak.cgi=
\'>$pak</a>)" : "<a href=3D\'$pak.cgi\'>$service</a>";
> +				}=20
> +
> 				print "<td align=3D'left' $col width=3D'31%'>$displayname</td> ";
>=20
> 				my $status =3D isautorun($pak,$service,$col);
> --=20
> 2.37.3
>=20
>=20
> --=20
> Dit bericht is gescanned op virussen en andere gevaarlijke
> inhoud door MailScanner en lijkt schoon te zijn.
>=20


--===============2622028309289332872==--