From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [RFC PATCH] Core Update 163: Abort update.sh in case an uninitialised variable is found
Date: Sat, 04 Dec 2021 12:46:16 +0000 [thread overview]
Message-ID: <4ED96E97-2724-40CC-A90A-49401A04DA4E@ipfire.org> (raw)
In-Reply-To: <9384fc32-2895-c585-ac06-d96ccc5668b7@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
Why?
> On 3 Dec 2021, at 17:37, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> This should never happen anyways, but better be safe than sorry.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> config/rootfiles/core/163/update.sh | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/config/rootfiles/core/163/update.sh b/config/rootfiles/core/163/update.sh
> index e51dbf0b3..c1f23f25e 100644
> --- a/config/rootfiles/core/163/update.sh
> +++ b/config/rootfiles/core/163/update.sh
> @@ -24,6 +24,9 @@
> . /opt/pakfire/lib/functions.sh
> /usr/local/bin/backupctrl exclude >/dev/null 2>&1
>
> +# Abort in case of uninitialised variables
> +set -u
> +
> core=163
>
> exit_with_error() {
> --
> 2.26.2
prev parent reply other threads:[~2021-12-04 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 17:37 Peter Müller
2021-12-04 12:46 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED96E97-2724-40CC-A90A-49401A04DA4E@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox