* [RFC PATCH] Core Update 163: Abort update.sh in case an uninitialised variable is found
@ 2021-12-03 17:37 Peter Müller
2021-12-04 12:46 ` Michael Tremer
0 siblings, 1 reply; 2+ messages in thread
From: Peter Müller @ 2021-12-03 17:37 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
This should never happen anyways, but better be safe than sorry.
Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
config/rootfiles/core/163/update.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/config/rootfiles/core/163/update.sh b/config/rootfiles/core/163/update.sh
index e51dbf0b3..c1f23f25e 100644
--- a/config/rootfiles/core/163/update.sh
+++ b/config/rootfiles/core/163/update.sh
@@ -24,6 +24,9 @@
. /opt/pakfire/lib/functions.sh
/usr/local/bin/backupctrl exclude >/dev/null 2>&1
+# Abort in case of uninitialised variables
+set -u
+
core=163
exit_with_error() {
--
2.26.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC PATCH] Core Update 163: Abort update.sh in case an uninitialised variable is found
2021-12-03 17:37 [RFC PATCH] Core Update 163: Abort update.sh in case an uninitialised variable is found Peter Müller
@ 2021-12-04 12:46 ` Michael Tremer
0 siblings, 0 replies; 2+ messages in thread
From: Michael Tremer @ 2021-12-04 12:46 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
Why?
> On 3 Dec 2021, at 17:37, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> This should never happen anyways, but better be safe than sorry.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> config/rootfiles/core/163/update.sh | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/config/rootfiles/core/163/update.sh b/config/rootfiles/core/163/update.sh
> index e51dbf0b3..c1f23f25e 100644
> --- a/config/rootfiles/core/163/update.sh
> +++ b/config/rootfiles/core/163/update.sh
> @@ -24,6 +24,9 @@
> . /opt/pakfire/lib/functions.sh
> /usr/local/bin/backupctrl exclude >/dev/null 2>&1
>
> +# Abort in case of uninitialised variables
> +set -u
> +
> core=163
>
> exit_with_error() {
> --
> 2.26.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-04 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-03 17:37 [RFC PATCH] Core Update 163: Abort update.sh in case an uninitialised variable is found Peter Müller
2021-12-04 12:46 ` Michael Tremer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox