From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenVPN: mark CBC ciphers as weak in WebUI
Date: Mon, 10 Jun 2019 19:47:17 +0100
Message-ID: <4FDE0AC7-76CB-4B9A-A5D3-E77EE9DFED5C@ipfire.org>
In-Reply-To: <5c5b7f38-c7c5-2c35-5f46-b4aca620d54b@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8789554871931985994=="
List-Id: <development.lists.ipfire.org>

--===============8789554871931985994==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

I think I can ACK this although we definitely should change the default. I ha=
ve raised that a couple of times before.

I also do not like having a very long list of ciphers that are weak. There ar=
e not too many left which are =E2=80=9Cstrong=E2=80=9D. But yeah, what can yo=
u do?

I will wait for Erik to ack this, too.

-Michael

> On 10 Jun 2019, at 19:36, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> CBC a vulnerable to a bunch of vulnerabilities (MAC-then-encrypt,
> Padding Oracle, ...) which were considered to be an academic threat.
>=20
> However, research such as https://blog.qualys.com/technology/2019/04/22/zom=
bie-poodle-and-goldendoodle-vulnerabilities
> indicates these issues are more serious. Thereof, this patch marks
> remaining CBC ciphers (AES-CBC, SEED-CBC and CAMELLIA-CBC) as "weak";
> they should be avoided in future.
>=20
> It does not change the default, which is AES-256-CBC for compatibility
> reasons. Whether this can be changed or not needs to be discussed.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> Cc: Erik Kapfer <ummeegge(a)ipfire.org>
> ---
> html/cgi-bin/ovpnmain.cgi | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>=20
> diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> index 439390228..ae1fe8e77 100644
> --- a/html/cgi-bin/ovpnmain.cgi
> +++ b/html/cgi-bin/ovpnmain.cgi
> @@ -2,7 +2,7 @@
> ###########################################################################=
####
> #                                                                          =
   #
> # IPFire.org - A linux based firewall                                      =
   #
> -# Copyright (C) 2007-2014  IPFire Team  <info(a)ipfire.org>               =
      #
> +# Copyright (C) 2007-2019  IPFire Team  <info(a)ipfire.org>               =
      #
> #                                                                          =
   #
> # This program is free software: you can redistribute it and/or modify     =
   #
> # it under the terms of the GNU General Public License as published by     =
   #
> @@ -4516,7 +4516,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
>     $selected{'DCIPHER'}{'CAST5-CBC'} =3D '';
>     $selected{'DCIPHER'}{'BF-CBC'} =3D '';
>     $selected{'DCIPHER'}{'DES-CBC'} =3D '';
> -    # If no cipher has been chossen yet, select
> +    # If no cipher has been chosen yet, select
>     # the old default (AES-256-CBC) for compatiblity reasons.
>     if ($cgiparams{'DCIPHER'} eq '') {
> 	$cgiparams{'DCIPHER'} =3D 'AES-256-CBC';
> @@ -4668,13 +4668,13 @@ if ($cgiparams{'TYPE'} eq 'net') {
> 				<option value=3D'AES-256-GCM'		$selected{'DCIPHER'}{'AES-256-GCM'}>AES-=
GCM (256 $Lang::tr{'bit'})</option>
> 				<option value=3D'AES-192-GCM'		$selected{'DCIPHER'}{'AES-192-GCM'}>AES-=
GCM (192 $Lang::tr{'bit'})</option>
> 				<option value=3D'AES-128-GCM'		$selected{'DCIPHER'}{'AES-128-GCM'}>AES-=
GCM (128 $Lang::tr{'bit'})</option>
> -				<option value=3D'CAMELLIA-256-CBC'	$selected{'DCIPHER'}{'CAMELLIA-256-=
CBC'}>CAMELLIA-CBC (256 $Lang::tr{'bit'})</option>
> -				<option value=3D'CAMELLIA-192-CBC'	$selected{'DCIPHER'}{'CAMELLIA-192-=
CBC'}>CAMELLIA-CBC (192 $Lang::tr{'bit'})</option>
> -				<option value=3D'CAMELLIA-128-CBC'	$selected{'DCIPHER'}{'CAMELLIA-128-=
CBC'}>CAMELLIA-CBC (128 $Lang::tr{'bit'})</option>
> -				<option value=3D'AES-256-CBC' 	 	$selected{'DCIPHER'}{'AES-256-CBC'}>A=
ES-CBC (256 $Lang::tr{'bit'}, $Lang::tr{'default'})</option>
> -				<option value=3D'AES-192-CBC' 	 	$selected{'DCIPHER'}{'AES-192-CBC'}>A=
ES-CBC (192 $Lang::tr{'bit'})</option>
> -				<option value=3D'AES-128-CBC' 	 	$selected{'DCIPHER'}{'AES-128-CBC'}>A=
ES-CBC (128 $Lang::tr{'bit'})</option>
> -				<option value=3D'SEED-CBC' 			$selected{'DCIPHER'}{'SEED-CBC'}>SEED-CB=
C (128 $Lang::tr{'bit'})</option>
> +				<option value=3D'CAMELLIA-256-CBC'	$selected{'DCIPHER'}{'CAMELLIA-256-=
CBC'}>CAMELLIA-CBC (256 $Lang::tr{'bit'}, $Lang::tr{'vpn weak'})</option>
> +				<option value=3D'CAMELLIA-192-CBC'	$selected{'DCIPHER'}{'CAMELLIA-192-=
CBC'}>CAMELLIA-CBC (192 $Lang::tr{'bit'}, $Lang::tr{'vpn weak'})</option>
> +				<option value=3D'CAMELLIA-128-CBC'	$selected{'DCIPHER'}{'CAMELLIA-128-=
CBC'}>CAMELLIA-CBC (128 $Lang::tr{'bit'}, $Lang::tr{'vpn weak'})</option>
> +				<option value=3D'AES-256-CBC' 	 	$selected{'DCIPHER'}{'AES-256-CBC'}>A=
ES-CBC (256 $Lang::tr{'bit'}, $Lang::tr{'default'}, $Lang::tr{'vpn weak'})</o=
ption>
> +				<option value=3D'AES-192-CBC' 	 	$selected{'DCIPHER'}{'AES-192-CBC'}>A=
ES-CBC (192 $Lang::tr{'bit'}, $Lang::tr{'vpn weak'})</option>
> +				<option value=3D'AES-128-CBC' 	 	$selected{'DCIPHER'}{'AES-128-CBC'}>A=
ES-CBC (128 $Lang::tr{'bit'}, $Lang::tr{'vpn weak'})</option>
> +				<option value=3D'SEED-CBC' 			$selected{'DCIPHER'}{'SEED-CBC'}>SEED-CB=
C (128 $Lang::tr{'bit'}, $Lang::tr{'vpn weak'})</option>
> 				<option value=3D'DES-EDE3-CBC'	 	$selected{'DCIPHER'}{'DES-EDE3-CBC'}>D=
ES-EDE3-CBC (192 $Lang::tr{'bit'}, $Lang::tr{'vpn weak'})</option>
> 				<option value=3D'DESX-CBC' 			$selected{'DCIPHER'}{'DESX-CBC'}>DESX-CBC=
 (192 $Lang::tr{'bit'}, $Lang::tr{'vpn weak'})</option>
> 				<option value=3D'DES-EDE-CBC' 		$selected{'DCIPHER'}{'DES-EDE-CBC'}>DES=
-EDE-CBC (128 $Lang::tr{'bit'}, $Lang::tr{'vpn weak'})</option>
> @@ -5052,7 +5052,7 @@ END
> 		}
>     }
>=20
> -#default setzen
> +# set default values
>     if ($cgiparams{'DCIPHER'} eq '') {
> 		$cgiparams{'DCIPHER'} =3D  'AES-256-CBC';
>     }
> --=20
> 2.16.4


--===============8789554871931985994==--