On 11.09.2019 17:08, Michael Tremer wrote:
> Hi,
> 
> We would normally add a link to the rootfile of collectd so that the whole package is being shipped again. That is the easiest option and usually does not waste a lot of space.

Ok.

Besides:
I built the last updates on Core 135 to test them here as quickly as
possible.

To make things look better, I'll send new patches for 'iptables 1.8.3' /
'collectd' and 'iproute 5.2.0'- based on 'next'.

Best,
Matthias

> Best,
> -Michael
> 
>> On 10 Sep 2019, at 19:33, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>> 
>> Hi,
>> 
>> during testing of 'iptables 1.8.3' - see
>> https://patchwork.ipfire.org/patch/2401/ I found that the graphs for
>> "firewallhits" in "Network (other)" stayed emtpy with "-nan Bps".
>> 
>> During restart 'makegraphs' complained about a missing lib for 'iptables':
>> 
>> root(a)ipfire: /var # /etc/init.d/collectd restart
>> Stopping Collection daemon...                                   [  OK  ]
>> Mounting RRD ramdisk...                                         [  OK  ]
>> Starting Collection daemon...
>> lt_dlopen ("/usr/lib/collectd/iptables.so") failed: file not found. The
>> most common cause for this problem are missing dependencies. Use ldd(1)
>> to check the dependencies of the plugin / shared object.
>> Unable to load plugin iptables.                                 [  OK  ]
>> 
>> 'ldd' showed 'not found', because during updating 'iptables' the
>> 'libip4tc' and 'libip6tc'-symlinks were changed, but
>> '/usr/lib/collectd/iptables.so' wasn't updated:
>> 
>> root(a)ipfire: /usr/lib/collectd # ldd /usr/lib/collectd/iptables.so
>>        linux-gate.so.1 (0xb7f42000)
>>        libiptc.so.0 => /lib/libiptc.so.0 (0xb7f2b000)
>>        libip4tc.so.0 => not found
>>        libip6tc.so.0 => not found
>>        libc.so.6 => /lib/libc.so.6 (0xb7d61000)
>>        libip4tc.so.2 => /lib/libip4tc.so.2 (0xb7d58000)
>>        libip6tc.so.2 => /lib/libip6tc.so.2 (0xb7d4f000)
>>        /lib/ld-linux.so.2 (0xb7f44000)
>> 
>> After updating '/usr/lib/collectd/iptables.so' to the current build it
>> didn't complain anymore:
>> 
>> root(a)ipfire: /usr/lib/collectd # ldd iptables.so
>>        linux-gate.so.1 (0xb7f8a000)
>>        libiptc.so.0 => /lib/libiptc.so.0 (0xb7f72000)
>>        libip4tc.so.2 => /lib/libip4tc.so.2 (0xb7f69000)
>>        libip6tc.so.2 => /lib/libip6tc.so.2 (0xb7f60000)
>>        libc.so.6 => /lib/libc.so.6 (0xb7d96000)
>>        /lib/ld-linux.so.2 (0xb7f8c000)
>> 
>> 'makegraphs' restarted without errors and "firewallhits graph" are
>> showing numbers again. So far, so good.
>> 
>> But: how do we ship this update for 'collectd' the best way?
>> 
>> Should we update ALL libs for 'collectd'?
>> 
>> I checked the other libs, and besides 'iptables.so', 'ldd' showed no
>> more 'not found'-errors.
>> 
>> Any hints?
>> 
>> Best,
>> Matthias
> 
>