From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCHv2 07/12] extrahd.cgi: Re-order sanity check logic
Date: Wed, 02 Aug 2023 13:57:35 +0200
Message-ID: <4c1e0e9f-b62c-d9e3-ffc5-e46490ade2a8@ipfire.org>
In-Reply-To: <20230801154839.2373-7-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5508931442079908155=="
List-Id: <development.lists.ipfire.org>

--===============5508931442079908155==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>


Am 01.08.2023 um 17:48 schrieb Stefan Schantl:
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>   html/cgi-bin/extrahd.cgi | 49 +++++++++++++++++++++-------------------
>   1 file changed, 26 insertions(+), 23 deletions(-)
>=20
> diff --git a/html/cgi-bin/extrahd.cgi b/html/cgi-bin/extrahd.cgi
> index bb84ef77c..de5f26d0e 100644
> --- a/html/cgi-bin/extrahd.cgi
> +++ b/html/cgi-bin/extrahd.cgi
> @@ -98,28 +98,7 @@ $extrahdsettings{'UUID'} =3D '';
>   ## Add a new device.
>   #
>   if ($extrahdsettings{'ACTION'} eq $Lang::tr{'add'}) {
> -	# Open device file for reading.
> -	open( FILE, "< $devicefile" ) or die "Unable to read $devicefile";
> -	my @devices =3D <FILE>;
> -	close FILE;
> -
> -	# Loop through the entries line-by-line.
> -	foreach my $entry (sort @devices) {
> -		# Split the line into pieces and assign nice variables.
> -		my ($uuid, $fs, $path) =3D split( /\;/, $entry );
> -
> -		# Check if the path is allready used.
> -		if ( "$extrahdsettings{'PATH'}" eq "$path" ) {
> -			$errormessage =3D "$Lang::tr{'extrahd you cant mount'} $extrahdsettings=
{'DEVICE'} $Lang::tr{'extrahd to'} $extrahdsettings{'PATH'}$Lang::tr{'extrahd=
 because there is already a device mounted'}.";
> -		}
> -
> -		# Check if the uuid is allready used.
> -		if ("$extrahdsettings{'DEVICE'} eq $uuid") {
> -			$errormessage =3D "$extrahdsettings{'DEVICE'} is allready mounted.";
> -		}
> -	}
> -
> -	# Check if a valid mount path has been choosen.
> +	# Check if a valid mount path has been choosen.
>   	unless(&is_valid_dir("$extrahdsettings{'PATH'}")) {
>   		$errormessage =3D "$Lang::tr{'extrahd you cant mount'} $extrahdsettings=
{'DEVICE'} $Lang::tr{'extrahd to root'}.";
>   	}
> @@ -129,7 +108,31 @@ if ($extrahdsettings{'ACTION'} eq $Lang::tr{'add'}) {
>   		$errormessage =3D "$Lang::tr{'extrahd you cant mount'} $extrahdsettings=
{'DEVICE'} $Lang::tr{'extrahd to'} $extrahdsettings{'PATH'}$Lang::tr{'extrahd=
 because there is already a device mounted'}.";
>   	}
>  =20
> -	# Check if there was an error message.
> +	# Check against may previously configured drives.
> +	unless ($errormessage) {
> +		# Open device file for reading.
> +		open( FILE, "< $devicefile" ) or die "Unable to read $devicefile";
> +		my @devices =3D <FILE>;
> +		close FILE;
> +
> +		# Loop through the entries line-by-line.
> +		foreach my $entry (sort @devices) {
> +			# Split the line into pieces and assign nice variables.
> +			my ($uuid, $fs, $path) =3D split( /\;/, $entry );
> +
> +			# Check if the path is allready used.
> +			if ( "$extrahdsettings{'PATH'}" eq "$path" ) {
> +				$errormessage =3D "$Lang::tr{'extrahd you cant mount'} $extrahdsetting=
s{'DEVICE'} $Lang::tr{'extrahd to'} $extrahdsettings{'PATH'}$Lang::tr{'extrah=
d because there is already a device mounted'}.";
> +			}
> +
> +			# Check if the uuid is allready used.
> +			if ("$extrahdsettings{'DEVICE'} eq $uuid") {
> +				$errormessage =3D "$extrahdsettings{'DEVICE'} is allready mounted.";
> +			}
> +		}
> +	}
> +
> +	# Go further if there was no error message.
>   	unless($errormessage) {
>   		# Re-open the device file for writing.
>   		open(FILE, ">> $devicefile" ) or die "Unable to write $devicefile";

--===============5508931442079908155==--