From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] ids-functions.pl: Fixes bug#13203 - snort community rules
 not extracted
Date: Tue, 01 Aug 2023 12:10:31 +0200
Message-ID: <4e2ba315-687a-96a7-7b0d-eee260be49d3@ipfire.org>
In-Reply-To: <20230731204617.1411345-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7001071805968142514=="
List-Id: <development.lists.ipfire.org>

--===============7001071805968142514==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 31.07.2023 um 22:46 schrieb Adolf Belka:
> - The snort top level directory in the archive has been changed from commun=
ity.rules
>     to snort3-community.rules so the regex no longer finds the tarball to e=
xtract.
> - Modified the regex to include the current snort naming for the top level =
archive directory
>=20
> Fixes: Bug#13203
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   config/cfgroot/ids-functions.pl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/config/cfgroot/ids-functions.pl b/config/cfgroot/ids-functions=
.pl
> index d97431b4a..f2b2ffc58 100644
> --- a/config/cfgroot/ids-functions.pl
> +++ b/config/cfgroot/ids-functions.pl
> @@ -572,7 +572,7 @@ sub extractruleset ($) {
>   			# Handle rules files.
>   			} elsif ($file =3D~ m/\.rules$/) {
>   				# Skip rule files which are not located in the rules directory or arc=
hive root.
> -				next unless(($packed_file =3D~ /^rules\//) || ($packed_file =3D~ /^$pr=
ovider-rules\//) || ($packed_file !~ /\//));
> +				next unless(($packed_file =3D~ /^rules\//) || ($packed_file =3D~ /^$pr=
ovider-rules\//) || ($packed_file =3D~ /^snort3-$provider-rules\//) || ($pack=
ed_file !~ /\//));
>  =20
>   				# Skip deleted.rules.
>   				#

--===============7001071805968142514==--