From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Simmons <mbatranch@gmail.com>
To: development@lists.ipfire.org
Subject: Re: [PATCH] tor: Fix tor permissions if presant via update.sh
Date: Mon, 10 Jun 2019 13:36:37 -0500
Message-ID: <4e444646-a57f-1998-56ca-83c350d4b8ca@gmail.com>
In-Reply-To: <16323d1c-c9d0-4675-136c-cdd075e3a0e0@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0699096333560023630=="
List-Id: <development.lists.ipfire.org>

--===============0699096333560023630==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 6/10/19 1:12 PM, Peter M=C3=BCller wrote:
> Hello Michael,
>=20
> as mentioned in https://bugzilla.ipfire.org/show_bug.cgi?id=3D12088#c11 ,
> the "install.sh" script of the Tor addon contains all required steps.
>=20
> Since "update.sh" calls "install.sh" at the end of the file, everything
> should be fine after an update as well - which is not. However, due to
> this, I do not think putting it into "update.sh" makes sense either.
>=20
> Thanks, and best regards,
> Peter M=C3=BCller
>=20
> Michael Tremer:
>> Hi,
>>
>> Thanks for sending in that patch.
>>
>> But I think instead of doing this in the Core Update, this change should b=
e applied in the tor update scripts.
>>
>> -Michael
>>
>>> On 10 Jun 2019, at 12:36, Erik Kapfer <ummeegge(a)ipfire.org> wrote:
>>>
>>> Signed-off-by: Erik Kapfer <ummeegge(a)ipfire.org>
>>> ---
>>> config/rootfiles/core/133/update.sh | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/config/rootfiles/core/133/update.sh b/config/rootfiles/core/=
133/update.sh
>>> index a05ad0741..3ecb5651b 100644
>>> --- a/config/rootfiles/core/133/update.sh
>>> +++ b/config/rootfiles/core/133/update.sh
>>> @@ -71,6 +71,11 @@ sudo -u nobody /srv/web/ipfire/cgi-bin/vpnmain.cgi
>>> /etc/init.d/squid start
>>> /etc/init.d/collectd restart
>>>
>>> +# Set new permissions for tor
>>> +if [ -d "/var/lib/tor" ]; then
>>> +    chown -R tor:tor /var/lib/tor
>>> +fi
>>> +
>>> # Finish
>>> /etc/init.d/fireinfo start
>>> sendprofile
>>> --=20
>>> 2.12.2
>>>
>>
>=20

Perhaps the restore_backup in install.sh is undoing the ownership?

p.

--===============0699096333560023630==--