From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Problem with trying to build qemu-9.0.2 - it requires dtc for all
 architectures
Date: Tue, 03 Sep 2024 21:06:24 +0200
Message-ID: <4f14ddd0-4f1c-4be5-8973-bcf0389861bf@ipfire.org>
In-Reply-To: <8f85d745-666f-48f4-abc2-497d2601b0a9@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6421427673273227604=="
List-Id: <development.lists.ipfire.org>

--===============6421427673273227604==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi All,

On 03/09/2024 15:25, Adolf Belka wrote:
> Hi Michael,
>
> On 03/09/2024 09:24, Michael Tremer wrote:
>> Hello Adolf,
>>
>> Yes, you can make those changes.
>>
>> dtc is the device tree compiler and it should be quick to build. We just d=
idn=E2=80=99t do that since we didn=E2=80=99t have any use for it apart from =
aarch64.
>>
>> Move it wherever you want. It should not have any further dependencies. We=
 can build it for all architectures.
>
> I did that and qemu found libfdt but then said that it was too old and that=
 a min of 1.5.1 was required but the updated version of dtc I had built was v=
ersion 1.7.1
>
I have found the section in meson.build where it checks for the fdt library a=
nd it seems to me that the code says that if the system fdt is being used the=
n say that it is too old. I can't see any actual check of the version number =
of libfdt.

Can you have a check through this following code and see if my interpretation=
 is correct or if I have just misunderstood how the code is supposed to be wo=
rking.

It also looks like the check for the fdt code being internal has not been rem=
oved from it even though dtc is no longer bundled with qemu.


fdt =3D not_found
fdt_opt =3D get_option('fdt')
if fdt_required.length() > 0 or fdt_opt =3D=3D 'enabled'
 =C2=A0 if fdt_opt =3D=3D 'disabled'
 =C2=A0=C2=A0=C2=A0 error('fdt disabled but required by targets ' + ', '.join=
(fdt_required))
 =C2=A0 endif

 =C2=A0 if fdt_opt in ['enabled', 'auto', 'system']
 =C2=A0=C2=A0=C2=A0 if get_option('wrap_mode') =3D=3D 'nodownload'
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fdt_opt =3D 'system'
 =C2=A0=C2=A0=C2=A0 endif
 =C2=A0=C2=A0=C2=A0 fdt =3D cc.find_library('fdt', required: fdt_opt =3D=3D '=
system')
 =C2=A0=C2=A0=C2=A0 if fdt.found() and cc.links('''
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #include <libfdt.h>
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #include <libfdt_env.h>
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int main(void) { fdt_find_max_phandle(N=
ULL, NULL); return 0; }''',
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dependencies: fdt)
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fdt_opt =3D 'system'
 =C2=A0=C2=A0=C2=A0 elif fdt_opt =3D=3D 'system'
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 error('system libfdt requested, but it =
is too old (1.5.1 or newer required)')
 =C2=A0=C2=A0=C2=A0 else
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fdt_opt =3D 'internal'
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fdt =3D not_found
 =C2=A0=C2=A0=C2=A0 endif
 =C2=A0 endif
 =C2=A0 if not fdt.found()
 =C2=A0=C2=A0=C2=A0 assert(fdt_opt =3D=3D 'internal')
 =C2=A0=C2=A0=C2=A0 libfdt_proj =3D subproject('dtc', required: true,
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 default_options: ['tools=3Dfalse', 'yaml=3Ddisabled',
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'python=3Ddisabled', 'def=
ault_library=3Dstatic'])
 =C2=A0=C2=A0=C2=A0 fdt =3D libfdt_proj.get_variable('libfdt_dep')
 =C2=A0 endif
else
 =C2=A0 fdt_opt =3D 'disabled'
endif


> It looks like qemu can correctly detect the presence of libfdt but not the =
version number.
>
> I have raised this as an issue in the qemu gitlab site.
>
> Version 9.0.0 still had the dtc subproject included in the source tarball, =
so I am currently building that and have left the IPFire dtc where it was for=
 the moment.
>
> This will still update qemu by 11 version numbers.
>
> I will wait to see what response I get back from the qemu team for updating=
 to 9.0.2
>
> Regards,
> Adolf.
>
>>
>> -Michael
>>
>>> On 2 Sep 2024, at 19:46, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>>
>>> Hi All,
>>>
>>> I am trying to do an update of the qemu package.
>>>
>>> It is failing for a missing fdt library which it says is required by targ=
ets x86_64-softmmu, aarch64-softmmu and riscv64-softmmu.
>>>
>>> The previous version that we currently have, 8.1.2 has a bundled dtc whic=
h includes the fdt library. That has been removed, probably with the change t=
o the 9.x branch as it is not in 9.0.2
>>>
>>> We have the dtc package in make but it is after qemu.
>>>
>>> I could move it to before qemu, however I also note that the dtc package =
is specified only for aarch64 but if we need to have the above softmmu target=
s specified then qemu is requiring the fdt library for all our architectures.
>>>
>>> Before I move dtc and change it to be for all architectures, I just want =
to flag this up and confirm that it is the right thing to do.
>>>
>>> Regards,
>>>
>>> Adolf.
>>>
>>

--===============6421427673273227604==--