From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v3] download ET IDS rules via HTTPS
Date: Thu, 16 Aug 2018 19:05:56 +0100
Message-ID: <4fd5a1b6d738a2d17ae77c5a3ddd276ddd244b68.camel@ipfire.org>
In-Reply-To: <1708b1ac-091c-392f-b944-918ab7efbba2@link38.eu>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9026147125032883855=="
List-Id: <development.lists.ipfire.org>

--===============9026147125032883855==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Merged.

On Thu, 2018-08-16 at 17:09 +0200, Peter Müller wrote:
> The Emerging Threats ruleset server supports HTTPS. It should
> be used for downloading the ruleset in IPFire, too.
> 
> This also needs to be applied on the upcoming ids.cgi file for Suricata
> which I will do in a second patch.
> 
> The third version of this patch superseds the first and
> second one which were broken due to bugs in the MUAs GPG
> implementation.
> 
> Signed-off-by: Peter Müller <peter.mueller(a)link38.eu>
> ---
>  html/cgi-bin/ids.cgi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
> index 9863251e2..d9d697deb 100644
> --- a/html/cgi-bin/ids.cgi
> +++ b/html/cgi-bin/ids.cgi
> @@ -265,7 +265,7 @@ if (!$errormessage) {
>  	} elsif ($snortsettings{'RULES'} eq 'community') {
>  		$url=" https://www.snort.org/rules/community";
>  	} else {
> -		$url="
> http://rules.emergingthreats.net/open/snort-2.9.0/emerging.rules.tar.gz";
> +		$url="
> https://rules.emergingthreats.net/open/snort-2.9.0/emerging.rules.tar.gz";
>  	}
>  
>  	if ($snortsettings{'ACTION'} eq $Lang::tr{'save'} &&
> $snortsettings{'ACTION2'} eq "snort" ) {


--===============9026147125032883855==--