From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arne Fitzenreiter <arne_f@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/6] crda: removal from kernel 4.15 and onwards.
Date: Fri, 09 Jul 2021 08:26:40 +0200
Message-ID: <4ff905fdb41cbe70329e72d1222160aa@ipfire.org>
In-Reply-To: <20210628191400.2860975-2-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5106073206997733716=="
List-Id: <development.lists.ipfire.org>

--===============5106073206997733716==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Removing regdump from crda package will break the hostapd webif because=20
this is used to
generate the countrylist from wireless-regdb.

Arne

Am 2021-06-28 21:13, schrieb Adolf Belka:
> - From kernel 4.15 and onwards the function of what crda does is built
> into the kernel.
> - Tested the removal of crda with kernel 4.14.232 and kernel 5.10.45
>    Country code set by "iw reg set NL" was recognised with kernel
> 5.10.45 and set at
>    the global value of 00 with kernel 4.14.232 confirming the kernel
> built in option is
>    working without the prescence of crda
>=20
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>  config/rootfiles/common/crda | 14 -------
>  lfs/crda                     | 78 ------------------------------------
>  2 files changed, 92 deletions(-)
>  delete mode 100644 config/rootfiles/common/crda
>  delete mode 100644 lfs/crda
>=20
> diff --git a/config/rootfiles/common/crda=20
> b/config/rootfiles/common/crda
> deleted file mode 100644
> index 5f93bc254..000000000
> --- a/config/rootfiles/common/crda
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -lib/udev/rules.d/85-regulatory.rules
> -#root/.python-eggs
> -#root/.python-eggs/M2Crypto-0.21.1-py2.7-linux-xxxMACHINExxx.egg-tmp
> -#root/.python-eggs/M2Crypto-0.21.1-py2.7-linux-xxxMACHINExxx.egg-tmp/M2Cry=
pto
> -#root/.python-eggs/M2Crypto-0.21.1-py2.7-linux-xxxMACHINExxx.egg-tmp/M2Cry=
pto/__m2crypto.so
> -sbin/crda
> -sbin/regdbdump
> -#usr/include/reglib
> -#usr/include/reglib/nl80211.h
> -#usr/include/reglib/regdb.h
> -#usr/include/reglib/reglib.h
> -usr/lib/libreg.so
> -#usr/share/man/man8/crda.8.gz
> -#usr/share/man/man8/regdbdump.8.gz
> diff --git a/lfs/crda b/lfs/crda
> deleted file mode 100644
> index bd812942e..000000000
> --- a/lfs/crda
> +++ /dev/null
> @@ -1,78 +0,0 @@
> -##########################################################################=
#####
> -#                                                                     =20
>        #
> -# IPFire.org - A linux based firewall                                 =20
>        #
> -# Copyright (C) 2007-2018  IPFire Team  <info(a)ipfire.org>             =20
>        #
> -#                                                                     =20
>        #
> -# This program is free software: you can redistribute it and/or modify=20
>        #
> -# it under the terms of the GNU General Public License as published by=20
>        #
> -# the Free Software Foundation, either version 3 of the License, or   =20
>        #
> -# (at your option) any later version.                                 =20
>        #
> -#                                                                     =20
>        #
> -# This program is distributed in the hope that it will be useful,     =20
>        #
> -# but WITHOUT ANY WARRANTY; without even the implied warranty of      =20
>        #
> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the       =20
>        #
> -# GNU General Public License for more details.                        =20
>        #
> -#                                                                     =20
>        #
> -# You should have received a copy of the GNU General Public License   =20
>        #
> -# along with this program.  If not, see=20
> <http://www.gnu.org/licenses/>.       #
> -#                                                                     =20
>        #
> -##########################################################################=
#####
> -
> -##########################################################################=
#####
> -# Definitions
> -##########################################################################=
#####
> -
> -include Config
> -
> -VER        =3D 4.14
> -
> -THISAPP    =3D crda-$(VER)
> -DL_FILE    =3D $(THISAPP).tar.gz
> -DL_FROM    =3D $(URL_IPFIRE)
> -DIR_APP    =3D $(DIR_SRC)/$(THISAPP)
> -
> -TARGET =3D $(DIR_INFO)/$(THISAPP)
> -
> -##########################################################################=
#####
> -# Top-level Rules
> -##########################################################################=
#####
> -
> -objects =3D $(DL_FILE)
> -
> -$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
> -
> -$(DL_FILE)_MD5 =3D cac7ba8de3e2e6aa46918e0c76df7d67
> -
> -install : $(TARGET)
> -
> -check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> -
> -download :$(patsubst %,$(DIR_DL)/%,$(objects))
> -
> -md5 : $(subst %,%_MD5,$(objects))
> -
> -##########################################################################=
#####
> -# Downloading, checking, md5sum
> -##########################################################################=
#####
> -
> -$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> -	@$(CHECK)
> -
> -$(patsubst %,$(DIR_DL)/%,$(objects)) :
> -	@$(LOAD)
> -
> -$(subst %,%_MD5,$(objects)) :
> -	@$(MD5)
> -
> -##########################################################################=
#####
> -# Installation Details
> -##########################################################################=
#####
> -
> -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> -	@$(PREBUILD)
> -	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
> -	cd $(DIR_APP) && sed -e "s/-Werror//g" -i Makefile
> -	cd $(DIR_APP) && make $(MAKETUNING)
> -	cd $(DIR_APP) && make install
> -	@rm -rf $(DIR_APP)
> -	@$(POSTBUILD)

--===============5106073206997733716==--