From: Tom Rymes <tom@rymes.net>
To: development@lists.ipfire.org
Subject: Re: [PATCH] bug#10629: Prevent dynamic and fixed leases overlapping
Date: Sun, 21 Feb 2021 11:33:54 -0500 [thread overview]
Message-ID: <500638AC-67DA-486B-BD00-83073180F344@rymes.net> (raw)
In-Reply-To: <21d29657-9206-a6ed-5b39-80ce1a572a9b@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
> On Feb 21, 2021, at 9:02 AM, Adolf Belka (ipfire) <adolf.belka(a)ipfire.org> wrote:
>
> Hi Michael & Tom
[snip]
> I think the suggestion to only have a warning for existing overlapped leases and an error for creating new ones is a good solution. It allows existing systems with overlapped IP's to continue running but makes the issue visible. The error message to prevent creating new overlapped IP's makes sure that the problem is not extended further.
>
> Regards,
>
> Adolf.
Adolf,
So long as the user isn’t forced to change pre-existing fixed leases before adding new ones, this is fine by me, a good compromise, I suppose.
Perhaps it would be wise to highlight any rows that do over lap to alert the user that they should endeavor to fix them?
Tom
prev parent reply other threads:[~2021-02-21 16:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 13:58 Adolf Belka
2021-02-17 19:38 ` Aw: " Bernhard Bitsch
2021-02-17 21:21 ` Adolf Belka (ipfire-dev)
2021-02-18 11:37 ` Michael Tremer
2021-02-18 12:17 ` Adolf Belka (ipfire-dev)
2021-02-18 13:06 ` Michael Tremer
2021-02-18 14:01 ` Adolf Belka (ipfire-dev)
2021-02-18 15:18 ` Michael Tremer
2021-02-18 15:29 ` Aw: " Bernhard Bitsch
2021-02-18 16:05 ` Tom Rymes
2021-02-18 16:23 ` Aw: " Bernhard Bitsch
2021-02-18 22:38 ` Tom Rymes
2021-02-18 17:08 ` Adolf Belka (ipfire-dev)
2021-02-18 22:40 ` Tom Rymes
2021-02-19 11:37 ` Adolf Belka (ipfire)
2021-02-19 18:57 ` Michael Tremer
2021-02-21 14:02 ` Adolf Belka (ipfire)
2021-02-21 16:33 ` Tom Rymes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500638AC-67DA-486B-BD00-83073180F344@rymes.net \
--to=tom@rymes.net \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox