From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rymes To: development@lists.ipfire.org Subject: Re: [PATCH] bug#10629: Prevent dynamic and fixed leases overlapping Date: Sun, 21 Feb 2021 11:33:54 -0500 Message-ID: <500638AC-67DA-486B-BD00-83073180F344@rymes.net> In-Reply-To: <21d29657-9206-a6ed-5b39-80ce1a572a9b@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4224601340937929776==" List-Id: --===============4224601340937929776== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable > On Feb 21, 2021, at 9:02 AM, Adolf Belka (ipfire) wrote: >=20 > =EF=BB=BFHi Michael & Tom [snip] > I think the suggestion to only have a warning for existing overlapped lease= s and an error for creating new ones is a good solution. It allows existing s= ystems with overlapped IP's to continue running but makes the issue visible. = The error message to prevent creating new overlapped IP's makes sure that the= problem is not extended further. >=20 > Regards, >=20 > Adolf. Adolf, So long as the user isn=E2=80=99t forced to change pre-existing fixed leases = before adding new ones, this is fine by me, a good compromise, I suppose.=20 Perhaps it would be wise to highlight any rows that do over lap to alert the = user that they should endeavor to fix them? Tom --===============4224601340937929776==--