From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4cv0LG3kypz2yHd for ; Sat, 25 Oct 2025 13:02:46 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [IPv6:2001:678:b28::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (Client CN "mail01.haj.ipfire.org", Issuer "R12" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4cv0LC1B0Mz2xRF for ; Sat, 25 Oct 2025 13:02:43 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4cv0LB2pKLz12Z; Sat, 25 Oct 2025 13:02:42 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1761397362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lk4YLgAJgpQ/UvqQbHxVkAcAvCuhl+JKICXRWFUpbDE=; b=G29iA37C6snR2Gsm9cHjFvDQTQjEUwlqXZZUHwK9VbAVffcfe7f7OqHBDi1F93GxwzTllj 9jbYZnmaY6EFK1DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1761397362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lk4YLgAJgpQ/UvqQbHxVkAcAvCuhl+JKICXRWFUpbDE=; b=MTwB8BaZ4tM3ubQWXADwBGQyiNHac+2QxAyg1AlUQv+kBBCDZPNm0ki78yDHp20by6mJap PzvE++5+aAFQt/CcsIINLXq95BwZ/boFStG+g6c3h/LkXZFjM7smL5LQQKC3R5RN0mtcWE 0FGWNQXHJ1GvmC847rXOmZsiZ37EblL3Mfb9mksnFOKF70+f70I8gUg+2NwF6634X80BwI +I/xxcclV37GPfM1JuaE7jry4UM0g0rpiVa6YA6dOJzvdxX5oJSzqrLmmFMPengnc4o/BU VnZoggREUz/RzI1vlkS44PQsTuegpt17Dt1eCBOIfhzgD2O4FaYEHCDk1/JGlw== Content-Type: text/plain; charset=utf-8 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: Mime-Version: 1.0 Subject: Re: [PATCH] nasm: Use only with x86_64 From: Michael Tremer In-Reply-To: <20251024164255.1704420-1-adolf.belka@ipfire.org> Date: Sat, 25 Oct 2025 14:02:41 +0100 Cc: development@lists.ipfire.org Content-Transfer-Encoding: quoted-printable Message-Id: <5098192D-4685-4192-8A1D-04CCB81F3A05@ipfire.org> References: <20251024164255.1704420-1-adolf.belka@ipfire.org> To: Adolf Belka Hello Adolf, Yes this makes sense. Although it does compile on the other = architectures, we simply don=E2=80=99t need to ever create any x86 = assembly there. For completeness, I have move the root file, too: = https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommitdiff;h=3Ded737ca7b89a= de1e23aa512d2fa5596a2df01a1d -Michael > On 24 Oct 2025, at 17:42, Adolf Belka wrote: >=20 > - nasm is linked in to syslinux and libjpeg. > - libjpeg will only require nasm if CET has been enabled in glibc and = the architecture is > x86_64. CET is not enabled in IPFire, therefore libjpeg does not = require nasm for > building in x86_64 and is not required at all for libjpeg under = aarch64 or riscv64 > - syslinux requires nasm to build but only in x86_64. > - This patch sets the supported architecture to x86_64 only. The build = of nasm will be > skipped in aarch64 and riscv64. > - The x86_64 build ran as normal. The build was also tested for = aarch64 and the build of > nasm was skipped. syslinux is skipped and libjpeg built successfully = confirming that > nasm does not need to be built for aarch64 or riscv64. > - The patch is removed as it is only required for building nasm for an = arm architecture >=20 > Signed-off-by: Adolf Belka > --- > lfs/nasm | 2 +- > ...00_fix_typo_in_le32toh_function_name.patch | 20 ------------------- > 2 files changed, 1 insertion(+), 21 deletions(-) > delete mode 100644 = src/patches/nasm-3.00_fix_typo_in_le32toh_function_name.patch >=20 > diff --git a/lfs/nasm b/lfs/nasm > index bd56757d9..26f91cc1b 100644 > --- a/lfs/nasm > +++ b/lfs/nasm > @@ -31,6 +31,7 @@ DL_FILE =3D $(THISAPP).tar.xz > DL_FROM =3D $(URL_IPFIRE) > DIR_APP =3D $(DIR_SRC)/$(THISAPP) > TARGET =3D $(DIR_INFO)/$(THISAPP) > +SUP_ARCH =3D x86_64 >=20 > = ##########################################################################= ##### > # Top-level Rules > @@ -70,7 +71,6 @@ $(subst %,%_BLAKE2,$(objects)) : > $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > @$(PREBUILD) > @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE) > - cd $(DIR_APP) && patch -Np1 < = $(DIR_SRC)/src/patches/nasm-3.00_fix_typo_in_le32toh_function_name.patch > cd $(DIR_APP) && ./configure \ > --prefix=3D/usr > cd $(DIR_APP) && make $(MAKETUNING) > diff --git = a/src/patches/nasm-3.00_fix_typo_in_le32toh_function_name.patch = b/src/patches/nasm-3.00_fix_typo_in_le32toh_function_name.patch > deleted file mode 100644 > index 3b198b2d8..000000000 > --- a/src/patches/nasm-3.00_fix_typo_in_le32toh_function_name.patch > +++ /dev/null > @@ -1,20 +0,0 @@ > ---- nasm-3.00/include/bytesex.h.orig 2025-10-03 21:41:41.000000000 = +0200 > -+++ nasm-3.00/include/bytesex.h 2025-10-06 15:03:06.434849426 +0200 > -@@ -215,7 +215,7 @@ > - } __attribute__((packed)); > - static inline uint32_t getu32(const void *p) > - { > -- return l32toh(((const struct unaligned32 *)p)->v); > -+ return le32toh(((const struct unaligned32 *)p)->v); > - } > - static inline uint32_t setu32(void *p, uint32_t v) > - { > -@@ -253,7 +253,7 @@ > - static inline uint32_t getu32(const void *p) > - { > - const uint32_t _unaligned *pp =3D p; > -- return l32toh(*pp); > -+ return le32toh(*pp); > - } > - static inline uint32_t setu32(void *p, uint32_t v) > - { > --=20 > 2.51.1 >=20 >=20