From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Question regarding rootfile warning "Error! '/aarch64' in
 rootfiles files found!"
Date: Thu, 09 Dec 2021 20:52:43 +0100
Message-ID: <50d27cdb-d2aa-e4da-7b22-90cb453a545f@ipfire.org>
In-Reply-To: <FFEF8F76-8414-41FB-BE71-4CE13CFBF158@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5192927925635598442=="
List-Id: <development.lists.ipfire.org>

--===============5192927925635598442==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Michael,

thanks for your reply.

As far as I understood the issue, make.sh checking for architecture names in =
paths
is fine, but in filenames (such as x86_64.h), it is not. A whitelist approach=
 would
not be necessary in this case, it only needs to ignore the file name of a giv=
en path
while checking for architecture names.

Does this make sense? Or did I misunderstood you?

Thanks, and best regards,
Peter M=C3=BCller


> Hello,
>=20
> What is the bug for? The check does exactly what it is supposed to do.
>=20
> We either need to get rid of it entirely because it has false positives or =
we need to have a whitelist.
>=20
> Is that a solution that you had in mind?
>=20
> -Michael
>=20
>> On 9 Dec 2021, at 19:39, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>>
>> P.S.: Bug #12743 (https://bugzilla.ipfire.org/show_bug.cgi?id=3D12743) has=
 been raised for this.
>>
>> Should anybody have spare time to work on it, please feel free to do so. :=
-)
>>
>>> Hello Adolf,
>>>
>>> thanks for your reply.
>>>
>>>> How should we deal with the situation where a source file filename happe=
ns to use an architecture name the same as an IPFire name.
>>>
>>> I also think this is a false positive, though it surprises me we never ca=
me across this
>>> scenario all the years before. Either way, make.sh (or whatever's doing t=
his check) needs
>>> to be updated to ignore such cases.
>>>
>>> I'll file a bug for this later...
>>>
>>> Thanks, and best regards,
>>> Peter M=C3=BCller
>>>
>=20

--===============5192927925635598442==--