public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenVPN: Fix upload check for root and host certificate
Date: Mon, 18 Jun 2018 16:52:42 +0100	[thread overview]
Message-ID: <5121e7d81cb89be67bebf63874d8573ba32b507f.camel@ipfire.org> (raw)
In-Reply-To: <baf68c3b14207a611cbe0f018900d8efc0097c24.camel@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

Actually. It doesn't apply against next... Can you check why?

On Mon, 2018-06-18 at 16:46 +0100, Michael Tremer wrote:
> Merged.
> 
> We are on fire today!
> 
> On Mon, 2018-06-18 at 17:10 +0200, Erik Kapfer wrote:
> > Fix for #11766 .
> > Since the new OpenSSL output differs in the 'Subject' section, the regex
> > needed to be adapted.
> > Old and new output should now be possible.
> > 
> > Signed-off-by: Erik Kapfer <erik.kapfer(a)ipfire.org>
> > ---
> >  html/cgi-bin/ovpnmain.cgi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> > index b3122a4..947cbe9 100644
> > --- a/html/cgi-bin/ovpnmain.cgi
> > +++ b/html/cgi-bin/ovpnmain.cgi
> > @@ -4045,7 +4045,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
> >  	    }
> >  
> >  	    my $temp = `/usr/bin/openssl x509 -text -in
> > ${General::swroot}/ovpn/certs/$cgiparams{'NAME'}cert.pem`;
> > -	    $temp =~ /Subject:.*CN=(.*)[\n]/;
> > +	    $temp =~ /Subject:.*CN\s?=\s?(.*)[\n]/;
> >  	    $temp = $1;
> >  	    $temp =~ s+/Email+, E+;
> >  	    $temp =~ s/ ST=/ S=/;
> > @@ -4099,7 +4099,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
> >  	    }
> >  
> >  	    my $temp = `/usr/bin/openssl x509 -text -in
> > ${General::swroot}/ovpn/certs/$cgiparams{'NAME'}cert.pem`;
> > -	    $temp =~ /Subject:.*CN=(.*)[\n]/;
> > +	    $temp =~ /Subject:.*CN\s?=\s?(.*)[\n]/;
> >  	    $temp = $1;
> >  	    $temp =~ s+/Email+, E+;
> >  	    $temp =~ s/ ST=/ S=/;

  reply	other threads:[~2018-06-18 15:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 15:10 Erik Kapfer
2018-06-18 15:46 ` Michael Tremer
2018-06-18 15:52   ` Michael Tremer [this message]
2018-06-18 16:30     ` ummeegge
2018-06-19 10:40       ` Michael Tremer
2018-06-19 12:02         ` ummeegge
2018-06-19 13:01           ` Michael Tremer
2018-06-19 14:10             ` ummeegge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5121e7d81cb89be67bebf63874d8573ba32b507f.camel@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox