From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] OpenVPN: Prevent internal server error cause of bad
 header wrapper
Date: Tue, 03 Jul 2018 10:52:29 +0100
Message-ID: <5151d8fbf09ed5632c1d39bd70af7432ca6c4a3f.camel@ipfire.org>
In-Reply-To: <1530534365.8568.1.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8940703439586905019=="
List-Id: <development.lists.ipfire.org>

--===============8940703439586905019==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Yes, I just did.

I collected all the patches and merged all the package updates first and toda=
y I
merged all other smaller changes.

Best,
-Michael

On Mon, 2018-07-02 at 14:26 +0200, ummeegge wrote:
> Hi,
> just wanted to know if this fix will be applied ?
>=20
> Best,
>=20
> Erik
>=20
>=20
> Am Donnerstag, den 21.06.2018, 11:12 +0200 schrieb Erik Kapfer:
> > This fixes #11772 .
> >=20
> > If the X509 are deleted, the openvpnctrl output generates a bad
> > header wrapper error from the CGI
> > which causes an internal server error. The redirection of the
> > openvpnctrl output fixes this.
> >=20
> > Signed-off-by: Erik Kapfer <erik.kapfer(a)ipfire.org>
> > ---
> >  html/cgi-bin/ovpnmain.cgi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
> > index 4bc3473..5cd19a0 100644
> > --- a/html/cgi-bin/ovpnmain.cgi
> > +++ b/html/cgi-bin/ovpnmain.cgi
> > @@ -1181,7 +1181,7 @@ SETTINGS_ERROR:
> >  	    delete $confighash{$cgiparams{'$key'}};
> >  	}
> > =20
> > -	system ("/usr/local/bin/openvpnctrl -drrd $name");
> > +	system ("/usr/local/bin/openvpnctrl -drrd $name
> > &>/dev/null");
> >      }
> >      while ($file =3D glob("${General::swroot}/ovpn/ca/*")) {
> >  	unlink $file;

--===============8940703439586905019==--