From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] Added i586/386 support for GO language required for
 node_exporter.
Date: Fri, 21 May 2021 09:59:14 +0100
Message-ID: <518E3B30-3213-45C2-A105-609B3002A24C@ipfire.org>
In-Reply-To: <82c9782c-f69c-2e69-dbcc-e5975a7ec160@posteo.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3105332168433598127=="
List-Id: <development.lists.ipfire.org>

--===============3105332168433598127==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Holger,

> On 21 May 2021, at 09:56, Holger Sunke <holger.sunke(a)posteo.de> wrote:
>=20
> Hello Michael,
>=20
>=20
> Am 11.05.21 um 11:53 schrieb Michael Tremer:
>> Hello,
>>> On 7 May 2021, at 19:19, Holger Sunke <holger.sunke(a)posteo.de> wrote:
>>>=20
>>> Hello Michael,
>>>=20
>>>=20
>>> Am 07.05.21 um 13:28 schrieb Michael Tremer:
>>>> Hello Holger,
>>>> Thanks for this patch, but I am afraid it doesn=E2=80=99t do exactly wha=
t you intend to do.
>>>>> On 6 May 2021, at 20:46, Holger Sunke <holger.sunke(a)posteo.de> wrote:
>>>>>=20
>>>>> ---
>>>>> lfs/Config | 4 ++++
>>>>> lfs/go     | 6 +++---
>>>>> 2 files changed, 7 insertions(+), 3 deletions(-)
>>>>>=20
>>>>> diff --git a/lfs/Config b/lfs/Config
>>>>> index eadbbc408..4d0f2f00b 100644
>>>>> --- a/lfs/Config
>>>>> +++ b/lfs/Config
>>>>> @@ -138,6 +138,10 @@ ifeq "$(BUILD_ARCH)" "aarch64"
>>>>> 	GOARCH =3D arm64
>>>>> endif
>>>>>=20
>>>>> +ifeq "$(BUILD_ARCH)" "i586"
>>>>> +	GOARCH =3D 386
>>>>> +endif
>>>> This is fine.
>>>>> +
>>>>> #######################################################################=
########
>>>>> # Common Macro Definitions
>>>>> #######################################################################=
########
>>>>> diff --git a/lfs/go b/lfs/go
>>>>> index 6ebb37080..97effcb84 100644
>>>>> --- a/lfs/go
>>>>> +++ b/lfs/go
>>>>> @@ -28,10 +28,9 @@ VER        =3D 1.15.4
>>>>>=20
>>>>> THISAPP    =3D go-$(VER)
>>>>> DL_FILE    =3D go$(VER).$(GOOS)-$(GOARCH).tar.gz
>>>>> -DL_FROM    =3D $(URL_IPFIRE)
>>>>> +DL_FROM    =3D https://golang.org/dl/
>>>>> DIR_APP    =3D $(DIR_SRC)/go
>>>>> TARGET     =3D $(DIR_INFO)/$(THISAPP)
>>>>> -SUP_ARCH   =3D x86_64
>>>> This however enables Go for all architectures including aarch64 and armv=
5tel which is not what you intend.
>>>> The correct solution would be to add i586 to the list of supported archi=
tectures.
>>>> However, I would object to only add Go for i586 because you personally u=
se IPFire on this architecture (please not Adolf=E2=80=99s remarks on our sch=
edule to discontinue i586). We only build Go for x86_64 because the only pack=
age that uses it is the Amazon SSM agent which is not relevant on any other a=
rchitecture. node_exporter seems to be a package that could in theory run on =
any architecture and I feel that we should not discriminate by only building =
something for one architecture because we do not want to test it on any of th=
e others.
>>>=20
>>> Not sure if I get you right, but finally I think I should change the Conf=
ig to make "go" compile for _all_ architectures supported by ipfire as node_e=
xporter depends on it.
>> Yes, that is correct. We aim to treat all architectures the same. Sometime=
s that isn=E2=80=99t possible, but that isn=E2=80=99t the case here.
>> Best,
>> -Michael
>=20
> Dou you have a list of all architectures supported by IPFire beyond i586(le=
gacy), aarch64(=3Darm64?), x86_64 and arm?

We currently support these architectures:

* x86_64 which is our primary architecture with by far the most users on it

* aarch64

* i586 which is currently deprecated and will be dropped soon (https://blog.i=
pfire.org/post/new-year-more-bits)

* armv5tel - this might be tricky because we do not have any floating-point s=
upport. However, the kernel requires that which means that you will at least =
need an armv6l processor in order to run on this. Depending on what Go provid=
es upstream, armv6l might be fine.

Best,
-Michael

>=20
> Kind regards
>=20
> Holger
>>>=20
>>>> -Michael
>>>>>=20
>>>>> #######################################################################=
########
>>>>> # Top-level Rules
>>>>> @@ -41,7 +40,8 @@ objects =3D $(DL_FILE)
>>>>>=20
>>>>> $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>>>>=20
>>>>> -$(DL_FILE)_MD5 =3D 8e9d11a16f03372c82c5134278a0bd7d
>>>>> +go$(VER).$(GOOS)-amd64.tar.gz_MD5 =3D 8e9d11a16f03372c82c5134278a0bd7d
>>>>> +go$(VER).$(GOOS)-386.tar.gz_MD5 =3D 8d1c3539c88710273f61b0c810b7448c
>>>>>=20
>>>>> install : $(TARGET)
>>>>>=20
>>>>> --=20
>>>>> 2.30.2


--===============3105332168433598127==--