public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 3/5] readhash: Fix the quote check
Date: Wed, 21 Jan 2026 21:00:08 +0100	[thread overview]
Message-ID: <51faea21-3ed0-4300-bf19-5ba11dffc239@ipfire.org> (raw)
In-Reply-To: <20260119162140.3373757-3-michael.tremer@ipfire.org>

Reviewed-by: Bernhard Bitsch <bbitsch@ipfire.org>

Am 19.01.2026 um 17:21 schrieb Michael Tremer:
> The single quotes changed bash's behaviour to interpret the * character
> literally, but this is not what we wanted here. We need to escape the
> single quotes.
> 
> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
> ---
>   src/initscripts/system/functions | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/initscripts/system/functions b/src/initscripts/system/functions
> index c4b7cb39e..757912eab 100644
> --- a/src/initscripts/system/functions
> +++ b/src/initscripts/system/functions
> @@ -930,7 +930,7 @@ readhash() {
>   
>   		# strip leading and trailing single quotes
>   		case "${val}" in
> -			'*')
> +			\'*\')
>   				val="${val#\'}"
>   				val="${val%\'}"
>   				;;



  reply	other threads:[~2026-01-21 20:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 16:21 [PATCH 1/5] hostapd: Bring back support for 802.11g/a Michael Tremer
2026-01-19 16:21 ` [PATCH 2/5] hostapd: Use the new readhash implementation to read configuration files Michael Tremer
2026-01-21 19:58   ` Bernhard Bitsch
2026-01-19 16:21 ` [PATCH 3/5] readhash: Fix the quote check Michael Tremer
2026-01-21 20:00   ` Bernhard Bitsch [this message]
2026-01-19 16:21 ` [PATCH 4/5] initscripts: functions: Permit ! in the value of key/value files Michael Tremer
2026-01-19 16:21 ` [PATCH 5/5] hostapd: Bump package version Michael Tremer
2026-01-21 19:46 ` [PATCH 1/5] hostapd: Bring back support for 802.11g/a Bernhard Bitsch
2026-01-22 11:14   ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51faea21-3ed0-4300-bf19-5ba11dffc239@ipfire.org \
    --to=bbitsch@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox