From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4dxFRP1fRhz2y1f for ; Wed, 21 Jan 2026 20:00:17 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (Client CN "mail01.haj.ipfire.org", Issuer "R12" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4dxFRK5Gv2z2xHh for ; Wed, 21 Jan 2026 20:00:13 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4dxFRK2MrKzN7 for ; Wed, 21 Jan 2026 20:00:13 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1769025613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2KJOLlsQ9b+mzIAJAF3VQe51ZAaP+YcoW/CfOBsR8h8=; b=wH1VxapXKhRBiexvJ+bciVVvbqoTZFeCQbrhUxi+YsWZOmmTJ+rIvj584FViIirnozzzTW CIEVzVa7zJSPYIAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1769025613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2KJOLlsQ9b+mzIAJAF3VQe51ZAaP+YcoW/CfOBsR8h8=; b=Fz8h/UfocnKO/JMG6vvvdhweLcVj462juxfJ5yDdd1akXixsOTCM7dwBRvSqd6Ya3na0Ip PPlNMlHKGa51FzUUp24zkPycbEaco2XSblO3G7fYOTYxhLgzIfEQOEP5JLa9fcwQ9dvYTp B6Xfem9wyWX+b6gvfxDssrFJrG87djL6Hs8qAr45E4LSCj7SCrw+oeRkvujBpaQfyj7J8z UH2Los8dQ9skgF+KOXGl7IS8JvvoVC+QSQAr3PcV+nV907frNL+O+WdC/e2qEdqLDaG4HB rYXds7G2aPWGPPlcgYAYlV2Vhvq5glOcl6wO7HcDFaP8eIukSOiD1tIeQPFjVg== Message-ID: <51faea21-3ed0-4300-bf19-5ba11dffc239@ipfire.org> Date: Wed, 21 Jan 2026 21:00:08 +0100 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 Subject: Re: [PATCH 3/5] readhash: Fix the quote check To: development@lists.ipfire.org References: <20260119162140.3373757-1-michael.tremer@ipfire.org> <20260119162140.3373757-3-michael.tremer@ipfire.org> Content-Language: en-GB From: Bernhard Bitsch In-Reply-To: <20260119162140.3373757-3-michael.tremer@ipfire.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Bernhard Bitsch Am 19.01.2026 um 17:21 schrieb Michael Tremer: > The single quotes changed bash's behaviour to interpret the * character > literally, but this is not what we wanted here. We need to escape the > single quotes. > > Signed-off-by: Michael Tremer > --- > src/initscripts/system/functions | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/initscripts/system/functions b/src/initscripts/system/functions > index c4b7cb39e..757912eab 100644 > --- a/src/initscripts/system/functions > +++ b/src/initscripts/system/functions > @@ -930,7 +930,7 @@ readhash() { > > # strip leading and trailing single quotes > case "${val}" in > - '*') > + \'*\') > val="${val#\'}" > val="${val%\'}" > ;;