From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] collectd: run sensors-detect in background
Date: Wed, 25 Mar 2020 09:10:59 +0000
Message-ID: <5279ECFA-2AE4-4F3A-8C78-A5FB9060CCFF@ipfire.org>
In-Reply-To: <20200325063538.15980-1-arne_f@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1407708618774180672=="
List-Id: <development.lists.ipfire.org>

--===============1407708618774180672==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

This is an interesting approach to an interesting problem.

I guess it solves the problem well, although we should not be in the position=
 where we have to build all this code :)

> On 25 Mar 2020, at 06:35, Arne Fitzenreiter <arne_f(a)ipfire.org> wrote:
>=20
> on some machines the i2c sensor search take very long time
> which cause hang at first boot.
>=20
> Now the search is started in background and waited for max one
> minute before continue load of collectd.
> On such machines collectd will not get all sensors at first startup.

Can scan_for_sensors() not simply check if collectd is already running and if=
 so, simply restart it?

Best,
-Michael

>=20
> fixes #12329
>=20
> Signed-off-by: Arne Fitzenreiter <arne_f(a)ipfire.org>
> ---
> src/initscripts/system/collectd | 56 ++++++++++++++++++++++-----------
> 1 file changed, 37 insertions(+), 19 deletions(-)
>=20
> diff --git a/src/initscripts/system/collectd b/src/initscripts/system/colle=
ctd
> index 5233525f0..20072780a 100644
> --- a/src/initscripts/system/collectd
> +++ b/src/initscripts/system/collectd
> @@ -6,6 +6,28 @@
>=20
> eval $(/usr/local/bin/readhash /var/ipfire/main/settings)
>=20
> +scan_for_sensors() {
> +	touch /var/lock/sensors_search
> +	# pre scan and try to load modules
> +	"yes" | /usr/sbin/sensors-detect > /dev/null
> +	if [ -e /etc/sysconfig/lm_sensors ]; then
> +
> +		# Module load
> +		. /etc/sysconfig/lm_sensors
> +		for modul in $BUS_MODULES $HWMON_MODULES ; do
> +			modprobe $modul > /dev/null 2>&1;
> +		done
> +	fi
> +
> +	# Final scan
> +	"yes" | /usr/sbin/sensors-detect > /dev/null
> +
> +	if [ ! -e /etc/sysconfig/lm_sensors ]; then
> +		echo "#No Sensors detected " > /etc/sysconfig/lm_sensors
> +	fi
> +	rm /var/lock/sensors_search
> +}
> +
> if [ "$RRDLOG" =3D '' ]; then
> 	RRDLOG=3D/var/log/rrd
> fi
> @@ -42,27 +64,23 @@ case "$1" in
>=20
> 		# At first run search for sensors with sensors-detect
> 		if [ ! -e /etc/sysconfig/lm_sensors ]; then
> -			boot_mesg "Searching for Sensors..."
> -
> -			# pre scan and try to load modules
> -			"yes" | /usr/sbin/sensors-detect > /dev/null
> -			if [ -e /etc/sysconfig/lm_sensors ]; then
> -
> -				# Module load
> -				. /etc/sysconfig/lm_sensors
> -				for modul in $BUS_MODULES $HWMON_MODULES ; do
> -					modprobe $modul > /dev/null 2>&1;
> -				done
> -			fi
> -
> -			# Final scan
> -			"yes" | /usr/sbin/sensors-detect > /dev/null
> -			evaluate_retval
> +			# Don't run at next boot again
> +			touch /etc/sysconfig/lm_sensors
> +			boot_mesg -n "Searching for Sensors..."
> +			scan_for_sensors &
> +			sleep 2
> +		fi
>=20
> -			if [ ! -e /etc/sysconfig/lm_sensors ]; then
> -				echo "#No Sensors detected " > /etc/sysconfig/lm_sensors
> -			fi
> +		if [ -e /var/lock/sensors_search ]; then
> +			for (( i=3D1; i<30; i++)) do
> +				if [ ! -e /var/lock/sensors_search ]; then
> +					break;
> +				fi
> +				boot_mesg -n "."
> +				sleep 2
> +			done
> 		fi
> +		boot_mesg ""
>=20
> 		# Load sensor modules only first start
> 		if [ ! -e /var/lock/sensors_modules ]; then
> --=20
> 2.17.1
>=20


--===============1407708618774180672==--