From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: libnfnetlink and libmnl
Date: Wed, 06 Apr 2022 17:38:35 +0200
Message-ID: <52ec4aad-7ed8-fb3d-05e4-7f16e53bbd53@ipfire.org>
In-Reply-To: <3DFC81E6-7A67-4881-BC3A-A649166AAA84@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7366277015329175370=="
List-Id: <development.lists.ipfire.org>

--===============7366277015329175370==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Michael,

On 06/04/2022 16:42, Michael Tremer wrote:
> Hello Adolf,
>=20
>> On 6 Apr 2022, at 14:18, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>>
>> Hi All,
>>
>> We have both libnfnetlink and libmnl in IPFire. I have just done an update=
 of libmnl.
>> There is an update of libnfnetlink but it also says that libnfnetlink is s=
till deprecated and should preferably be replaced by libmnl
>=20
> Oh this is very interesting.
>=20
> It looks like libmnl was introduced for conntrack-tools in this commit:
>=20
> commit a10733a5d8580b6ab8cff46235daab6547723781
> Author: Arne Fitzenreiter <Arne_F(a)ipfire.org>
> Date:   Thu Jan 3 14:27:11 2013 +0100
>=20
>      conntrack-tools: add conntrack and needed deps.
>=20
> You can try to comment out libnfnetlink and libmnl and run a clean build an=
d see if it goes through. If so, then we can safely drop them.
>=20
>> I have run ./make.sh find-dependencies on both libmnl.so.0.2.0 and libnfne=
tlink.so.0.2.0 and neither came up with anything. Doing a grep on the git rep=
ository for mnl or nfnetlink also didn't indicate anything using these.
>> How are they being used and what needs to be done to change the usage of l=
ibnfnetlink to libmnl?
>=20
> See above.
>=20
> I believe there are a couple of other candidates for this which we should h=
ave a look at. There is libdnet that I noticed a little while ago, but I am s=
ure there will be plenty more when looking through the package list:
>=20
> libaio
> libart
> libnet
> libnl (and if something depends on it, can it not use libnl-3?)
> libpri (if I remember correctly this was a dependency of asterisk)
> libsolv can absolutely go for the moment, we don=E2=80=99t need it
> netpbm?
> pigz (we don=E2=80=99t use it anywhere since we are compressing images with=
 XZ b302b9a695e391477eab0cb2343f3ba1b1ba1989)
> sdparm
>=20
> If you have the time, maybe you can have a look at what is used somewhere a=
nd what can be dropped?
I will give that a go and use your inputs as starting points.

Regards,
Adolf
>=20
> This won=E2=80=99t shrink the distribution by a massive amount, but why sho=
uld we carry around dead code?
>=20
> Best,
> -Michael
>=20
>> Regards,
>> Adolf
>=20

--===============7366277015329175370==--