From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] header.pl: Hide PPPoE menu item if RED is in IP mode
Date: Sat, 27 Mar 2021 21:22:44 +0100
Message-ID: <5326a724-da81-2d54-0ce4-797f491d6c89@ipfire.org>
In-Reply-To: <20210325204942.1780-1-hofmann@leo-andres.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5528965569297329709=="
List-Id: <development.lists.ipfire.org>

--===============5528965569297329709==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>

> Fixes: #11342
>=20
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
>  config/cfgroot/header.pl | 6 ++++++
>  1 file changed, 6 insertions(+)
>=20
> diff --git a/config/cfgroot/header.pl b/config/cfgroot/header.pl
> index 5684c01c5..8dea804d0 100644
> --- a/config/cfgroot/header.pl
> +++ b/config/cfgroot/header.pl
> @@ -170,6 +170,12 @@ sub genmenu {
>          $menu->{'02.status'}{'subMenu'}->{'74.modem-status'}{'enabled'} =
=3D 1;
>      }
> =20
> +	# Disable the Dialup/PPPoE menu item when the RED interface is in IP mode
> +	# (the "Network" module is loaded by general-functions.pl)
> +	if(&Network::is_red_mode_ip()) {
> +		$menu->{'01.system'}{'subMenu'}->{'20.dialup'}{'enabled'} =3D 0;
> +	}
> +
>      # Disbale unusable things in cloud environments
>      if (&General::running_in_cloud()) {
>          $menu->{'03.network'}{'subMenu'}->{'30.dhcp'}{'enabled'} =3D 0;
>=20

--===============5528965569297329709==--