From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: ipblacklist V2
Date: Tue, 08 Mar 2022 15:45:53 +0000
Message-ID: <55A2058D-D3FE-402C-B790-0D89C4D332E4@ipfire.org>
In-Reply-To: <t07ctt$hav$1@tuscan3.grantura.co.uk>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5591593497484380165=="
List-Id: <development.lists.ipfire.org>

--===============5591593497484380165==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Rob,

> On 8 Mar 2022, at 10:59, Rob Brewer <ipfire-devel(a)grantura.co.uk> wrote:
>=20
> On Monday 07 March 2022 22:54 Rob Brewer wrote:
>=20
>> On Monday 07 March 2022 20:39 Michael Tremer wrote:
>>=20
>>> Hello Rob,
>>>=20
>>>> On 5 Mar 2022, at 21:46, Rob Brewer <ipfire-devel(a)grantura.co.uk> wrot=
e:
>>>>=20
>>>> Hi Stefan
>>>>=20
>>>> On Saturday 05 March 2022 18:52 Stefan Schantl wrote:
>>>>=20
>>>>> Hello *,
>>>>>=20
>>>>> I've made some development progress, which I want to share here:
>>>>>=20
>>>>> Most parts of the main backend script ("ipblacklist") from Tim and Rob
>>>>> are ported into a new functions library (ipblocklist-functions.pl) and
>>>>> into the main firewall script (rules.pl).
>>>>>=20
>>>> Good
>>>>> This process is almost finished and currently allows to create the
>>>>> firewall rules, download the blocklists and to convert them into an
>>>>> ipset compatible format.
>>>>>=20
>>>>> Next step will be to import the frontend code (WUI) and adjust it to
>>>>> use the backend code (functions) from the "ipblocklist-functions.pl".
>>>>>=20
>>>>> At this time the blocklist feature should be in a use-able state again
>>>>> and I'll go to create an automatic update script and to import all the
>>>>> logging pages stuff etc.
>>>>>=20
>>>>> The development progress and single commits can be found here:
>>>>>=20
>>>>>=20
>>>> https://git.ipfire.org/?p=3Dpeople/stevee/ipfire-2.x.git;a=3Dshortlog;h=
=3Drefs/heads/ipblocklist
>>>>>=20
>>>>> As usual please feel free to ask any questions or to share your opinion
>>>>> here.
>>>>>=20
>>>>> I wish you a nice day,
>>>>>=20
>>>>> -Stefan
>>>> Great progress. I did find a bug I introduced when I modified the
>>>> ipblacklist V2 perl script to add a space after the log-prefix BLKLST en=
try
>>>> to make the logs compatible with other log-prefixes.
>>>> This affected showrequestfromblacklist.dat and the modified version
>>>> 'modified regex for V3 log-prefix added space' should be used.
>>>>=20
>>>> https://git.ipfire.org/?p=3Dpeople/helix/ipfire-2.x.git;a=3Dcommit;h=3D2=
ccc47f1944fcf1f8eec8ad132fa606081b21578
>>>=20
>>> Good catch, but wouldn=E2=80=99t it be helpful to add the space to all lo=
g prefixes
>>> so that it is always easily readable for humans, too?
>>>=20
>>> -Michael
>>>=20
>>=20
>> I think ipblocklist was the only logfile entry to have this problem.
>>=20
>> Rob
>=20
> I think there is a missing space in  rules.pl before tha last "\"
> I think line 755 should be:
>=20
> run("$IPTABLES -A ${blocklist}_DROP -j LOG -m limit --limit 10/second --log=
-prefix \"BLKLST_$blocklist \"");

Yes, that is the space character I am talking about.

> and in my ipblocklists.dat I changed your line 298 to be compatible with co=
re 163 as I don't think you can change the 'theme' now
> and produced an error.
>=20
> from:
> &General::readhash("/srv/web/ipfire/html/themes/".$mainsettings{'THEME'}."/=
include/colors.txt", \%color);
>=20
> to:=20
> &General::readhash("/srv/web/ipfire/html/themes/ipfire/include/colors.txt",=
 \%color);

No, this has indeed been dropped and needs to be updated in the CGI. Let=E2=
=80=99s leave that to Stefan :)

-Michael

>=20
>=20
> Rob
>=20


--===============5591593497484380165==--