From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: pcre 8.37 with latest patches won't build
Date: Wed, 19 Aug 2015 20:47:24 +0200 [thread overview]
Message-ID: <55D4CF3C.8080305@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 2238 bytes --]
Hi,
yesterday I tried to build the latest 'next', but it failed. It couldn't
apply 'pcre-8.37-Fix-another-buffer-overflow.patch':
***SNIP***
Aug 18 19:03:54: Building pcre pcre-8.37.tar.gz checksum OK
+ cd /usr/src/lfs
+ make -f pcre LFS_BASEDIR=/usr/src install
====================================== Installing pcre-8.37 ...
Install started; saving file list to /usr/src/lsalr ...
cd /usr/src/pcre-8.37 && patch -Np1 <
/usr/src/src/patches/pcre-8.37-Fix-buffer-overflow-for-named-recursive-back-referen.patch
patching file pcre_compile.c
patching file testdata/testinput2
patching file testdata/testoutput2
cd /usr/src/pcre-8.37 && patch -Np1 <
/usr/src/src/patches/pcre-8.37-Fix-buffer-overflow-for-forward-reference-within-bac.patch
patching file pcre_compile.c
patching file testdata/testinput2
patching file testdata/testoutput2
cd /usr/src/pcre-8.37 && patch -Np1 <
/usr/src/src/patches/pcre-8.37-Fix-another-buffer-overflow.patch
patching file pcre_compile.c
Hunk #1 FAILED at 7210.
1 out of 1 hunk FAILED -- saving rejects to file pcre_compile.c.rej
patching file testdata/testinput2
patching file testdata/testoutput11-16
patching file testdata/testoutput11-32
patching file testdata/testoutput11-8
patching file testdata/testoutput2
make: *** [/usr/src/log/pcre-8.37] Error 1
***SNAP***
'pcre_compile.c.rej' says:
***SNIP***
--- pcre_compile.c
+++ pcre_compile.c
@@ -7210,7 +7210,12 @@
real compile this will be picked up and the reference
wrapped with
OP_ONCE to make it atomic, so we must space in case this
occurs. */
- if (recno == 0) *lengthptr += 2 + 2*LINK_SIZE;
+ /* In fact, this can happen for a non-forward reference because
+ another group with the same number might be created later. This
+ issue is fixed "properly" in PCRE2. As PCRE1 is now in
maintenance
+ only mode, we finesse the bug by allowing more memory always. */
+
+ /* if (recno == 0) */ *lengthptr += 2 + 2*LINK_SIZE;
}
/* In the real compile, search the name table. We check the name
***SNAP***
Deleting this section didn't help. Anyone else or my fault?
Regards
Matthias
next reply other threads:[~2015-08-19 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 18:47 Matthias Fischer [this message]
2015-08-19 19:34 ` Michael Tremer
2015-08-20 17:14 ` Matthias Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D4CF3C.8080305@ipfire.org \
--to=matthias.fischer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox