From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Fischer To: development@lists.ipfire.org Subject: pcre 8.37 with latest patches won't build Date: Wed, 19 Aug 2015 20:47:24 +0200 Message-ID: <55D4CF3C.8080305@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3646272586706143455==" List-Id: --===============3646272586706143455== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, yesterday I tried to build the latest 'next', but it failed. It couldn't=20 apply 'pcre-8.37-Fix-another-buffer-overflow.patch': ***SNIP*** Aug 18 19:03:54: Building pcre pcre-8.37.tar.gz checksum OK + cd /usr/src/lfs + make -f pcre LFS_BASEDIR=3D/usr/src install =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Installing pcre-8.37 ... Install started; saving file list to /usr/src/lsalr ... cd /usr/src/pcre-8.37 && patch -Np1 <=20 /usr/src/src/patches/pcre-8.37-Fix-buffer-overflow-for-named-recursive-back-r= eferen.patch patching file pcre_compile.c patching file testdata/testinput2 patching file testdata/testoutput2 cd /usr/src/pcre-8.37 && patch -Np1 <=20 /usr/src/src/patches/pcre-8.37-Fix-buffer-overflow-for-forward-reference-with= in-bac.patch patching file pcre_compile.c patching file testdata/testinput2 patching file testdata/testoutput2 cd /usr/src/pcre-8.37 && patch -Np1 <=20 /usr/src/src/patches/pcre-8.37-Fix-another-buffer-overflow.patch patching file pcre_compile.c Hunk #1 FAILED at 7210. 1 out of 1 hunk FAILED -- saving rejects to file pcre_compile.c.rej patching file testdata/testinput2 patching file testdata/testoutput11-16 patching file testdata/testoutput11-32 patching file testdata/testoutput11-8 patching file testdata/testoutput2 make: *** [/usr/src/log/pcre-8.37] Error 1 ***SNAP*** 'pcre_compile.c.rej' says: ***SNIP*** --- pcre_compile.c +++ pcre_compile.c @@ -7210,7 +7210,12 @@ real compile this will be picked up and the reference=20 wrapped with OP_ONCE to make it atomic, so we must space in case this=20 occurs. */ - if (recno =3D=3D 0) *lengthptr +=3D 2 + 2*LINK_SIZE; + /* In fact, this can happen for a non-forward reference because + another group with the same number might be created later. This + issue is fixed "properly" in PCRE2. As PCRE1 is now in=20 maintenance + only mode, we finesse the bug by allowing more memory always. */ + + /* if (recno =3D=3D 0) */ *lengthptr +=3D 2 + 2*LINK_SIZE; } /* In the real compile, search the name table. We check the name ***SNAP*** Deleting this section didn't help. Anyone else or my fault? Regards Matthias --===============3646272586706143455==--