From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Problems trying to update lua-5.4.3
Date: Tue, 13 Apr 2021 23:06:46 +0200
Message-ID: <55e76ea1-8a41-8a5e-b2c3-4f76015692ef@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7979022683890546609=="
List-Id: <development.lists.ipfire.org>

--===============7979022683890546609==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi All,


I have been working on updating lua from 5.3.5 to 5.4.3

I updated the autotoolize.patch and the shared_library-1.patch and found that=
 5.4.3 no longer has lbitlib.c in the tarball src directory


I removed lbitlib.c from the liblua_la_SOURCES section in the diff for lua-5.=
3.5/src/Makefile.am

-----------------------------------------------------------
+AM_CFLAGS =3D -Wall
+
+include_HEADERS =3D lua.h lualib.h lauxlib.h lua.hpp
+
+nodist_include_HEADERS =3D luaconf.h
+
+lib_LTLIBRARIES =3D liblua.la
+liblua_la_LDFLAGS =3D -release @MAJOR_VERSION@
+liblua_la_SOURCES =3D \
+=C2=A0=C2=A0=C2=A0 lapi.c lauxlib.c lbaselib.c lbitlib.c lcode.c lcorolib.c =
lctype.c ldblib.c \
+=C2=A0=C2=A0=C2=A0 ldebug.c ldo.c ldump.c lfunc.c lgc.c linit.c liolib.c lle=
x.c lmathlib.c lmem.c \
+=C2=A0=C2=A0=C2=A0 loadlib.c lobject.c lopcodes.c loslib.c lparser.c lstate.=
c lstring.c lstrlib.c \
+=C2=A0=C2=A0=C2=A0 ltable.c ltablib.c ltm.c lundump.c lutf8lib.c lvm.c lzio.=
c \
+=C2=A0=C2=A0=C2=A0 lapi.h lcode.h lctype.h ldebug.h ldo.h lfunc.h lgc.h llex=
.h llimits.h \
+=C2=A0=C2=A0=C2=A0 lmem.h lobject.h lopcodes.h lparser.h lstate.h lstring.h =
ltable.h ltm.h \
+=C2=A0=C2=A0=C2=A0 lundump.h lvm.h lzio.h
+

-----------------------------------------------------------

and then lua built without any problems.


So lua built successfully but looking at the files in the tarball src directo=
ry for 5.3.5 & 5.4.3 there are some differences

The following files
lua.c
luac.c
lua.h
luaconf.h
lualib.h
lauxlib.h
lprefix.h

are in both 5.3.5 & 5.4.3 but not in the liblua_la_SOURCES section. This may =
be deliberate, I can't tell.

However lbitlib.c is in 5.3.5 & liblua_la_SOURCES but not in 5.4.3=C2=A0 Is t=
hat a problem for IPFire's use of lua?


ljumptab.h and lopnames.h are not in 5.3.5 or liblua_la_SOURCES but are in 5.=
4.3=C2=A0 Should these now be included somewhere in the Makefile.am or elsewh=
ere or is it OK to ignore them for IPFire?


Regards,

Adolf.


--===============7979022683890546609==--