From mboxrd@z Thu Jan  1 00:00:00 1970
From: IT Superhack <itsuperhack@web.de>
To: development@lists.ipfire.org
Subject: Re: [PATCH] firewalllogcountry.dat: Do not show 'Details' button for
 unkonw location.
Date: Sun, 18 Oct 2015 17:10:51 +0200
Message-ID: <5623B67B.1080408@web.de>
In-Reply-To: <1445167412-3298-1-git-send-email-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7129497559222414012=="
List-Id: <development.lists.ipfire.org>

--===============7129497559222414012==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Stefan,

thanks for caring about this issue.

As far as I can tell, the patch looks good.

However, there is still one issue: Anonymous Proxies are located in the
section "A1", and firewall hits coming from internal networks show up in
"green0", "blue0" or something similar.

What causes the "unknown" firewall hits? The squid proxy? Pseudo traffic
coming from the loop device?

This is just one thing I am a bit confused about.

Best regards,
Timmothy Wilson

Stefan Schantl:
> The CGI offers the posibility to get more details for a certain locations
> by clicking on a button.
>=20
> This feature cannot be used for the category "unknown". To prevent users
> from beeing confused about non show-able details, I added some code to hide
> this button for this category.
>=20
> Fixes #10726.
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  html/cgi-bin/logs.cgi/firewalllogcountry.dat | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/logs.cgi/firewalllogcountry.dat b/html/cgi-bin/lo=
gs.cgi/firewalllogcountry.dat
> index 29c0842..f998a62 100644
> --- a/html/cgi-bin/logs.cgi/firewalllogcountry.dat
> +++ b/html/cgi-bin/logs.cgi/firewalllogcountry.dat
> @@ -456,7 +456,17 @@ for($s=3D0;$s<$lines;$s++)
>    $color++;
>    print "<tr>";
> =20
> -  print "<td align=3D'center' $col><form method=3D'post' action=3D'showreq=
uestfromcountry.dat'><input type=3D'hidden' name=3D'MONTH' value=3D'$cgiparam=
s{'MONTH'}'> <input type=3D'hidden' name=3D'DAY' value=3D'$cgiparams{'DAY'}'>=
 <input type=3D'hidden' name=3D'country' value=3D'$key[$s]'> <input type=3D's=
ubmit' value=3D'details'></form></td>";
> +  print "<td align=3D'center' $col>";
> +
> +  # Dont show details button for "unknown" location.
> +  if ($key[$s] ne 'unknown') {
> +	print"<form method=3D'post' action=3D'showrequestfromcountry.dat'>";
> +	print"<input type=3D'hidden' name=3D'MONTH' value=3D'$cgiparams{'MONTH'}'=
>";
> +	print"<input type=3D'hidden' name=3D'DAY' value=3D'$cgiparams{'DAY'}'>";
> +	print"<input type=3D'hidden' name=3D'country' value=3D'$key[$s]'>";
> +	print"<input type=3D'submit' value=3D'details'></form>";
> +  }
> +
>    if($key[$s] eq 'blue0' || $key[$s] eq 'green0' || $key[$s] eq 'orange0')=
 {
>        print "<td align=3D'center' $col>$key[$s]</td>";
>    }
>=20



--===============7129497559222414012==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRRWNCQUVCQ2dBR0JRSldJN2FHQUFvSkVP
eUxhMUM1RWF6cjIxZ0gvQXExTUY0ZkhIUjhGU2dFaVVpejFxckwKSkQ1WEVDa3Q5d2Vzd2czOFBQ
YUgzampiaXdUYXdORjhGb1VGT1pEQ3ZOZ0owQkNWWXdXSjBGRlo2VXZvWFgzeQpIQnZlUVZFMWJP
OEZhVGZxajd2UWI5NXBrL3JHbm12VmpSNmtocHNwRi8veUdlQU5SRXgvMnhJdTZ0N3NTTWNXCmM4
WXp6QW9qRDhLOC9PUEdzcjFDVnZickNSQUlKa0VkNGREWHFHZWpsa2pacUc1SXlaNnQ0eVNta1Bj
TElua2IKcTF4Y3hhTXRZWGQ5WHFBbFlDZEZva2FKc3BwaUVHRFdaSjhDT04wUHZ0dzRnbzNCaUVJ
YUc1R3ZlUEZic0Njcwp0aEJxQlE1bTloV2tzQmNlVDcvN2JQblhFaEkrNy8yQU5vZ1U4LzY0aytS
c3ZLek44S0Yyd0orbERSVXBROXM9Cj15Vmt1Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============7129497559222414012==--