From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [IPv6:::1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4cgNZn2fxRz32g4 for ; Mon, 06 Oct 2025 15:33:21 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (Client CN "mail01.haj.ipfire.org", Issuer "R13" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4cgNZk0Fh1z2xMF for ; Mon, 06 Oct 2025 15:33:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail01.ipfire.org (Postfix) with ESMTPSA id 4cgNZj2jgZzGT; Mon, 06 Oct 2025 15:33:17 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003ed25519; t=1759764797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=//42Uht8kBPNjvHoptL9ps6MEm9m2i2eneiL3AHf1wI=; b=CCJ/AULeLe6RGyzwNtwUXZv2vsSBctjQ9DdrQpbL3mx4wZvg0fI6GFahtDvcz38dI3DI8Y GuNzRPbbVeXZxRDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfire.org; s=202003rsa; t=1759764797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=//42Uht8kBPNjvHoptL9ps6MEm9m2i2eneiL3AHf1wI=; b=K7NHAJklFUApFpaOvjOrthTO2JzBKT+taBz03L2eezLxg8vmHTnfDR0122Da6+DnSQUDiT yXxJ1JpuCo6hoSOkwg0umJFzTbRPmofC8BTCy8tyxpxToi5uBnW8fdESMIBEYDiyuUjK00 t8Tvdei93Xo5t27BgC86z6oGHUQhSpzeZ1fK0gj10YDUQYyEWnjldwC0N9cgzCNng+fWvP Q/aNCRbxdRBMqC2eCeTcmk2z0QaGxe5ppMxtrWw5Eh5/XhSUdH77N4rfOjgzUChkX5V8nO rMHZ9Lwj3F9DSKhM9ZkoXphqLH+ANvcDqTCm1Gdf5/u+A/+gwKkOE6TeWEf+Vw== Content-Type: text/plain; charset=us-ascii Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: Mime-Version: 1.0 Subject: Re: [PATCH] nasm: Add patch fix for typo in le32toh function name From: Michael Tremer In-Reply-To: <20251006153237.2443560-1-adolf.belka@ipfire.org> Date: Mon, 6 Oct 2025 16:33:17 +0100 Cc: development@lists.ipfire.org Content-Transfer-Encoding: quoted-printable Message-Id: <5647A9CD-CA1C-478C-A34B-A02726C23927@ipfire.org> References: <20251006153237.2443560-1-adolf.belka@ipfire.org> To: Adolf Belka Okay, this was super fast :) > On 6 Oct 2025, at 16:32, Adolf Belka wrote: >=20 > - nasm failed to build with aarch64 due to a typo in the 3.00 source = tarball where > l32toh had been written in bytesex.h instead of le32toh > - This patch includes the fix for that. The applied patch will be able = to be removed > when the next release after 3.00 is issued. > - Tested the build on the aarch64 builder and nasm successfully built = with the patch > applied. > - Update of rootfile not required >=20 > Signed-off-by: Adolf Belka > --- > lfs/nasm | 1 + > ...00_fix_typo_in_le32toh_function_name.patch | 20 +++++++++++++++++++ > 2 files changed, 21 insertions(+) > create mode 100644 = src/patches/nasm-3.00_fix_typo_in_le32toh_function_name.patch >=20 > diff --git a/lfs/nasm b/lfs/nasm > index daeb44535..bd56757d9 100644 > --- a/lfs/nasm > +++ b/lfs/nasm > @@ -70,6 +70,7 @@ $(subst %,%_BLAKE2,$(objects)) : > $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > @$(PREBUILD) > @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE) > + cd $(DIR_APP) && patch -Np1 < = $(DIR_SRC)/src/patches/nasm-3.00_fix_typo_in_le32toh_function_name.patch > cd $(DIR_APP) && ./configure \ > --prefix=3D/usr > cd $(DIR_APP) && make $(MAKETUNING) > diff --git = a/src/patches/nasm-3.00_fix_typo_in_le32toh_function_name.patch = b/src/patches/nasm-3.00_fix_typo_in_le32toh_function_name.patch > new file mode 100644 > index 000000000..3b198b2d8 > --- /dev/null > +++ b/src/patches/nasm-3.00_fix_typo_in_le32toh_function_name.patch > @@ -0,0 +1,20 @@ > +--- nasm-3.00/include/bytesex.h.orig 2025-10-03 21:41:41.000000000 = +0200 > ++++ nasm-3.00/include/bytesex.h 2025-10-06 15:03:06.434849426 +0200 > +@@ -215,7 +215,7 @@ > + } __attribute__((packed)); > + static inline uint32_t getu32(const void *p) > + { > +- return l32toh(((const struct unaligned32 *)p)->v); > ++ return le32toh(((const struct unaligned32 *)p)->v); > + } > + static inline uint32_t setu32(void *p, uint32_t v) > + { > +@@ -253,7 +253,7 @@ > + static inline uint32_t getu32(const void *p) > + { > + const uint32_t _unaligned *pp =3D p; > +- return l32toh(*pp); > ++ return le32toh(*pp); > + } > + static inline uint32_t setu32(void *p, uint32_t v) > + { > --=20 > 2.51.0 >=20 >=20