From: IT Superhack <itsuperhack@web.de>
To: development@lists.ipfire.org
Subject: [PATCH] Mark recommended ciphers/algorithms
Date: Fri, 18 Dec 2015 17:12:18 +0100 [thread overview]
Message-ID: <56743062.6040807@web.de> (raw)
In-Reply-To: <1449767773.31655.108.camel@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 3792 bytes --]
This marks AES-CBC (256 bits) as "recommended" on the OpenVPN main cgi, which is also set as default already.
Furthermore, SHA1 is marked as "weak" on the "advanced options" page in the OpenVPN cgi.
All translations for "recommended" and "weak" are still missing, except the german one.
Signed-off-by: Timmothy Wilson <itsuperhack(a)web.de>
---
diff --git a/html/cgi-bin/ovpnmain.cgi b/html/cgi-bin/ovpnmain.cgi
index 62af54e..cd85a9e 100644
--- a/html/cgi-bin/ovpnmain.cgi
+++ b/html/cgi-bin/ovpnmain.cgi
@@ -4687,7 +4687,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
<option value='CAMELLIA-256-CBC' $selected{'DCIPHER'}{'CAMELLIA-256-CBC'}>CAMELLIA-CBC (256 $Lang::tr{'bit'})</option>
<option value='CAMELLIA-192-CBC' $selected{'DCIPHER'}{'CAMELLIA-192-CBC'}>CAMELLIA-CBC (192 $Lang::tr{'bit'})</option>
<option value='CAMELLIA-128-CBC' $selected{'DCIPHER'}{'CAMELLIA-128-CBC'}>CAMELLIA-CBC (128 $Lang::tr{'bit'})</option>
- <option value='AES-256-CBC' $selected{'DCIPHER'}{'AES-256-CBC'}>AES-CBC (256 $Lang::tr{'bit'}, $Lang::tr{'default'})</option>
+ <option value='AES-256-CBC' $selected{'DCIPHER'}{'AES-256-CBC'}>AES-CBC (256 $Lang::tr{'bit'}, $Lang::tr{'default'}) ($Lang::tr{'recommended'})</option>
<option value='AES-192-CBC' $selected{'DCIPHER'}{'AES-192-CBC'}>AES-CBC (192 $Lang::tr{'bit'})</option>
<option value='AES-128-CBC' $selected{'DCIPHER'}{'AES-128-CBC'}>AES-CBC (128 $Lang::tr{'bit'})</option>
<option value='DES-EDE3-CBC' $selected{'DCIPHER'}{'DES-EDE3-CBC'}>DES-EDE3-CBC (192 $Lang::tr{'bit'})</option>
@@ -4705,7 +4705,7 @@ if ($cgiparams{'TYPE'} eq 'net') {
<option value='SHA512' $selected{'DAUTH'}{'SHA512'}>SHA2 (512 $Lang::tr{'bit'})</option>
<option value='SHA384' $selected{'DAUTH'}{'SHA384'}>SHA2 (384 $Lang::tr{'bit'})</option>
<option value='SHA256' $selected{'DAUTH'}{'SHA256'}>SHA2 (256 $Lang::tr{'bit'})</option>
- <option value='SHA1' $selected{'DAUTH'}{'SHA1'}>SHA1 (160 $Lang::tr{'bit'} Default)</option>
+ <option value='SHA1' $selected{'DAUTH'}{'SHA1'}>SHA1 (160 $Lang::tr{'bit'} Default) ($Lang::tr{'weak'})</option>
</select>
</td>
</tr>
diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
index 2bca854..1d1705b 100644
--- a/langs/de/cgi-bin/de.pl
+++ b/langs/de/cgi-bin/de.pl
@@ -1912,6 +1912,7 @@
'reboot sure' => 'Sind Sie sicher, dass Sie neustarten wollen?',
'rebooting' => 'Starte neu ...',
'rebooting ipfire' => 'Starte IPFire neu',
+'recommended' => 'empfohlen',
'reconnect' => 'Neu Verbinden',
'reconnection' => 'Wiederverbindung',
'red' => 'Internet',
@@ -2631,6 +2632,7 @@
'warn when traffic reaches' => 'Warnen wenn Traffic x % erreicht',
'warning messages' => 'Warnhinweise',
'was deleted' => 'wurde gelöscht',
+'weak' => 'schwach',
'web hits' => 'Gesamtanzahl der Websites zum ausgewählten Kriterium',
'web proxy' => 'Web-Proxy',
'web proxy configuration' => 'Web-Proxy-Konfiguration',
diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
index 4c52392..32911a3 100644
--- a/langs/en/cgi-bin/en.pl
+++ b/langs/en/cgi-bin/en.pl
@@ -1945,6 +1945,7 @@
'reboot sure' => 'Are you sure that you want to reboot?',
'rebooting' => 'Rebooting',
'rebooting ipfire' => 'Rebooting IPFire',
+'recommended' => 'recommended',
'reconnect' => 'Reconnect',
'reconnection' => 'Reconnection',
'red' => 'Internet',
@@ -2675,6 +2676,7 @@
'warn when traffic reaches' => 'Warn when traffic reaches x %',
'warning messages' => 'Warning messages',
'was deleted' => 'was deleted',
+'weak' => 'weak',
'web hits' => 'Total number of websites matching selected criteria for',
'web proxy' => 'Web Proxy',
'web proxy configuration' => 'Web proxy configuration',
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2015-12-18 16:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 14:18 [PATCH] Disallow OpenVPN DH params less than 1024 bits IT Superhack
2015-11-24 14:14 ` ue
2015-12-01 22:58 ` Michael Tremer
2015-12-02 9:07 ` IT Superhack
2015-12-02 10:47 ` Michael Tremer
2015-12-02 18:19 ` IT Superhack
2015-12-07 16:35 ` [PATCH] Mark recommended ciphers/algorithms IT Superhack
2015-12-10 17:16 ` Michael Tremer
2015-12-13 15:10 ` IT Superhack
2015-12-13 17:47 ` Larsen
2015-12-15 14:13 ` Michael Tremer
2015-12-15 15:03 ` Larsen
2015-12-15 21:18 ` Michael Tremer
2015-12-16 8:06 ` Larsen
2015-12-18 16:12 ` IT Superhack [this message]
2016-01-01 16:54 ` IT Superhack
2016-01-04 16:31 ` Michael Tremer
2016-01-10 16:29 ` IT Superhack
2016-01-10 22:22 ` Michael Tremer
2016-01-02 13:03 ` ue
2016-01-04 16:36 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56743062.6040807@web.de \
--to=itsuperhack@web.de \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox